External::shutdownScanner() - Code Metrics - Inspection of "Reject uploads when antivirus is unreachable" - owncloud/files_antivirus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#195)

by Victor

created 2017-11-28 07:13 UTC

External::shutdownScanner() A

↳ Parent: External

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	11
ccs	10
cts	10
cp	1
rs	9.4285
c	1
b	0
f	0
cc	1
eloc	8
nc	1
nop	0
crap	1

<?php
/**
 * Copyright (c) 2017 Viktar Dubiniuk <[email protected]>
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */


namespace OCA\Files_Antivirus\Scanner;

abstract class External extends AbstractScanner {
	/**
	 * Send an empty chunk to indicate the end of stream,
	 * read response and close the handle
	 */
	protected function shutdownScanner(){
		@fwrite($this->getWriteHandle(), pack('N', 0));
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		$response = fgets($this->getWriteHandle());
		$this->logger->debug(
			'Response :: ' . $response,
			['app' => 'files_antivirus']
		);
		@fclose($this->getWriteHandle());
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

		$this->status->parseResponse($response);
	}

	/**
	 * Prepend a chunk sent to ClamAv with its length
	 * @param string $data
	 * @return string
	 */
	protected function prepareChunk($data){
		$chunkLength = pack('N', strlen($data));
		return $chunkLength . $data;
	}
}


1		<?php
2		/**
3		* Copyright (c) 2017 Viktar Dubiniuk <[email protected]>
4		* This file is licensed under the Affero General Public License version 3 or
5		* later.
6		* See the COPYING-README file.
7		*/
8
9
10		namespace OCA\Files_Antivirus\Scanner;
11
12		abstract class External extends AbstractScanner {
13		/**
14		* Send an empty chunk to indicate the end of stream,
15		* read response and close the handle
16		*/
17	2	protected function shutdownScanner(){
18	2	@fwrite($this->getWriteHandle(), pack('N', 0));
		0 ignored issues – show Security Best Practice introduced 2016-11-03 18:42 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
19	2	$response = fgets($this->getWriteHandle());
20	2	$this->logger->debug(
21	2	'Response :: ' . $response,
22	2	['app' => 'files_antivirus']
23	2	);
24	2	@fclose($this->getWriteHandle());
		0 ignored issues – show Security Best Practice introduced 2016-11-03 16:16 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
25
26	2	$this->status->parseResponse($response);
27	2	}
28
29		/**
30		* Prepend a chunk sent to ClamAv with its length
31		* @param string $data
32		* @return string
33		*/
34	2	protected function prepareChunk($data){
35	2	$chunkLength = pack('N', strlen($data));
36	2	return $chunkLength . $data;
37		}
38		}
39

owncloud / files_antivirus

Pull Request — master (#195)

External::shutdownScanner() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like