OCA\Files_Antivirus\Scanner\External::initScanner()

Complexity

Conditions	6
Paths	10

Size

Total Lines	21
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	7.6393

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	External::prepareChunk()	0	4	1

<?php
/**
 * Copyright (c) 2017 Viktar Dubiniuk <dubiniuk@owncloud.com>
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */


namespace OCA\Files_Antivirus\Scanner;

abstract class External extends AbstractScanner {
	/**
	 * Send an empty chunk to indicate the end of stream,
	 * read response and close the handle
	 */
	protected function shutdownScanner(){
		@fwrite($this->getWriteHandle(), pack('N', 0));

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

		$response = fgets($this->getWriteHandle());
		$this->logger->debug(
			'Response :: ' . $response,
			['app' => 'files_antivirus']
		);
		@fclose($this->getWriteHandle());

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

		$this->status->parseResponse($response);
	}

	/**
	 * Prepend a chunk sent to ClamAv with its length
	 * @param string $data
	 * @return string
	 */
	protected function prepareChunk($data){
		$chunkLength = pack('N', strlen($data));
		return $chunkLength . $data;
	}
}