Socket::initScanner() - Code Metrics - Inspection of "Inject logger" - owncloud/files_antivirus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — closes-181 ( eab433...fdd93f )

by Victor

created 2017-10-23 22:28 UTC

Socket::initScanner() A

↳ Parent: Socket

Complexity

Conditions	2
Paths	2

Size

Total Lines	20
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	20
ccs	0
cts	18
cp	0
rs	9.4285
c	0
b	0
f	0
nc	2
cc	2
eloc	12
nop	0
crap	6

<?php
/**
 * Copyright (c) 2017 Viktar Dubiniuk <[email protected]>
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */


namespace OCA\Files_Antivirus\Scanner;

class Socket extends Daemon {

	public function initScanner(){
		parent::initScanner();

		$this->writeHandle = stream_socket_client(
			'unix://' . $this->appConfig->getAvSocket(), $errorCode, $errorMessage, 5
		);
		if (!$this->getWriteHandle()) {
			throw new InitException(
				sprintf(
					'Could not connect to socket "%s": %s (code %d)',
					$this->appConfig->getAvSocket(),
					$errorMessage,
					$errorCode
				)
			);
		}

		// request scan from the daemon
		@fwrite($this->getWriteHandle(), "nINSTREAM\n");
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
	}
}


1			<?php
2			/**
3			* Copyright (c) 2017 Viktar Dubiniuk <[email protected]>
4			* This file is licensed under the Affero General Public License version 3 or
5			* later.
6			* See the COPYING-README file.
7			*/
8
9
10			namespace OCA\Files_Antivirus\Scanner;
11
12			class Socket extends Daemon {
13
14			public function initScanner(){
15			parent::initScanner();
16
17			$this->writeHandle = stream_socket_client(
18			'unix://' . $this->appConfig->getAvSocket(), $errorCode, $errorMessage, 5
19			);
20			if (!$this->getWriteHandle()) {
21			throw new InitException(
22			sprintf(
23			'Could not connect to socket "%s": %s (code %d)',
24			$this->appConfig->getAvSocket(),
25			$errorMessage,
26			$errorCode
27			)
28			);
29			}
30
31			// request scan from the daemon
32			@fwrite($this->getWriteHandle(), "nINSTREAM\n");
			0 ignored issues – show Security Best Practice introduced 2017-10-23 22:03 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
33			}
34			}
35

owncloud / files_antivirus

Push — closes-181 ( eab433...fdd93f )

Socket::initScanner() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like