Completed
Push — fix-125 ( 2c3e6e...981995 )
by Victor
25:47
created

External::getWriteHandle()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 3
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 3
rs 10
c 0
b 0
f 0
cc 1
eloc 2
nc 1
nop 0
1
<?php
2
/**
3
 * Copyright (c) 2014 Victor Dubiniuk <[email protected]>
4
 * This file is licensed under the Affero General Public License version 3 or
5
 * later.
6
 * See the COPYING-README file.
7
 */
8
9
10
namespace OCA\Files_Antivirus\Scanner;
11
12
class External extends \OCA\Files_Antivirus\Scanner {
13
	
14
	// Daemon/socket mode
15
	private $useSocket;
16
	
17
	public function __construct($config){
18
		$this->appConfig = $config;
19
		$this->useSocket = $this->appConfig->getAvMode() === 'socket';
20
	}
21
	
22
	protected function initScanner(){
23
		parent::initScanner();
24
		
25
		if ($this->useSocket){
26
			$avSocket = $this->appConfig->getAvSocket();
27
			$this->writeHandle = stream_socket_client('unix://' . $avSocket, $errno, $errstr, 5);
28
			if (!$this->getWriteHandle()) {
29
				throw new \RuntimeException('Cannot connect to "' . $avSocket . '": ' . $errstr . ' (code ' . $errno . ')');
30
			}
31
		} else {
32
			$avHost = $this->appConfig->getAvHost();
33
			$avPort = $this->appConfig->getAvPort();
34
			$this->writeHandle = ($avHost && $avPort) ? @fsockopen($avHost, $avPort) : false;
35
			if (!$this->getWriteHandle()) {
36
				throw new \RuntimeException('The clamav module is not configured for daemon mode.');
37
			}
38
		}
39
40
		// request scan from the daemon
41
		$this->fwrite("nINSTREAM\n");
42
	}
43
	
44
	protected function shutdownScanner(){
45
		$this->fwrite($this->getWriteHandle(), pack('N', 0));
0 ignored issues
show
Unused Code introduced by
The call to External::fwrite() has too many arguments starting with pack('N', 0).

This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress.

In this case you can add the @ignore PhpDoc annotation to the duplicate definition and it will be ignored.

Loading history...
46
		$response = fgets($this->getWriteHandle());
47
		\OCP\Util::writeLog('files_antivirus', 'Response :: '.$response, \OCP\Util::DEBUG);
48
		@fclose($this->getWriteHandle());
0 ignored issues
show
Security Best Practice introduced by
It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

If you suppress an error, we recommend checking for the error condition explicitly:

// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
Loading history...
49
		
50
		$this->status->parseResponse($response);
51
	}
52
	
53
	protected function prepareChunk($data){
54
		$chunk_len = pack('N', strlen($data));
55
		return $chunk_len.$data;
56
	}
57
}
58