Local::shutdownScanner() - Code Metrics - Inspection of "Move Absract scanner to scanners. Refactor socket..." - owncloud/files_antivirus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#195)

by Victor

created 2017-10-23 22:00 UTC

Local::shutdownScanner() A

↳ Parent: Local

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	1

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	12
ccs	10
cts	10
cp	1
rs	9.4285
nc	1
cc	1
eloc	9
nop	0
crap	1

<?php
/**
 * Copyright (c) 2014 Viktar Dubiniuk <[email protected]>
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */


namespace OCA\Files_Antivirus\Scanner;

class Local extends AbstractScanner{
	
	/**
	 * @var string
	 */
	protected $avPath;
	
	/**
	 * STDIN and STDOUT descriptors
	 * @var array of resources
	 */
	private $pipes = [];
	
	/**
	 * Process handle
	 * @var resource
	 */
	private $process;
	
	public function __construct($config){
		$this->appConfig = $config;
		// get the path to the executable
		$this->avPath = escapeshellcmd($this->appConfig->getAvPath());

		if (!file_exists($this->avPath)) {
			throw new InitException(
				sprintf(
					'The antivirus executable could not be found at path "%s"',
					$this->avPath
				)
			);
		}
	}
	
	public function initScanner(){
		parent::initScanner();
		
		// using 2>&1 to grab the full command-line output.
		$cmd = $this->avPath . " " . $this->appConfig->getCmdline() ." - 2>&1";
		$descriptorSpec = array(
			0 => ["pipe","r"], // STDIN
			1 => ["pipe","w"]  // STDOUT
		);
		
		$this->process = proc_open($cmd, $descriptorSpec, $this->pipes);
		if (!is_resource($this->process)) {
			throw new InitException(
				sprintf('Error starting process "%s"', $cmd)
			);
		}
		$this->writeHandle = $this->pipes[0];
	}
	
	protected function shutdownScanner(){
		@fclose($this->pipes[0]);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		$output = stream_get_contents($this->pipes[1]);
		@fclose($this->pipes[1]);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		
		$result = proc_close($this->process);
		\OC::$server->getLogger()->debug(
			'Exit code :: ' . $result . ' Response :: ' . $output,
			['app' => 'files_antivirus']
		);
		$this->status->parseResponse($output, $result);
	}
}


1		<?php
2		/**
3		* Copyright (c) 2014 Viktar Dubiniuk <[email protected]>
4		* This file is licensed under the Affero General Public License version 3 or
5		* later.
6		* See the COPYING-README file.
7		*/
8
9
10		namespace OCA\Files_Antivirus\Scanner;
11
12		class Local extends AbstractScanner{
13
14		/**
15		* @var string
16		*/
17		protected $avPath;
18
19		/**
20		* STDIN and STDOUT descriptors
21		* @var array of resources
22		*/
23		private $pipes = [];
24
25		/**
26		* Process handle
27		* @var resource
28		*/
29		private $process;
30
31	4	public function __construct($config){
32	4	$this->appConfig = $config;
33		// get the path to the executable
34	4	$this->avPath = escapeshellcmd($this->appConfig->getAvPath());
35
36	4	if (!file_exists($this->avPath)) {
37	2	throw new InitException(
38	2	sprintf(
39	2	'The antivirus executable could not be found at path "%s"',
40	2	$this->avPath
41		)
42		);
43		}
44	2	}
45
46	2	public function initScanner(){
47	2	parent::initScanner();
48
49		// using 2>&1 to grab the full command-line output.
50	2	$cmd = $this->avPath . " " . $this->appConfig->getCmdline() ." - 2>&1";
51		$descriptorSpec = array(
52	2	0 => ["pipe","r"], // STDIN
53		1 => ["pipe","w"] // STDOUT
54		);
55
56	2	$this->process = proc_open($cmd, $descriptorSpec, $this->pipes);
57	2	if (!is_resource($this->process)) {
58		throw new InitException(
59		sprintf('Error starting process "%s"', $cmd)
60		);
61		}
62	2	$this->writeHandle = $this->pipes[0];
63	2	}
64
65	2	protected function shutdownScanner(){
66	2	@fclose($this->pipes[0]);
		0 ignored issues – show Security Best Practice introduced 2016-11-03 16:16 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
67	2	$output = stream_get_contents($this->pipes[1]);
68	2	@fclose($this->pipes[1]);
		0 ignored issues – show Security Best Practice introduced 2016-11-03 16:16 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
69
70	2	$result = proc_close($this->process);
71	2	\OC::$server->getLogger()->debug(
72	2	'Exit code :: ' . $result . ' Response :: ' . $output,
73	2	['app' => 'files_antivirus']
74		);
75	2	$this->status->parseResponse($output, $result);
76	2	}
77		}
78

owncloud / files_antivirus

Pull Request — master (#195)

Local::shutdownScanner() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like