OCA\Files_Antivirus\Scanner\Daemon

Complexity

Total Complexity

8

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	25	4
A	initScanner()	0	13	2
A	shutdownScanner()	0	11	1
A	prepareChunk()	0	4	1

<?php
/**
 * Copyright (c) 2014 Viktar Dubiniuk <dubiniuk@owncloud.com>
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */


namespace OCA\Files_Antivirus\Scanner;

use OCA\Files_Antivirus\AppConfig;
use OCP\ILogger;

class Daemon extends AbstractScanner {

	public function __construct(AppConfig $config, ILogger $logger) {
		parent::__construct($config, $logger);

		$avHost = $this->appConfig->getAvHost();
		$avPort = $this->appConfig->getAvPort();
		$checks = [
			'hostname' => $avHost,
			'port' => $avPort
		];
		$errors = [];
		foreach ($checks as $key => $check) {
			if ($check === '') {
				$errors[] = sprintf(
					'Daemon mode requires a %s but it is empty.',
					$key
				);
			}
		}

		if (count($errors) > 0) {
			throw new InitException(
				'The app is not configured properly. ' . implode(' ', $errors)
			);
		}
	}

	public function initScanner(){
		parent::initScanner();
		$this->writeHandle = @fsockopen($avHost, $avPort);

The variable $avHost does not exist. Did you forget to declare it?

The variable $avPort does not exist. Did you forget to declare it?

		if (!$this->getWriteHandle()) {
			throw new InitException(
				sprintf(
					'Could not connect to host "%s" on port %d', $avHost, $avPort
				)
			);
		}
		// request scan from the daemon
		@fwrite($this->getWriteHandle(), "nINSTREAM\n");

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

	}
	
	protected function shutdownScanner(){
		@fwrite($this->getWriteHandle(), pack('N', 0));

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

		$response = fgets($this->getWriteHandle());
		$this->logger->debug(
			'Response :: ' . $response,
			['app' => 'files_antivirus']
		);
		@fclose($this->getWriteHandle());

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

		
		$this->status->parseResponse($response);
	}
	
	protected function prepareChunk($data){
		$chunkLength = pack('N', strlen($data));
		return $chunkLength . $data;
	}
}