Status::parseResponse() - Code Metrics - Inspection of "Fix query, catch and log fs exception" - owncloud/files_antivirus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — antivirus-update ( fcda38...b6d85d )

by Victor

created 2016-06-09 17:22 UTC

Status::parseResponse() C

↳ Parent: Status

Complexity

Conditions	15
Paths	23

Size

Total Lines	57
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	1	Features	0

Metric	Value
cc	15
eloc	39
c	4
b	1
f	0
nc	23
nop	2
dl	0
loc	57
rs	6.5498

How to fix Long Method Complexity

<?php
/**
 * Copyright (c) 2014 Victor Dubiniuk <[email protected]>
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */

namespace OCA\Files_Antivirus;

class Status {
	
	/*
	 *  The file was not checked (e.g. because the AV daemon wasn't running).
	 */
	const SCANRESULT_UNCHECKED = -1;

	/*
	 *  The file was checked and found to be clean.
	 */
	const SCANRESULT_CLEAN = 0;

	/*
	 *  The file was checked and found to be infected.
	 */
	const SCANRESULT_INFECTED = 1;
	
	/*
	 * Should be SCANRESULT_UNCHECKED | SCANRESULT_INFECTED | SCANRESULT_CLEAN
	 */
	protected $numericStatus;
	
	/*
	 * Virus name or error message
	 */
	protected $details = "";
	
	protected $ruleMapper;
	
	public function __construct(){
		$this->numericStatus = self::SCANRESULT_UNCHECKED;
		$this->ruleMapper = new Db\RuleMapper(\OC::$server->getDb());
	}
	
	/**
	 * Get scan status as integer
	 * @return int
	 */
	public function getNumericStatus(){
		return $this->numericStatus;
	}
	
	/**
	 * Get scan status as string
	 * @return string
	 */
	public function getDetails(){
		return $this->details;
	}
	
	/**
	 * @param string $rawResponse
	 * @param integer $result
	 */
	public function parseResponse($rawResponse, $result = null){
		$matches = array();
		$ruleMapper = new Db\RuleMapper(\OC::$server->getDb());
		if (is_null($result)){ // Daemon or socket mode
			try{
				$allRules = $this->getResponseRules();
			} catch (\Exception $e){
				\OCP\Util::writeLog('files_antivirus', __METHOD__.', exception: '.$e->getMessage(), \OCP\Util::ERROR);
				return;
			}
			
			$isMatched = false;
			foreach ($allRules as $rule){
				if (preg_match($rule->getMatch(), $rawResponse, $matches)){
					$isMatched = true;
					$this->numericStatus = $rule->getStatus();
					if (intval($rule->getStatus())===self::SCANRESULT_CLEAN){
						$this->details = '';
					} else {
						$this->details = isset($matches[1]) ? $matches[1] : 'unknown';
					}
					break;
				}
			}
			
			if (!$isMatched){
				$this->numericStatus = self::SCANRESULT_UNCHECKED;
				$this->details = 'No matching rules. Please check antivirus rules.';
			}
			
		} else { // Executable mode
			$scanStatus = $ruleMapper->findByResult($result);
			if (is_array($scanStatus) && count($scanStatus)){
				$this->numericStatus = $scanStatus[0]->getStatus();
				$this->details = $scanStatus[0]->getDescription();
			}
			
			switch($this->numericStatus) {
				case self::SCANRESULT_INFECTED:
					$report = array();
					$rawResponse = explode("\n", $rawResponse);
					
					foreach ($rawResponse as $line){	
						if (preg_match('/.*: (.*) FOUND\s*$/', $line, $matches)) {
							$report[] = $matches[1];
						}
					}
					$this->details = implode(', ', $report);
					
					break;
				case self::SCANRESULT_UNCHECKED:
					if (!$this->details) {
						$this->details = 'No matching rule for exit code ' .  $this->numericStatus .'. Please check antivirus rules configuration.' ;
					}
			}
		}
	}
	
	protected function getResponseRules(){
		$infectedRules = $this->ruleMapper->findAllMatchedByStatus(self::SCANRESULT_INFECTED);
		$uncheckedRules = $this->ruleMapper->findAllMatchedByStatus(self::SCANRESULT_UNCHECKED);
		$cleanRules = $this->ruleMapper->findAllMatchedByStatus(self::SCANRESULT_CLEAN);
		
		$infectedRules = $infectedRules ? $infectedRules : array();
		$uncheckedRules = $uncheckedRules ? $uncheckedRules : array();
		$cleanRules = $cleanRules ? $cleanRules : array();
		
		// order: clean, infected, try to guess error
		$allRules = array_merge($cleanRules, $infectedRules, $uncheckedRules);
		return $allRules;
	}
	
	public function dispatch($item, $isBackground = false){
		switch($this->getNumericStatus()) {
			case self::SCANRESULT_UNCHECKED:
				$item->processUnchecked($this, $isBackground);
				break;
			case self::SCANRESULT_INFECTED:
				$item->processInfected($this, $isBackground);
				break;
			case self::SCANRESULT_CLEAN:
				$item->processClean($this, $isBackground);
				break;
		}
	}
}


1			<?php
2			/**
3			* Copyright (c) 2014 Victor Dubiniuk <[email protected]>
4			* This file is licensed under the Affero General Public License version 3 or
5			* later.
6			* See the COPYING-README file.
7			*/
8
9			namespace OCA\Files_Antivirus;
10
11			class Status {
12
13			/*
14			* The file was not checked (e.g. because the AV daemon wasn't running).
15			*/
16			const SCANRESULT_UNCHECKED = -1;
17
18			/*
19			* The file was checked and found to be clean.
20			*/
21			const SCANRESULT_CLEAN = 0;
22
23			/*
24			* The file was checked and found to be infected.
25			*/
26			const SCANRESULT_INFECTED = 1;
27
28			/*
29			* Should be SCANRESULT_UNCHECKED \| SCANRESULT_INFECTED \| SCANRESULT_CLEAN
30			*/
31			protected $numericStatus;
32
33			/*
34			* Virus name or error message
35			*/
36			protected $details = "";
37
38			protected $ruleMapper;
39
40			public function __construct(){
41			$this->numericStatus = self::SCANRESULT_UNCHECKED;
42			$this->ruleMapper = new Db\RuleMapper(\OC::$server->getDb());
43			}
44
45			/**
46			* Get scan status as integer
47			* @return int
48			*/
49			public function getNumericStatus(){
50			return $this->numericStatus;
51			}
52
53			/**
54			* Get scan status as string
55			* @return string
56			*/
57			public function getDetails(){
58			return $this->details;
59			}
60
61			/**
62			* @param string $rawResponse
63			* @param integer $result
64			*/
65			public function parseResponse($rawResponse, $result = null){
66			$matches = array();
67			$ruleMapper = new Db\RuleMapper(\OC::$server->getDb());
68			if (is_null($result)){ // Daemon or socket mode
69			try{
70			$allRules = $this->getResponseRules();
71			} catch (\Exception $e){
72			\OCP\Util::writeLog('files_antivirus', __METHOD__.', exception: '.$e->getMessage(), \OCP\Util::ERROR);
73			return;
74			}
75
76			$isMatched = false;
77			foreach ($allRules as $rule){
78			if (preg_match($rule->getMatch(), $rawResponse, $matches)){
79			$isMatched = true;
80			$this->numericStatus = $rule->getStatus();
81			if (intval($rule->getStatus())===self::SCANRESULT_CLEAN){
82			$this->details = '';
83			} else {
84			$this->details = isset($matches[1]) ? $matches[1] : 'unknown';
85			}
86			break;
87			}
88			}
89
90			if (!$isMatched){
91			$this->numericStatus = self::SCANRESULT_UNCHECKED;
92			$this->details = 'No matching rules. Please check antivirus rules.';
93			}
94
95			} else { // Executable mode
96			$scanStatus = $ruleMapper->findByResult($result);
97			if (is_array($scanStatus) && count($scanStatus)){
98			$this->numericStatus = $scanStatus[0]->getStatus();
99			$this->details = $scanStatus[0]->getDescription();
100			}
101
102			switch($this->numericStatus) {
103			case self::SCANRESULT_INFECTED:
104			$report = array();
105			$rawResponse = explode("\n", $rawResponse);
106
107			foreach ($rawResponse as $line){
108			if (preg_match('/.: (.) FOUND\s*$/', $line, $matches)) {
109			$report[] = $matches[1];
110			}
111			}
112			$this->details = implode(', ', $report);
113
114			break;
115			case self::SCANRESULT_UNCHECKED:
116			if (!$this->details) {
117			$this->details = 'No matching rule for exit code ' . $this->numericStatus .'. Please check antivirus rules configuration.' ;
118			}
119			}
120			}
121			}
122
123			protected function getResponseRules(){
124			$infectedRules = $this->ruleMapper->findAllMatchedByStatus(self::SCANRESULT_INFECTED);
125			$uncheckedRules = $this->ruleMapper->findAllMatchedByStatus(self::SCANRESULT_UNCHECKED);
126			$cleanRules = $this->ruleMapper->findAllMatchedByStatus(self::SCANRESULT_CLEAN);
127
128			$infectedRules = $infectedRules ? $infectedRules : array();
129			$uncheckedRules = $uncheckedRules ? $uncheckedRules : array();
130			$cleanRules = $cleanRules ? $cleanRules : array();
131
132			// order: clean, infected, try to guess error
133			$allRules = array_merge($cleanRules, $infectedRules, $uncheckedRules);
134			return $allRules;
135			}
136
137			public function dispatch($item, $isBackground = false){
138			switch($this->getNumericStatus()) {
139			case self::SCANRESULT_UNCHECKED:
140			$item->processUnchecked($this, $isBackground);
141			break;
142			case self::SCANRESULT_INFECTED:
143			$item->processInfected($this, $isBackground);
144			break;
145			case self::SCANRESULT_CLEAN:
146			$item->processClean($this, $isBackground);
147			break;
148			}
149			}
150			}
151

owncloud / files_antivirus

Push — antivirus-update ( fcda38...b6d85d )

Status::parseResponse() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like