AvirWrapper::fopen() - Code Metrics - Inspection of "Fix query, catch and log fs exception" - owncloud/files_antivirus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — antivirus-update ( fcda38...b6d85d )

by Victor

created 2016-06-09 17:22 UTC

AvirWrapper::fopen() B

↳ Parent: AvirWrapper

Complexity

Conditions	7
Paths	5

Size

Total Lines	56
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	7
Bugs	2	Features	0

Metric	Value
cc	7
eloc	38
c	7
b	2
f	0
nc	5
nop	2
dl	0
loc	56
rs	7.7489

How to fix Long Method

<?php
/**
 * Copyright (c) 2014 Victor Dubiniuk <[email protected]>
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */

namespace OCA\Files_Antivirus;

use OC\Files\Storage\Wrapper\Wrapper;
use \OCP\App;
use \OCP\IConfig;
use \OCP\IL10N;
use \OCP\ILogger;
use \OCP\Files\InvalidContentException;
use Icewind\Streams\CallbackWrapper;


class AvirWrapper extends Wrapper{
	
	/**
	 * Modes that are used for writing 
	 * @var array 
	 */
	private $writingModes = array('r+', 'w', 'w+', 'a', 'a+', 'x', 'x+', 'c', 'c+');
	
	/**
	 * @var \OCA\Files_Antivirus\ScannerFactory
	 */
	protected $scannerFactory;
	
	/**
	 * @var IL10N 
	 */
	protected $l10n;
	
	/**
	 * @var ILogger;
	 */
	protected $logger;

	/**
	 * @param array $parameters
	 */
	public function __construct($parameters) {
		parent::__construct($parameters);
		$this->scannerFactory = $parameters['scannerFactory'];
		$this->l10n = $parameters['l10n'];
		$this->logger = $parameters['logger'];
	}
	
	/**
	 * Asynchronously scan data that are written to the file
	 * @param string $path
	 * @param string $mode
	 * @return resource | bool
	 */
	public function fopen($path, $mode){
		$stream = $this->storage->fopen($path, $mode);
		if (is_resource($stream) && $this->isWritingMode($mode)) {
			try {
				$scanner = $this->scannerFactory->getScanner();
				$scanner->initAsyncScan();
				return CallBackWrapper::wrap(
					$stream,
					null,
					function ($data) use ($scanner){
						$scanner->onAsyncData($data);
					}, 
					function () use ($scanner, $path) {
						$status = $scanner->completeAsyncScan();
						if (intval($status->getNumericStatus()) === \OCA\Files_Antivirus\Status::SCANRESULT_INFECTED){
							//prevent from going to trashbin
							if (App::isEnabled('files_trashbin')) {
								\OCA\Files_Trashbin\Storage::preRenameHook([]);
							}
							
							$owner = $this->getOwner($path);
							$this->unlink($path);

							if (App::isEnabled('files_trashbin')) {
								\OCA\Files_Trashbin\Storage::postRenameHook([]);
							}
							
							\OC::$server->getActivityManager()->publishActivity(
								'files_antivirus',
								Activity::SUBJECT_VIRUS_DETECTED,
								[$path, $status->getDetails()],
								Activity::MESSAGE_FILE_DELETED,
								[],
								$path,
								'',
								$owner,
								Activity::TYPE_VIRUS_DETECTED,
								Activity::PRIORITY_HIGH
							);
											
							throw new InvalidContentException(
								$this->l10n->t(
									'Virus %s is detected in the file. Upload cannot be completed.',
									$status->getDetails()
								)
							);
						}
					}
				);
			} catch (\Exception $e){
				$message = 	implode(' ', [ __CLASS__, __METHOD__, $e->getMessage()]);
				$this->logger->warning($message);
			}
		}
		return $stream;
	}
	
	/**
	 * Checks whether passed mode is suitable for writing 
	 * @param string $mode
	 * @return bool
	 */
	private function isWritingMode($mode){
		// Strip unessential binary/text flags
		$cleanMode = str_replace(
			['t', 'b'],
			['', ''],
			$mode
		);
		return in_array($cleanMode, $this->writingModes);
	}
}


1			<?php
2			/**
3			* Copyright (c) 2014 Victor Dubiniuk <[email protected]>
4			* This file is licensed under the Affero General Public License version 3 or
5			* later.
6			* See the COPYING-README file.
7			*/
8
9			namespace OCA\Files_Antivirus;
10
11			use OC\Files\Storage\Wrapper\Wrapper;
12			use \OCP\App;
13			use \OCP\IConfig;
14			use \OCP\IL10N;
15			use \OCP\ILogger;
16			use \OCP\Files\InvalidContentException;
17			use Icewind\Streams\CallbackWrapper;
18
19
20			class AvirWrapper extends Wrapper{
21
22			/**
23			* Modes that are used for writing
24			* @var array
25			*/
26			private $writingModes = array('r+', 'w', 'w+', 'a', 'a+', 'x', 'x+', 'c', 'c+');
27
28			/**
29			* @var \OCA\Files_Antivirus\ScannerFactory
30			*/
31			protected $scannerFactory;
32
33			/**
34			* @var IL10N
35			*/
36			protected $l10n;
37
38			/**
39			* @var ILogger;
40			*/
41			protected $logger;
42
43			/**
44			* @param array $parameters
45			*/
46			public function __construct($parameters) {
47			parent::__construct($parameters);
48			$this->scannerFactory = $parameters['scannerFactory'];
49			$this->l10n = $parameters['l10n'];
50			$this->logger = $parameters['logger'];
51			}
52
53			/**
54			* Asynchronously scan data that are written to the file
55			* @param string $path
56			* @param string $mode
57			* @return resource \| bool
58			*/
59			public function fopen($path, $mode){
60			$stream = $this->storage->fopen($path, $mode);
61			if (is_resource($stream) && $this->isWritingMode($mode)) {
62			try {
63			$scanner = $this->scannerFactory->getScanner();
64			$scanner->initAsyncScan();
65			return CallBackWrapper::wrap(
66			$stream,
67			null,
68			function ($data) use ($scanner){
69			$scanner->onAsyncData($data);
70			},
71			function () use ($scanner, $path) {
72			$status = $scanner->completeAsyncScan();
73			if (intval($status->getNumericStatus()) === \OCA\Files_Antivirus\Status::SCANRESULT_INFECTED){
74			//prevent from going to trashbin
75			if (App::isEnabled('files_trashbin')) {
76			\OCA\Files_Trashbin\Storage::preRenameHook([]);
77			}
78
79			$owner = $this->getOwner($path);
80			$this->unlink($path);
81
82			if (App::isEnabled('files_trashbin')) {
83			\OCA\Files_Trashbin\Storage::postRenameHook([]);
84			}
85
86			\OC::$server->getActivityManager()->publishActivity(
87			'files_antivirus',
88			Activity::SUBJECT_VIRUS_DETECTED,
89			[$path, $status->getDetails()],
90			Activity::MESSAGE_FILE_DELETED,
91			[],
92			$path,
93			'',
94			$owner,
95			Activity::TYPE_VIRUS_DETECTED,
96			Activity::PRIORITY_HIGH
97			);
98
99			throw new InvalidContentException(
100			$this->l10n->t(
101			'Virus %s is detected in the file. Upload cannot be completed.',
102			$status->getDetails()
103			)
104			);
105			}
106			}
107			);
108			} catch (\Exception $e){
109			$message = implode(' ', [ __CLASS__, __METHOD__, $e->getMessage()]);
110			$this->logger->warning($message);
111			}
112			}
113			return $stream;
114			}
115
116			/**
117			* Checks whether passed mode is suitable for writing
118			* @param string $mode
119			* @return bool
120			*/
121			private function isWritingMode($mode){
122			// Strip unessential binary/text flags
123			$cleanMode = str_replace(
124			['t', 'b'],
125			['', ''],
126			$mode
127			);
128			return in_array($cleanMode, $this->writingModes);
129			}
130			}
131

owncloud / files_antivirus

Push — antivirus-update ( fcda38...b6d85d )

AvirWrapper::fopen() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like