OCA\Files_Antivirus\Scanner\Local

Complexity

Total Complexity

5

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

91.43%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	15	2
A	initScanner()	0	18	2
A	shutdownScanner()	0	12	1

<?php
/**
 * ownCloud - Files_antivirus
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Viktar Dubiniuk <dubiniuk@owncloud.com>
 *
 * @copyright Viktar Dubiniuk 2014-2018
 * @license AGPL-3.0
 */

namespace OCA\Files_Antivirus\Scanner;

use OCA\Files_Antivirus\AppConfig;
use OCP\ILogger;

class Local extends AbstractScanner {
	
	/**
	 * @var string
	 */
	protected $avPath;
	
	/**
	 * STDIN and STDOUT descriptors
	 *
	 * @var array of resources
	 */
	private $pipes = [];
	
	/**
	 * Process handle
	 *
	 * @var resource
	 */
	private $process;

	/**
	 * Local constructor.
	 *
	 * @param AppConfig $config
	 * @param ILogger $logger
	 *
	 * @throws InitException
	 */
	public function __construct(AppConfig $config, ILogger $logger) {
		parent::__construct($config, $logger);

		// get the path to the executable
		$this->avPath = \escapeshellcmd($this->appConfig->getAvPath());

		if (!\file_exists($this->avPath)) {
			throw new InitException(
				\sprintf(
					'The antivirus executable could not be found at path "%s"',
					$this->avPath
				)
			);
		}
	}
	
	public function initScanner() {
		parent::initScanner();
		
		// using 2>&1 to grab the full command-line output.
		$cmd = $this->avPath . " " . $this->appConfig->getCmdline() . " - 2>&1";
		$descriptorSpec = [
			0 => ["pipe","r"], // STDIN
			1 => ["pipe","w"]  // STDOUT
		];
		
		$this->process = \proc_open($cmd, $descriptorSpec, $this->pipes);
		if (!\is_resource($this->process)) {
			throw new InitException(
				\sprintf('Error starting process "%s"', $cmd)
			);
		}
		$this->writeHandle = $this->pipes[0];
	}
	
	protected function shutdownScanner() {
		@\fclose($this->pipes[0]);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

		$output = \stream_get_contents($this->pipes[1]);
		@\fclose($this->pipes[1]);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

		
		$result = \proc_close($this->process);
		$this->logger->debug(
			'Exit code :: ' . $result . ' Response :: ' . $output,
			['app' => 'files_antivirus']
		);
		$this->status->parseResponse($output, $result);
	}
}