External::getWriteHandle() - Code Metrics - Inspection of "Add AVMaxFileSize config option" - owncloud/files_antivirus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#133)

by Victor

created 2016-11-13 18:30 UTC

External::getWriteHandle() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	3
ccs	0
cts	3
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php
/**
 * Copyright (c) 2014 Victor Dubiniuk <[email protected]>
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */


namespace OCA\Files_Antivirus\Scanner;

class External extends \OCA\Files_Antivirus\Scanner {
	
	// Daemon/socket mode
	private $useSocket;
	
	public function __construct($config){
		$this->appConfig = $config;
		$this->useSocket = $this->appConfig->getAvMode() === 'socket';
	}
	
	public function initScanner(){
		parent::initScanner();
		
		if ($this->useSocket){
			$avSocket = $this->appConfig->getAvSocket();
			$this->writeHandle = stream_socket_client('unix://' . $avSocket, $errno, $errstr, 5);
			if (!$this->getWriteHandle()) {
				throw new \RuntimeException('Cannot connect to "' . $avSocket . '": ' . $errstr . ' (code ' . $errno . ')');
			}
		} else {
			$avHost = $this->appConfig->getAvHost();
			$avPort = $this->appConfig->getAvPort();
			$this->writeHandle = ($avHost && $avPort) ? @fsockopen($avHost, $avPort) : false;
			if (!$this->getWriteHandle()) {
				throw new \RuntimeException('The clamav module is not configured for daemon mode.');
			}
		}

		// request scan from the daemon
		@fwrite($this->getWriteHandle(), "nINSTREAM\n");
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
	}
	
	protected function shutdownScanner(){
		@fwrite($this->getWriteHandle(), pack('N', 0));
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		$response = fgets($this->getWriteHandle());
		\OC::$server->getLogger()->debug(
			'Response :: ' . $response,
			['app' => 'files_antivirus']
		);
		@fclose($this->getWriteHandle());
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		
		$this->status->parseResponse($response);
	}
	
	protected function prepareChunk($data){
		$chunkLength = pack('N', strlen($data));
		return $chunkLength . $data;
	}
}


1		<?php
2		/**
3		* Copyright (c) 2014 Victor Dubiniuk <[email protected]>
4		* This file is licensed under the Affero General Public License version 3 or
5		* later.
6		* See the COPYING-README file.
7		*/
8
9
10		namespace OCA\Files_Antivirus\Scanner;
11
12		class External extends \OCA\Files_Antivirus\Scanner {
13
14		// Daemon/socket mode
15		private $useSocket;
16
17	2	public function __construct($config){
18	2	$this->appConfig = $config;
19	2	$this->useSocket = $this->appConfig->getAvMode() === 'socket';
20	2	}
21
22	2	public function initScanner(){
23	2	parent::initScanner();
24
25	2	if ($this->useSocket){
26		$avSocket = $this->appConfig->getAvSocket();
27		$this->writeHandle = stream_socket_client('unix://' . $avSocket, $errno, $errstr, 5);
28		if (!$this->getWriteHandle()) {
29		throw new \RuntimeException('Cannot connect to "' . $avSocket . '": ' . $errstr . ' (code ' . $errno . ')');
30		}
31		} else {
32	2	$avHost = $this->appConfig->getAvHost();
33	2	$avPort = $this->appConfig->getAvPort();
34	2	$this->writeHandle = ($avHost && $avPort) ? @fsockopen($avHost, $avPort) : false;
35	2	if (!$this->getWriteHandle()) {
36	1	throw new \RuntimeException('The clamav module is not configured for daemon mode.');
37		}
38		}
39
40		// request scan from the daemon
41	1	@fwrite($this->getWriteHandle(), "nINSTREAM\n");
		0 ignored issues – show Security Best Practice introduced 2016-11-03 19:50 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
42	1	}
43
44	1	protected function shutdownScanner(){
45	1	@fwrite($this->getWriteHandle(), pack('N', 0));
		0 ignored issues – show Security Best Practice introduced 2016-11-03 18:42 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
46	1	$response = fgets($this->getWriteHandle());
47	1	\OC::$server->getLogger()->debug(
48	1	'Response :: ' . $response,
49	1	['app' => 'files_antivirus']
50		);
51	1	@fclose($this->getWriteHandle());
		0 ignored issues – show Security Best Practice introduced 2016-11-03 16:16 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
52
53	1	$this->status->parseResponse($response);
54	1	}
55
56	1	protected function prepareChunk($data){
57	1	$chunkLength = pack('N', strlen($data));
58	1	return $chunkLength . $data;
59		}
60		}
61

owncloud / files_antivirus

Pull Request — master (#133)

External::getWriteHandle() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like