AvirWrapper::fopen() - Code Metrics - Inspection of "Skip chunks - they will be scanned on the final mo..." - owncloud/files_antivirus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — stable10-dont-scan-chunks ( 7fff21 )

by Victor

created 2017-08-29 19:51 UTC

AvirWrapper::fopen() C

↳ Parent: AvirWrapper

Complexity

Conditions	8
Paths	5

Size

Total Lines	67
Code Lines	46

Duplication

Lines	0
Ratio	0 %

Importance

Changes	5
Bugs	0	Features	0

Metric	Value
c	5
b	0
f	0
dl	0
loc	67
rs	6.6523
cc	8
eloc	46
nc	5
nop	2

How to fix Long Method

<?php
/**
 * Copyright (c) 2014 Victor Dubiniuk <[email protected]>
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */

namespace OCA\Files_Antivirus;

use OC\Files\Filesystem;
use OC\Files\Storage\Wrapper\Wrapper;
use \OCP\App;
use \OCP\IConfig;
use \OCP\IL10N;
use \OCP\ILogger;
use \OCP\Files\InvalidContentException;
use Icewind\Streams\CallbackWrapper;


class AvirWrapper extends Wrapper{
	
	/**
	 * Modes that are used for writing 
	 * @var array 
	 */
	private $writingModes = array('r+', 'w', 'w+', 'a', 'a+', 'x', 'x+', 'c', 'c+');
	
	/**
	 * @var \OCA\Files_Antivirus\ScannerFactory
	 */
	protected $scannerFactory;
	
	/**
	 * @var IL10N 
	 */
	protected $l10n;
	
	/**
	 * @var ILogger;
	 */
	protected $logger;

	/**
	 * @param array $parameters
	 */
	public function __construct($parameters) {
		parent::__construct($parameters);
		$this->scannerFactory = $parameters['scannerFactory'];
		$this->l10n = $parameters['l10n'];
		$this->logger = $parameters['logger'];
	}
	
	/**
	 * Asynchronously scan data that are written to the file
	 * @param string $path
	 * @param string $mode
	 * @return resource | bool
	 */
	public function fopen($path, $mode){
		$stream = $this->storage->fopen($path, $mode);
		if (is_resource($stream)
			&& $this->isWritingMode($mode)
			&& strpos($path, 'uploads/') !== 0
		) {
			try {
				$scanner = $this->scannerFactory->getScanner();
				$scanner->initScanner();
				return CallBackWrapper::wrap(
					$stream,
					null,
					function ($data) use ($scanner){
						$scanner->onAsyncData($data);
					}, 
					function () use ($scanner, $path) {
						$status = $scanner->completeAsyncScan();
						if (intval($status->getNumericStatus()) === \OCA\Files_Antivirus\Status::SCANRESULT_INFECTED){
							//prevent from going to trashbin
							if (App::isEnabled('files_trashbin')) {
								\OCA\Files_Trashbin\Storage::preRenameHook([
									Filesystem::signal_param_oldpath => '',
									Filesystem::signal_param_newpath => ''
								]);
							}
							
							$owner = $this->getOwner($path);
							$this->unlink($path);

							if (App::isEnabled('files_trashbin')) {
								\OCA\Files_Trashbin\Storage::postRenameHook([]);
							}
							$this->logger->warning(
								'Infected file deleted. ' . $status->getDetails()
								. ' Account: ' . $owner . ' Path: ' . $path,
								['app' => 'files_antivirus']
							);

							\OC::$server->getActivityManager()->publishActivity(
								'files_antivirus',
								Activity::SUBJECT_VIRUS_DETECTED,
								[$path, $status->getDetails()],
								Activity::MESSAGE_FILE_DELETED,
								[],
								$path,
								'',
								$owner,
								Activity::TYPE_VIRUS_DETECTED,
								Activity::PRIORITY_HIGH
							);
											
							throw new InvalidContentException(
								$this->l10n->t(
									'Virus %s is detected in the file. Upload cannot be completed.',
									$status->getDetails()
								)
							);
						}
					}
				);
			} catch (\Exception $e){
				$message = 	implode(' ', [ __CLASS__, __METHOD__, $e->getMessage()]);
				$this->logger->warning($message);
			}
		}
		return $stream;
	}
	
	/**
	 * Checks whether passed mode is suitable for writing 
	 * @param string $mode
	 * @return bool
	 */
	private function isWritingMode($mode){
		// Strip unessential binary/text flags
		$cleanMode = str_replace(
			['t', 'b'],
			['', ''],
			$mode
		);
		return in_array($cleanMode, $this->writingModes);
	}
}


1			<?php
2			/**
3			* Copyright (c) 2014 Victor Dubiniuk <[email protected]>
4			* This file is licensed under the Affero General Public License version 3 or
5			* later.
6			* See the COPYING-README file.
7			*/
8
9			namespace OCA\Files_Antivirus;
10
11			use OC\Files\Filesystem;
12			use OC\Files\Storage\Wrapper\Wrapper;
13			use \OCP\App;
14			use \OCP\IConfig;
15			use \OCP\IL10N;
16			use \OCP\ILogger;
17			use \OCP\Files\InvalidContentException;
18			use Icewind\Streams\CallbackWrapper;
19
20
21			class AvirWrapper extends Wrapper{
22
23			/**
24			* Modes that are used for writing
25			* @var array
26			*/
27			private $writingModes = array('r+', 'w', 'w+', 'a', 'a+', 'x', 'x+', 'c', 'c+');
28
29			/**
30			* @var \OCA\Files_Antivirus\ScannerFactory
31			*/
32			protected $scannerFactory;
33
34			/**
35			* @var IL10N
36			*/
37			protected $l10n;
38
39			/**
40			* @var ILogger;
41			*/
42			protected $logger;
43
44			/**
45			* @param array $parameters
46			*/
47			public function __construct($parameters) {
48			parent::__construct($parameters);
49			$this->scannerFactory = $parameters['scannerFactory'];
50			$this->l10n = $parameters['l10n'];
51			$this->logger = $parameters['logger'];
52			}
53
54			/**
55			* Asynchronously scan data that are written to the file
56			* @param string $path
57			* @param string $mode
58			* @return resource \| bool
59			*/
60			public function fopen($path, $mode){
61			$stream = $this->storage->fopen($path, $mode);
62			if (is_resource($stream)
63			&& $this->isWritingMode($mode)
64			&& strpos($path, 'uploads/') !== 0
65			) {
66			try {
67			$scanner = $this->scannerFactory->getScanner();
68			$scanner->initScanner();
69			return CallBackWrapper::wrap(
70			$stream,
71			null,
72			function ($data) use ($scanner){
73			$scanner->onAsyncData($data);
74			},
75			function () use ($scanner, $path) {
76			$status = $scanner->completeAsyncScan();
77			if (intval($status->getNumericStatus()) === \OCA\Files_Antivirus\Status::SCANRESULT_INFECTED){
78			//prevent from going to trashbin
79			if (App::isEnabled('files_trashbin')) {
80			\OCA\Files_Trashbin\Storage::preRenameHook([
81			Filesystem::signal_param_oldpath => '',
82			Filesystem::signal_param_newpath => ''
83			]);
84			}
85
86			$owner = $this->getOwner($path);
87			$this->unlink($path);
88
89			if (App::isEnabled('files_trashbin')) {
90			\OCA\Files_Trashbin\Storage::postRenameHook([]);
91			}
92			$this->logger->warning(
93			'Infected file deleted. ' . $status->getDetails()
94			. ' Account: ' . $owner . ' Path: ' . $path,
95			['app' => 'files_antivirus']
96			);
97
98			\OC::$server->getActivityManager()->publishActivity(
99			'files_antivirus',
100			Activity::SUBJECT_VIRUS_DETECTED,
101			[$path, $status->getDetails()],
102			Activity::MESSAGE_FILE_DELETED,
103			[],
104			$path,
105			'',
106			$owner,
107			Activity::TYPE_VIRUS_DETECTED,
108			Activity::PRIORITY_HIGH
109			);
110
111			throw new InvalidContentException(
112			$this->l10n->t(
113			'Virus %s is detected in the file. Upload cannot be completed.',
114			$status->getDetails()
115			)
116			);
117			}
118			}
119			);
120			} catch (\Exception $e){
121			$message = implode(' ', [ __CLASS__, __METHOD__, $e->getMessage()]);
122			$this->logger->warning($message);
123			}
124			}
125			return $stream;
126			}
127
128			/**
129			* Checks whether passed mode is suitable for writing
130			* @param string $mode
131			* @return bool
132			*/
133			private function isWritingMode($mode){
134			// Strip unessential binary/text flags
135			$cleanMode = str_replace(
136			['t', 'b'],
137			['', ''],
138			$mode
139			);
140			return in_array($cleanMode, $this->writingModes);
141			}
142			}
143

owncloud / files_antivirus

Push — stable10-dont-scan-chunks ( 7fff21 )

AvirWrapper::fopen() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like