OCA\Files_Antivirus\Scanner\External

Complexity

Total Complexity

2

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	shutdownScanner()	0	11	1
A	prepareChunk()	0	4	1

<?php
/**
 * ownCloud - Files_antivirus
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Viktar Dubiniuk <dubiniuk@owncloud.com>
 *
 * @copyright Viktar Dubiniuk 2017-2018
 * @license AGPL-3.0
 */

namespace OCA\Files_Antivirus\Scanner;

/**
 * Class External
 *
 * @package OCA\Files_Antivirus\Scanner
 */
abstract class External extends AbstractScanner {
	/**
	 * Send an empty chunk to indicate the end of stream,
	 * read response and close the handle
	 */
	protected function shutdownScanner() {
		@\fwrite($this->getWriteHandle(), \pack('N', 0));

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

		$response = \fgets($this->getWriteHandle());
		$this->logger->debug(
			'Response :: ' . $response,
			['app' => 'files_antivirus']
		);
		@\fclose($this->getWriteHandle());

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

		$this->status->parseResponse($response);
	}

	/**
	 * Prepend a chunk sent to ClamAv with its length
	 *
	 * @param string $data
	 *
	 * @return string
	 */
	protected function prepareChunk($data) {
		$chunkLength = \pack('N', \strlen($data));
		return $chunkLength . $data;
	}
}