DownloadResponse::render() - Code Metrics - Inspection of "[tx-robot] updated from transifex" - owncloud/documents - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — stable9.1 ( c0a5f4 )

unknown

created 2016-06-30 09:57 UTC

DownloadResponse::render() C

↳ Parent: DownloadResponse

Complexity

Conditions	11
Paths	16

Size

Total Lines	58
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	58
rs	6.4179
c	0
b	0
f	0
cc	11
eloc	39
nc	16
nop	0

How to fix Long Method Complexity

<?php
/**
 * ownCloud - Documents App
 *
 * @author Victor Dubiniuk
 * @copyright 2014 Victor Dubiniuk [email protected]
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 */

namespace OCA\Documents;

use OC\Files\Filesystem;
use \OCP\AppFramework\Http;
use \OCP\IRequest;
use \OC\Files\View;

class DownloadResponse extends \OCP\AppFramework\Http\Response {
	private $request;
	private $view;
	private $path;
	
	/**
	 * @param IRequest $request
	 * @param string $user
	 * @param string $path
	 */
	public function __construct(IRequest $request, $user, $path) {
		$this->request = $request;
		$this->user = $user;
		$this->path = $path;

		Filesystem::initMountPoints($user);
		$this->view = new View('/' . $user);
		if (!$this->view->file_exists($path)){
			$this->setStatus(Http::STATUS_NOT_FOUND);
		}
	}
	
	public function render(){
		if ($this->getStatus() === Http::STATUS_NOT_FOUND){
			return '';
		}
		$info = $this->view->getFileInfo($this->path);
		$this->ETag = $info['etag'];
		
		$content = $this->view->file_get_contents($this->path);
		$data = \OCA\Documents\Filter::read($content, $info['mimetype']);
		$size = strlen($data['content']);
		
		
		if (isset($this->request->server['HTTP_RANGE']) && !is_null($this->request->server['HTTP_RANGE'])){
			$isValidRange = preg_match('/^bytes=\d*-\d*(,\d*-\d*)*$/', $this->request->server['HTTP_RANGE']);
			if (!$isValidRange){
				return $this->sendRangeNotSatisfiable($size);
			}
			
			$ranges = explode(',', substr($this->request->server['HTTP_RANGE'], 6));
			foreach ($ranges as $range){
				$parts = explode('-', $range);

				if ($parts[0]==='' && $parts[1]=='') {
					$this->sendNotSatisfiable($size);
				}
				if ($parts[0]==='') {
					$start = $size - $parts[1];
					$end = $size - 1;
				} else {
					$start = $parts[0];
					$end = ($parts[1]==='') ? $size - 1 : $parts[1];
				}

				if ($start > $end){
					$this->sendNotSatisfiable($size);
				}

				$buffer = substr($data['content'], $start,  $end - $start);
				$md5Sum = md5($buffer);

				// send the headers and data 
				$this->addHeader('Content-Length',  $end - $start);
				$this->addHeader('Content-md5', $md5Sum);
				$this->addHeader('Accept-Ranges', 'bytes');
				$this->addHeader('Content-Range', 'bytes ' . $start . '-' . ($end) . '/' . $size);
				$this->addHeader('Connection', 'close');
				$this->addHeader('Content-Type', $data['mimetype']);
				$this->addContentDispositionHeader();
				return $buffer;
			}
		}
		
		$this->addHeader('Content-Type', $data['mimetype']);
		$this->addContentDispositionHeader();
		$this->addHeader('Content-Length',  $size);

		return $data['content'];
	}
	
	/**
	 * Send 416 if we can't satisfy the requested ranges
	 * @param integer $filesize
	 */
	protected function sendRangeNotSatisfiable($filesize){
		$this->setStatus(Http::STATUS_REQUEST_RANGE_NOT_SATISFIABLE);
		$this->addHeader('Content-Range', 'bytes */' . $filesize); // Required in 416.
		return '';
	}
	
	protected function addContentDispositionHeader(){
		$encodedName = rawurlencode(basename($this->path));
		$isIE = preg_match("/MSIE/", $this->request->server["HTTP_USER_AGENT"]);
		if ($isIE){
			$this->addHeader(
					'Content-Disposition',
					'attachment; filename="' . $encodedName . '"'
			);
		} else {
			$this->addHeader(
					'Content-Disposition',
					'attachment; filename*=UTF-8\'\'' . $encodedName . '; filepath="' . $encodedName . '"'
			);
		}
	}
}


1			<?php
2			/**
3			* ownCloud - Documents App
4			*
5			* @author Victor Dubiniuk
6			* @copyright 2014 Victor Dubiniuk [email protected]
7			*
8			* This file is licensed under the Affero General Public License version 3 or
9			* later.
10			*/
11
12			namespace OCA\Documents;
13
14			use OC\Files\Filesystem;
15			use \OCP\AppFramework\Http;
16			use \OCP\IRequest;
17			use \OC\Files\View;
18
19			class DownloadResponse extends \OCP\AppFramework\Http\Response {
20			private $request;
21			private $view;
22			private $path;
23
24			/**
25			* @param IRequest $request
26			* @param string $user
27			* @param string $path
28			*/
29			public function __construct(IRequest $request, $user, $path) {
30			$this->request = $request;
31			$this->user = $user;
32			$this->path = $path;
33
34			Filesystem::initMountPoints($user);
35			$this->view = new View('/' . $user);
36			if (!$this->view->file_exists($path)){
37			$this->setStatus(Http::STATUS_NOT_FOUND);
38			}
39			}
40
41			public function render(){
42			if ($this->getStatus() === Http::STATUS_NOT_FOUND){
43			return '';
44			}
45			$info = $this->view->getFileInfo($this->path);
46			$this->ETag = $info['etag'];
47
48			$content = $this->view->file_get_contents($this->path);
49			$data = \OCA\Documents\Filter::read($content, $info['mimetype']);
50			$size = strlen($data['content']);
51
52
53			if (isset($this->request->server['HTTP_RANGE']) && !is_null($this->request->server['HTTP_RANGE'])){
54			$isValidRange = preg_match('/^bytes=\d-\d(,\d-\d)*$/', $this->request->server['HTTP_RANGE']);
55			if (!$isValidRange){
56			return $this->sendRangeNotSatisfiable($size);
57			}
58
59			$ranges = explode(',', substr($this->request->server['HTTP_RANGE'], 6));
60			foreach ($ranges as $range){
61			$parts = explode('-', $range);
62
63			if ($parts[0]==='' && $parts[1]=='') {
64			$this->sendNotSatisfiable($size);
65			}
66			if ($parts[0]==='') {
67			$start = $size - $parts[1];
68			$end = $size - 1;
69			} else {
70			$start = $parts[0];
71			$end = ($parts[1]==='') ? $size - 1 : $parts[1];
72			}
73
74			if ($start > $end){
75			$this->sendNotSatisfiable($size);
76			}
77
78			$buffer = substr($data['content'], $start, $end - $start);
79			$md5Sum = md5($buffer);
80
81			// send the headers and data
82			$this->addHeader('Content-Length', $end - $start);
83			$this->addHeader('Content-md5', $md5Sum);
84			$this->addHeader('Accept-Ranges', 'bytes');
85			$this->addHeader('Content-Range', 'bytes ' . $start . '-' . ($end) . '/' . $size);
86			$this->addHeader('Connection', 'close');
87			$this->addHeader('Content-Type', $data['mimetype']);
88			$this->addContentDispositionHeader();
89			return $buffer;
90			}
91			}
92
93			$this->addHeader('Content-Type', $data['mimetype']);
94			$this->addContentDispositionHeader();
95			$this->addHeader('Content-Length', $size);
96
97			return $data['content'];
98			}
99
100			/**
101			* Send 416 if we can't satisfy the requested ranges
102			* @param integer $filesize
103			*/
104			protected function sendRangeNotSatisfiable($filesize){
105			$this->setStatus(Http::STATUS_REQUEST_RANGE_NOT_SATISFIABLE);
106			$this->addHeader('Content-Range', 'bytes */' . $filesize); // Required in 416.
107			return '';
108			}
109
110			protected function addContentDispositionHeader(){
111			$encodedName = rawurlencode(basename($this->path));
112			$isIE = preg_match("/MSIE/", $this->request->server["HTTP_USER_AGENT"]);
113			if ($isIE){
114			$this->addHeader(
115			'Content-Disposition',
116			'attachment; filename="' . $encodedName . '"'
117			);
118			} else {
119			$this->addHeader(
120			'Content-Disposition',
121			'attachment; filename*=UTF-8\'\'' . $encodedName . '; filepath="' . $encodedName . '"'
122			);
123			}
124			}
125			}
126

owncloud / documents

Push — stable9.1 ( c0a5f4 )

DownloadResponse::render() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like