Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
15 | class Filter { |
||
16 | protected static $filters = array(); |
||
17 | |||
18 | public static function add($mimetype, $class){ |
||
21 | |||
22 | View Code Duplication | public static function read($content, $mimetype){ |
|
40 | |||
41 | View Code Duplication | public static function write($content, $mimetype){ |
|
59 | |||
60 | public static function getAll(){ |
||
63 | |||
64 | /** |
||
65 | * Checks if mimetype is supported by the app |
||
66 | * @param string $mimetype - checked mimetype |
||
67 | * @return bool |
||
68 | */ |
||
69 | public static function isSupportedMimetype($mimetype){ |
||
72 | } |
||
73 | |||
74 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.