Completed
Pull Request — master (#29838)
by Sergio
14:39
created
apps/federation/lib/Controller/OCSAuthAPIController.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -164,6 +164,10 @@
 block discarded – undo
164 164
 			'data' => ['sharedSecret' => $sharedSecret]];
165 165
 	}
166 166
 
167
+	/**
168
+	 * @param string $url
169
+	 * @param string $token
170
+	 */
167 171
 	protected function isValidToken($url, $token) {
168 172
 		$storedToken = $this->dbHandler->getToken($url);
169 173
 		return hash_equals($storedToken, $token);
Please login to merge, or discard this patch.
lib/private/AvatarManager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -99,6 +99,9 @@
 block discarded – undo
99 99
 		}
100 100
 	}
101 101
 
102
+	/**
103
+	 * @param string $userId
104
+	 */
102 105
 	private function buildAvatarPath($userId) {
103 106
 		$avatar = substr_replace(substr_replace(md5($userId), '/', 4, 0), '/', 2, 0);
104 107
 		return explode('/', $avatar);
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/ImageExportPlugin.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -136,6 +136,9 @@
 block discarded – undo
136 136
 		return false;
137 137
 	}
138 138
 
139
+	/**
140
+	 * @param string $cardData
141
+	 */
139 142
 	private function readCard($cardData) {
140 143
 		return Reader::read($cardData);
141 144
 	}
Please login to merge, or discard this patch.
apps/dav/lib/Files/Xml/FilterRequest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
 	 * the next element.
46 46
 	 *
47 47
 	 * @param Reader $reader
48
-	 * @return mixed
48
+	 * @return FilterRequest
49 49
 	 */
50 50
 	static function xmlDeserialize(Reader $reader) {
51 51
 		$elems = (array)$reader->parseInnerTree([
Please login to merge, or discard this patch.
lib/private/L10N/Factory.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -278,6 +278,11 @@
 block discarded – undo
278 278
 	 */
279 279
 	// FIXME This method is only public, until \OCP\IL10N does not need it anymore,
280 280
 	// FIXME This is also the reason, why it is not in the public interface
281
+
282
+	/**
283
+	 * @param string $app
284
+	 * @param string $lang
285
+	 */
281 286
 	public function getL10nFilesForApp($app, $lang) {
282 287
 		$languageFiles = [];
283 288
 
Please login to merge, or discard this patch.
apps/files_sharing/lib/SharedMount.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 	 *
111 111
 	 * @param string $newPath
112 112
 	 * @param \OCP\Share\IShare $share
113
-	 * @return bool
113
+	 * @return boolean|null
114 114
 	 */
115 115
 	private function updateFileTarget($newPath, &$share) {
116 116
 		$share->setTarget($newPath);
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 	 * @param string $path
127 127
 	 * @param View $view
128 128
 	 * @param SharedMount[] $mountpoints
129
-	 * @return mixed
129
+	 * @return string
130 130
 	 */
131 131
 	private function generateUniqueTarget($path, $view, array $mountpoints) {
132 132
 		$pathinfo = pathinfo($path);
Please login to merge, or discard this patch.
lib/private/Files/Node/File.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
 	 * Creates a Folder that represents a non-existing path
33 33
 	 *
34 34
 	 * @param string $path path
35
-	 * @return string non-existing node class
35
+	 * @return NonExistingFile non-existing node class
36 36
 	 */
37 37
 	protected function createNonExistingNode($path) {
38 38
 		return new NonExistingFile($this->root, $this->view, $path);
Please login to merge, or discard this patch.
lib/private/Files/Node/Folder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
 	 * Creates a Folder that represents a non-existing path
35 35
 	 *
36 36
 	 * @param string $path path
37
-	 * @return string non-existing node class
37
+	 * @return NonExistingFolder non-existing node class
38 38
 	 */
39 39
 	protected function createNonExistingNode($path) {
40 40
 		return new NonExistingFolder($this->root, $this->view, $path);
Please login to merge, or discard this patch.
apps/comments/lib/Dav/EntityCollection.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
 	/**
107 107
 	 * Returns an array with all the child nodes
108 108
 	 *
109
-	 * @return \Sabre\DAV\INode[]
109
+	 * @return CommentNode[]
110 110
 	 */
111 111
 	function getChildren() {
112 112
 		return $this->findChildren();
Please login to merge, or discard this patch.