owncloud / core

lib/private/User/Manager.php

Doc Comments +3 added lines

@@ -432,6 +432,9 @@
 		}, $accounts);
 	}
 
+	/**
+	 * @param string $backendClass
+	 */
 	public function getBackend($backendClass) {
 		if (isset($this->backends[$backendClass])) {
 			return $this->backends[$backendClass];

Unused Use Statements -3 removed lines

@@ -39,9 +39,6 @@
 use OCP\IUser;
 use OCP\IUserManager;
 use OCP\IConfig;
-use OCP\User\IProvidesExtendedSearchBackend;
-use OCP\User\IProvidesEMailBackend;
-use OCP\User\IProvidesQuotaBackend;
 use OCP\UserInterface;
 use Symfony\Component\EventDispatcher\GenericEvent;
 

lib/private/User/User.php

Doc Comments +5 added lines, -1 removed lines

@@ -78,7 +78,7 @@ 
 	 *
 	 * @param Account $account
 	 * @param AccountMapper $mapper
-	 * @param null $emitter
+	 * @param Manager $emitter
 	 * @param IConfig|null $config
 	 * @param null $urlGenerator
 	 * @param EventDispatcher|null $eventDispatcher
@@ -452,6 +452,10 @@ 
 		return $url;
 	}
 
+	/**
+	 * @param string $feature
+	 * @param string $value
+	 */
 	public function triggerChange($feature, $value = null) {
 		if ($this->emitter && in_array($feature, $this->account->getUpdatedFields())) {
 			$this->emitter->emit('\OC\User', 'changeUser', [$this, $feature, $value]);

Unused Use Statements -1 removed lines

@@ -41,7 +41,6 @@
 use OCP\IConfig;
 use OCP\IUserBackend;
 use OCP\User\IChangePasswordBackend;
-use OCP\UserInterface;
 use Symfony\Component\EventDispatcher\EventDispatcher;
 use Symfony\Component\EventDispatcher\GenericEvent;
 

apps/dav/lib/Connector/Sabre/File.php

Doc Comments +7 added lines, -1 removed lines

@@ -257,6 +257,9 @@ 
 			'file', 'create');
 	}
 
+	/**
+	 * @param string $path
+	 */
 	private function getPartFileBasePath($path) {
 		$partFileInStorage = \OC::$server->getConfig()->getSystemValue('part_file_in_storage', true);
 		if ($partFileInStorage) {
@@ -626,7 +629,7 @@ 
 	/**
 	 * Set $algo to get a specific checksum, leave null to get all checksums
 	 * (space seperated)
-	 * @param null $algo
+	 * @param string $algo
 	 * @return string
 	 */
 	public function getChecksum($algo = null) {
@@ -649,6 +652,9 @@ 
 		return '';
 	}
 
+	/**
+	 * @param string $string
+	 */
 	protected function header($string) {
 		\header($string);
 	}

lib/private/User/Session.php

Unused Use Statements -1 removed lines

@@ -53,7 +53,6 @@
 use OCP\IRequest;
 use OCP\ISession;
 use OCP\IUser;
-use OCP\IUserBackend;
 use OCP\IUserManager;
 use OCP\IUserSession;
 use OCP\Session\Exceptions\SessionNotAvailableException;

Doc Comments +8 added lines, -3 removed lines

@@ -315,7 +315,7 @@ 
 	 * @param IRequest $request
 	 * @throws LoginException
 	 * @throws PasswordLoginForbiddenException
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	public function logClientIn($user, $password, IRequest $request) {
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -358,6 +358,9 @@ 
 		return $this->config->getSystemValue('token_auth_enforced', false);
 	}
 
+	/**
+	 * @param string $username
+	 */
 	protected function isTwoFactorEnforced($username) {
 		Util::emitHook(
 			'\OCA\Files_Sharing\API\Server2Server',
@@ -560,7 +563,6 @@ 
 	 *
 	 * Log in a user and regenerate a new session.
 	 *
-	 * @param \OCP\Authentication\IApacheBackend $backend
 	 * @return bool
 	 * @throws LoginException
 	 */
@@ -980,6 +982,9 @@ 
 		}
 	}
 
+	/**
+	 * @param IRequest $request
+	 */
 	public function verifyAuthHeaders($request) {
 		foreach ($this->getAuthModules(true) as $module) {
 			$user = $module->auth($request);
@@ -999,7 +1004,7 @@ 
 	}
 
 	/**
-	 * @param $includeBuiltIn
+	 * @param boolean $includeBuiltIn
 	 * @return \Generator | IAuthModule[]
 	 * @throws Exception
 	 */

apps/dav/lib/Connector/Sabre/CorsPlugin.php

Doc Comments +2 added lines, -2 removed lines

@@ -62,7 +62,7 @@ 
 	 * This method should set up the required event subscriptions.
 	 *
 	 * @param \Sabre\DAV\Server $server
-	 * @return void
+	 * @return false|null
 	 */
 	public function initialize(\Sabre\DAV\Server $server) {
 		$this->server = $server;
@@ -96,7 +96,7 @@ 
 	 * @param RequestInterface $request
 	 * @param ResponseInterface $response
 	 *
-	 * @return false
+	 * @return false|null
 	 */
 	public function setOptionsRequestHeaders(RequestInterface $request, ResponseInterface $response) {
 		$authorization = $request->getHeader('Authorization');

lib/private/legacy/response.php

Doc Comments +2 added lines, -2 removed lines

@@ -275,7 +275,7 @@ 
 	 * @param string $domain
 	 * @param Sabre\HTTP\ResponseInterface $response
 	 * @param \OCP\IConfig $config
-	 * @param Array $headers
+	 * @param string[] $headers
 	 *
 	 * Format of $headers:
 	 * Array [
@@ -314,7 +314,7 @@ 
 	 * This function adds the CORS headers for all domains
 	 *
 	 * @param Sabre\HTTP\ResponseInterface $response
-	 * @param Array $headers
+	 * @param string[] $headers
 	 *
 	 * Format of $headers:
 	 * Array [

lib/private/App/AppManager.php

Doc Comments +7 added lines, -4 removed lines

@@ -122,7 +122,7 @@ 
 	/**
 	 * List all installed apps
 	 *
-	 * @return string[]
+	 * @return integer[]
 	 */
 	public function getInstalledApps() {
 		return array_keys($this->getInstalledAppsValues());
@@ -231,7 +231,7 @@ 
 	/**
 	 * Do not allow more than one active app-theme
 	 *
-	 * @param $appId
+	 * @param string $appId
 	 * @throws AppManagerException
 	 */
 	protected function canEnableTheme($appId) {
@@ -390,6 +390,9 @@ 
 		return in_array($appId, $this->shippedApps);
 	}
 
+	/**
+	 * @param string $appId
+	 */
 	private function isAlwaysEnabled($appId) {
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
 		return in_array($appId, $alwaysEnabled);
@@ -418,7 +421,7 @@ 
 	/**
 	 * @param string $package package path
 	 * @param bool $skipMigrations whether to skip migrations, which would only install the code
-	 * @return string|false app id or false in case of error
+	 * @return integer app id or false in case of error
 	 * @since 10.0
 	 */
 	public function installApp($package, $skipMigrations = false) {
@@ -431,7 +434,7 @@ 
 
 	/**
 	 * @param string $package
-	 * @return mixed
+	 * @return boolean
 	 * @since 10.0
 	 */
 	public function updateApp($package) {

core/Command/App/Enable.php

Unused Use Statements -1 removed lines

@@ -25,7 +25,6 @@
 namespace OC\Core\Command\App;
 
 use OCP\App\IAppManager;
-use OCP\ILogger;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;