Completed
Pull Request — master (#31078)
by Matthew
49:04 queued 37:44
created
lib/private/App/AppManager.php 1 patch
Doc Comments   +7 added lines, -4 removed lines patch added patch discarded remove patch
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 	/**
133 133
 	 * List all installed apps
134 134
 	 *
135
-	 * @return string[]
135
+	 * @return integer[]
136 136
 	 */
137 137
 	public function getInstalledApps() {
138 138
 		return \array_keys($this->getInstalledAppsValues());
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
 	/**
242 242
 	 * Do not allow more than one active app-theme
243 243
 	 *
244
-	 * @param $appId
244
+	 * @param string $appId
245 245
 	 * @throws AppManagerException
246 246
 	 */
247 247
 	protected function canEnableTheme($appId) {
@@ -400,6 +400,9 @@  discard block
 block discarded – undo
400 400
 		return \in_array($appId, $this->shippedApps);
401 401
 	}
402 402
 
403
+	/**
404
+	 * @param string $appId
405
+	 */
403 406
 	private function isAlwaysEnabled($appId) {
404 407
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
405 408
 		return \in_array($appId, $alwaysEnabled);
@@ -428,7 +431,7 @@  discard block
 block discarded – undo
428 431
 	/**
429 432
 	 * @param string $package package path
430 433
 	 * @param bool $skipMigrations whether to skip migrations, which would only install the code
431
-	 * @return string|false app id or false in case of error
434
+	 * @return integer app id or false in case of error
432 435
 	 * @since 10.0
433 436
 	 */
434 437
 	public function installApp($package, $skipMigrations = false) {
@@ -441,7 +444,7 @@  discard block
 block discarded – undo
441 444
 
442 445
 	/**
443 446
 	 * @param string $package
444
-	 * @return mixed
447
+	 * @return boolean
445 448
 	 * @since 10.0
446 449
 	 */
447 450
 	public function updateApp($package) {
Please login to merge, or discard this patch.
lib/private/App/CodeChecker/NodeVisitor.php 1 patch
Doc Comments   +15 added lines patch added patch discarded remove patch
@@ -241,6 +241,9 @@  discard block
 block discarded – undo
241 241
 		}
242 242
 	}
243 243
 
244
+	/**
245
+	 * @param string $name
246
+	 */
244 247
 	private function checkBlackList($name, $errorCode, Node $node) {
245 248
 		$lowerName = \strtolower($name);
246 249
 
@@ -254,6 +257,9 @@  discard block
 block discarded – undo
254 257
 		}
255 258
 	}
256 259
 
260
+	/**
261
+	 * @param string $constantName
262
+	 */
257 263
 	private function checkBlackListConstant($class, $constantName, Node $node) {
258 264
 		$name = $class . '::' . $constantName;
259 265
 		$lowerName = \strtolower($name);
@@ -268,6 +274,9 @@  discard block
 block discarded – undo
268 274
 		}
269 275
 	}
270 276
 
277
+	/**
278
+	 * @param string $class
279
+	 */
271 280
 	private function checkBlackListFunction($class, $functionName, Node $node) {
272 281
 		$name = $class . '::' . $functionName;
273 282
 		$lowerName = \strtolower($name);
@@ -282,6 +291,9 @@  discard block
 block discarded – undo
282 291
 		}
283 292
 	}
284 293
 
294
+	/**
295
+	 * @param string $class
296
+	 */
285 297
 	private function checkBlackListMethod($class, $functionName, Node $node) {
286 298
 		$name = $class . '::' . $functionName;
287 299
 		$lowerName = \strtolower($name);
@@ -296,6 +308,9 @@  discard block
 block discarded – undo
296 308
 		}
297 309
 	}
298 310
 
311
+	/**
312
+	 * @param string $name
313
+	 */
299 314
 	private function buildReason($name, $errorCode) {
300 315
 		if (isset($this->errorMessages[$errorCode])) {
301 316
 			$desc = $this->list->getDescription($errorCode, $name);
Please login to merge, or discard this patch.
lib/private/AvatarManager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -98,6 +98,9 @@
 block discarded – undo
98 98
 		}
99 99
 	}
100 100
 
101
+	/**
102
+	 * @param string $userId
103
+	 */
101 104
 	private function buildAvatarPath($userId) {
102 105
 		$avatar = \substr_replace(\substr_replace(\md5($userId), '/', 4, 0), '/', 2, 0);
103 106
 		return \explode('/', $avatar);
Please login to merge, or discard this patch.
lib/private/Comments/Manager.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -206,7 +206,7 @@
 block discarded – undo
206 206
 	/**
207 207
 	 * removes an entry from the comments run time cache
208 208
 	 *
209
-	 * @param mixed $id the comment's id
209
+	 * @param string $id the comment's id
210 210
 	 */
211 211
 	protected function uncache($id) {
212 212
 		$id = \strval($id);
Please login to merge, or discard this patch.
lib/private/DB/Migrator.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -234,6 +234,10 @@
 block discarded – undo
234 234
 		return '/^' . \preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')) . '/';
235 235
 	}
236 236
 
237
+	/**
238
+	 * @param integer $step
239
+	 * @param integer $max
240
+	 */
237 241
 	protected function emit($sql, $step, $max) {
238 242
 		if ($this->noEmit) {
239 243
 			return;
Please login to merge, or discard this patch.
lib/private/Files/Cache/Cache.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -409,6 +409,9 @@
 block discarded – undo
409 409
 		}
410 410
 	}
411 411
 
412
+	/**
413
+	 * @param string $path
414
+	 */
412 415
 	private function getParentPath($path) {
413 416
 		$parent = \dirname($path);
414 417
 		if ($parent === '.') {
Please login to merge, or discard this patch.
lib/private/Files/Cache/Wrapper/CacheJail.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 
75 75
 	/**
76 76
 	 * @param array $entry
77
-	 * @return array
77
+	 * @return string
78 78
 	 */
79 79
 	protected function formatCacheEntry($entry) {
80 80
 		if (isset($entry['path'])) {
@@ -193,6 +193,9 @@  discard block
 block discarded – undo
193 193
 		return $this->cache->getStatus($this->getSourcePath($file));
194 194
 	}
195 195
 
196
+	/**
197
+	 * @param \OCP\Files\Cache\ICacheEntry[] $results
198
+	 */
196 199
 	private function formatSearchResults($results) {
197 200
 		$results = \array_filter($results, [$this, 'filterCacheEntry']);
198 201
 		$results = \array_values($results);
Please login to merge, or discard this patch.
lib/private/Files/Node/Root.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 	 * @param string $path
176 176
 	 * @throws \OCP\Files\NotFoundException
177 177
 	 * @throws \OCP\Files\NotPermittedException
178
-	 * @return File|Folder
178
+	 * @return string
179 179
 	 */
180 180
 	public function get($path) {
181 181
 		$path = $this->normalizePath($path);
@@ -374,6 +374,9 @@  discard block
 block discarded – undo
374 374
 
375 375
 	}
376 376
 
377
+	/**
378
+	 * @param string $fullPath
379
+	 */
377 380
 	private function resolveVirtualNode($fullPath) {
378 381
 		$pieces = \explode('/', $fullPath);
379 382
 		if ($pieces[1] !== 'meta') {
Please login to merge, or discard this patch.
lib/private/Files/Stream/Checksum.php 1 patch
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -64,8 +64,8 @@  discard block
 block discarded – undo
64 64
 
65 65
 
66 66
 	/**
67
-	 * @param $source
68
-	 * @param $path
67
+	 * @param resource $source
68
+	 * @param string $path
69 69
 	 * @return resource
70 70
 	 */
71 71
 	public static function wrap($source, $path) {
@@ -126,6 +126,9 @@  discard block
 block discarded – undo
126 126
 		return parent::stream_write($data);
127 127
 	}
128 128
 
129
+	/**
130
+	 * @param string $data
131
+	 */
129 132
 	private function updateHashingContexts($data) {
130 133
 		foreach ($this->hashingContexts as $ctx) {
131 134
 			\hash_update($ctx, $data);
@@ -199,7 +202,7 @@  discard block
 block discarded – undo
199 202
 	}
200 203
 
201 204
 	/**
202
-	 * @return mixed
205
+	 * @return string
203 206
 	 * @return string
204 207
 	 */
205 208
 	private function getPathFromStreamContext() {
Please login to merge, or discard this patch.