OC_JSON

Complexity

Total Complexity

29

Size/Duplication

Total Lines	165
Duplicated Lines	23.64 %

Coupling/Cohesion

Components	1
Dependencies	14

Importance

Changes

0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	setContentTypeHeader()	0	7	2
A	checkAppEnabled()	7	7	2
A	sendErrorAndExit()	6	6	1
B	checkLoggedIn()	0	20	6
A	callCheck()	7	7	2
A	checkAdminUser()	7	7	2
A	checkUserExists()	7	7	2
A	checkSubAdminUser()	5	15	4
A	error()	0	4	1
A	success()	0	4	1
A	to_string()	0	5	2
A	encodedPrint()	0	6	2
A	encode()	0	6	2

<?php
/**
 * @author Bart Visscher <bartv@thisnet.nl>
 * @author Bernhard Posselt <dev@bernhard-posselt.com>
 * @author Christoph Wurst <christoph@owncloud.com>
 * @author Felix Moeller <mail@felixmoeller.de>
 * @author Georg Ehrke <georg@owncloud.com>
 * @author Lukas Reschke <lukas@statuscode.ch>
 * @author Morris Jobke <hey@morrisjobke.de>
 * @author Robin Appelman <icewind@owncloud.com>
 * @author Thomas Müller <thomas.mueller@tmit.eu>
 * @author Thomas Tanghus <thomas@tanghus.net>
 * @author Vincent Petry <pvince81@owncloud.com>
 *
 * @copyright Copyright (c) 2018, ownCloud GmbH
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

use OC\L10N\L10NString;
use OC\Authentication\Exceptions\AccountCheckException;

/**
 * Class OC_JSON
 * @deprecated Use a AppFramework JSONResponse instead
 */
class OC_JSON {
	protected static $send_content_type_header = false;
	/**
	 * set Content-Type header to jsonrequest
	 * @deprecated Use a AppFramework JSONResponse instead
	 */
	public static function setContentTypeHeader($type='application/json') {
		if (!self::$send_content_type_header) {
			// We send json data
			\header('Content-Type: '.$type . '; charset=utf-8');
			self::$send_content_type_header = true;
		}
	}

	/**
	 * Check if the app is enabled, send json error msg if not
	 * @param string $app
	 * @deprecated Use the AppFramework instead. It will automatically check if the app is enabled.
	 */
	public static function checkAppEnabled($app) {
		if (!OC_App::isEnabled($app)) {
			$l = \OC::$server->getL10N('lib');
			self::error(['data' => ['message' => $l->t('Application is not enabled'), 'error' => 'application_not_enabled']]);
			exit();
		}
	}

	private static function sendErrorAndExit() {
		$l = \OC::$server->getL10N('lib');
		\http_response_code(\OCP\AppFramework\Http::STATUS_UNAUTHORIZED);
		self::error(['data' => ['message' => $l->t('Authentication error'), 'error' => 'authentication_error']]);
		exit();
	}

	/**
	 * Check if the user is logged in, send json error msg if not
	 * @deprecated Use annotation based ACLs from the AppFramework instead
	 */
	public static function checkLoggedIn() {
		static $loginCalled = false;
		$userSession = \OC::$server->getUserSession();
		if (!$loginCalled && !$userSession->isLoggedIn()) {
			\OC::handleLogin(\OC::$server->getRequest());
			$loginCalled = true;
		}

		if (!$userSession->isLoggedIn()) {
			self::sendErrorAndExit();
		}
		if (\OC::$server->getTwoFactorAuthManager()->needsSecondFactor()) {
			self::sendErrorAndExit();
		}
		try {
			\OC::$server->getAccountModuleManager()->check($userSession->getUser());

It seems like $userSession->getUser() can be null; however, check() does not accept null, maybe add an additional type check?

		} catch (AccountCheckException $ex) {
			self::sendErrorAndExit();
		}
	}

	/**
	 * Check an ajax get/post call if the request token is valid, send json error msg if not.
	 * @deprecated Use annotation based CSRF checks from the AppFramework instead
	 */
	public static function callCheck() {
		if (!(\OC::$server->getRequest()->passesCSRFCheck())) {
			$l = \OC::$server->getL10N('lib');
			self::error(['data' => ['message' => $l->t('Token expired. Please reload page.'), 'error' => 'token_expired']]);
			exit();
		}
	}

	/**
	 * Check if the user is a admin, send json error msg if not.
	 * @deprecated Use annotation based ACLs from the AppFramework instead
	 */
	public static function checkAdminUser() {
		if (!OC_User::isAdminUser(OC_User::getUser())) {

It seems like \OC_User::getUser() targeting OC_User::getUser() can also be of type boolean; however, OC_User::isAdminUser() does only seem to accept string, maybe add an additional type check?

			$l = \OC::$server->getL10N('lib');
			self::error(['data' => ['message' => $l->t('Authentication error'), 'error' => 'authentication_error']]);
			exit();
		}
	}

	/**
	 * Check is a given user exists - send json error msg if not
	 * @param string $user
	 * @deprecated Use a AppFramework JSONResponse instead
	 */
	public static function checkUserExists($user) {
		if (!OCP\User::userExists($user)) {
			$l = \OC::$server->getL10N('lib');
			OCP\JSON::error(['data' => ['message' => $l->t('Unknown user'), 'error' => 'unknown_user']]);
			exit;
		}
	}

	/**
	 * Check if the user has administration privileges, send json error msg if not
	 * @deprecated Use annotation based ACLs from the AppFramework instead
	 */
	public static function checkSubAdminUser() {
		$hasUserManagementPrivileges = false;
		$userObject = \OC::$server->getUserSession()->getUser();
		if ($userObject !== null) {

This code seems to be duplicated across your project.

			//Admin and SubAdmins are allowed to access user management
			$hasUserManagementPrivileges = \OC::$server->getGroupManager()->isAdmin($userObject->getUID())
				|| \OC::$server->getGroupManager()->getSubAdmin()->isSubAdmin($userObject);
		}

		if (!$hasUserManagementPrivileges) {
			$l = \OC::$server->getL10N('lib');
			self::error(['data' => ['message' => $l->t('Authentication error'), 'error' => 'authentication_error']]);
			exit();
		}
	}

	/**
	 * Send json error msg
	 * @deprecated Use a AppFramework JSONResponse instead
	 */
	public static function error($data = []) {
		$data['status'] = 'error';
		self::encodedPrint($data);
	}

	/**
	 * Send json success msg
	 * @deprecated Use a AppFramework JSONResponse instead
	 */
	public static function success($data = []) {
		$data['status'] = 'success';
		self::encodedPrint($data);
	}

	/**
	 * Convert \OC\L10N\String to string, for use in json encodings
	 */
	protected static function to_string(&$value) {
		if ($value instanceof L10NString) {
			$value = (string)$value;
		}
	}

	/**
	 * Encode and print $data in json format
	 * @deprecated Use a AppFramework JSONResponse instead
	 */
	public static function encodedPrint($data, $setContentType=true) {
		if ($setContentType) {
			self::setContentTypeHeader();
		}
		echo self::encode($data);
	}

	/**
	 * Encode JSON
	 * @deprecated Use a AppFramework JSONResponse instead
	 */
	public static function encode($data) {
		if (\is_array($data)) {
			\array_walk_recursive($data, ['OC_JSON', 'to_string']);
		}
		return \json_encode($data, JSON_HEX_TAG);
	}
}