owncloud / core

apps/dav/appinfo/application.php

Unused Use Statements -1 removed lines

@@ -25,7 +25,6 @@
 use OCA\DAV\CalDAV\CalDavBackend;
 use OCA\DAV\CardDAV\CardDavBackend;
 use OCA\DAV\CardDAV\ContactsManager;
-use OCA\DAV\CardDAV\SyncJob;
 use OCA\DAV\CardDAV\SyncService;
 use OCA\DAV\Connector\Sabre\Principal;
 use OCA\DAV\DAV\GroupPrincipalBackend;

lib/private/User/Session.php

Doc Comments +2 added lines, -2 removed lines

@@ -139,7 +139,7 @@ 
 	/**
 	 * get the current active user
 	 *
-	 * @return \OCP\IUser|null Current user, otherwise null
+	 * @return null|User Current user, otherwise null
 	 */
 	public function getUser() {
 		// FIXME: This is a quick'n dirty work-around for the incognito mode as
@@ -211,7 +211,7 @@ 
 	 *
 	 * @param string $uid
 	 * @param string $password
-	 * @return boolean|null
+	 * @return boolean
 	 * @throws LoginException
 	 */
 	public function login($uid, $password) {

lib/private/User/User.php

Doc Comments +5 added lines, -1 removed lines

@@ -332,7 +332,7 @@ 
 	/**
 	 * get the users email address
 	 *
-	 * @return string|null
+	 * @return string
 	 * @since 9.0.0
 	 */
 	public function getEMailAddress() {
@@ -417,6 +417,10 @@ 
 		return $url;
 	}
 
+	/**
+	 * @param string $feature
+	 * @param string $value
+	 */
 	public function triggerChange($feature, $value = null) {
 		if ($this->emitter) {
 			$this->emitter->emit('\OC\User', 'changeUser', array($this, $feature, $value));

lib/public/App/ManagerEvent.php

Doc Comments +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
 	 * DispatcherEvent constructor.
 	 *
 	 * @param string $event
-	 * @param $appID
+	 * @param string $appID
 	 * @param \OCP\IGroup[] $groups
 	 * @since 9.0.0
 	 */

lib/public/AppFramework/Db/Mapper.php

Doc Comments +2 added lines, -1 removed lines

@@ -308,6 +308,7 @@ 
 	 * @param array $params the parameters of the sql query
 	 * @param int $limit the maximum number of rows
 	 * @param int $offset from which row we want to start
+	 * @param string $msg
 	 * @return string formatted error message string
 	 * @since 9.1.0
 	 */
@@ -360,7 +361,7 @@ 
 	 * Returns an db result and throws exceptions when there are more or less
 	 * results
 	 * @param string $sql the sql query
-	 * @param array $params the parameters of the sql query
+	 * @param string[] $params the parameters of the sql query
 	 * @param int $limit the maximum number of rows
 	 * @param int $offset from which row we want to start
 	 * @throws DoesNotExistException if the item does not exist

apps/files_trashbin/lib/trashbin.php

Doc Comments +3 added lines, -2 removed lines

@@ -670,7 +670,7 @@ 
 	 * if the size limit for the trash bin is reached, we delete the oldest
 	 * files in the trash bin until we meet the limit again
 	 *
-	 * @param array $files
+	 * @param \OCP\Files\FileInfo[] $files
 	 * @param string $user
 	 * @param int $availableSpace available disc space
 	 * @return int size of deleted files
@@ -698,7 +698,7 @@ 
 	/**
 	 * delete files older then max storage time
 	 *
-	 * @param array $files list of files sorted by mtime
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
 	 * @param string $user
 	 * @return integer[] size of deleted files and number of deleted files
 	 */
@@ -768,6 +768,7 @@ 
 	 *
 	 * @param string $filename name of the file which should be restored
 	 * @param int $timestamp timestamp when the file was deleted
+	 * @param string|boolean $user
 	 * @return array
 	 */
 	private static function getVersionsFromTrash($filename, $timestamp, $user) {

lib/private/AppFramework/DependencyInjection/DIContainer.php

Doc Comments +3 added lines

@@ -420,6 +420,9 @@
 		return \OC_User::isAdminUser($uid);
 	}
 
+	/**
+	 * @return string
+	 */
 	private function getUserId() {
 		return $this->getServer()->getSession()->get('user_id');
 	}

lib/private/Files/View.php

Doc Comments +2 added lines, -2 removed lines

@@ -196,7 +196,7 @@ 
 	 * and does not take the chroot into account )
 	 *
 	 * @param string $path
-	 * @return \OCP\Files\Mount\IMountPoint
+	 * @return Mount\MountPoint|null
 	 */
 	public function getMount($path) {
 		return Filesystem::getMountManager()->find($this->getAbsolutePath($path));
@@ -2034,7 +2034,7 @@ 
 
 	/**
 	 * @param string $filename
-	 * @return array
+	 * @return string[]
 	 * @throws \OC\User\NoUserException
 	 * @throws NotFoundException
 	 */

lib/private/L10N/Factory.php

Doc Comments +4 added lines

@@ -278,6 +278,10 @@
 	 */
 	// FIXME This method is only public, until OC_L10N does not need it anymore,
 	// FIXME This is also the reason, why it is not in the public interface
+
+	/**
+	 * @param string|boolean $app
+	 */
 	public function getL10nFilesForApp($app, $lang) {
 		$languageFiles = [];