owncloud / core

lib/private/files/node/root.php

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 
 namespace OC\Files\Node;
 
-use OC\Files\Cache\Cache;
 use OC\Files\Mount\Manager;
 use OC\Files\Mount\Mount;
 use OCP\Files\NotFoundException;

lib/private/files/view.php

Doc Comments +10 added lines

@@ -347,6 +347,10 @@ 
 		return $this->basicOperation('file_get_contents', $path, array('read'));
 	}
 
+	/**
+	 * @param string|null $path
+	 * @param boolean $run
+	 */
 	protected function emit_file_hooks_pre($exists, $path, &$run) {
 		if (!$exists) {
 			\OC_Hook::emit(Filesystem::CLASSNAME, Filesystem::signal_create, array(
@@ -365,6 +369,9 @@ 
 		));
 	}
 
+	/**
+	 * @param string|null $path
+	 */
 	protected function emit_file_hooks_post($exists, $path) {
 		if (!$exists) {
 			\OC_Hook::emit(Filesystem::CLASSNAME, Filesystem::signal_post_create, array(
@@ -546,6 +553,9 @@ 
 		}
 	}
 
+	/**
+	 * @return string
+	 */
 	public function copy($path1, $path2) {
 		$postFix1 = (substr($path1, -1, 1) === '/') ? '/' : '';
 		$postFix2 = (substr($path2, -1, 1) === '/') ? '/' : '';

lib/private/helper.php

Doc Comments +7 added lines, -4 removed lines

@@ -34,7 +34,7 @@ 
 	 * @param string $route
 	 * @param array $parameters
 	 * @return
-	 * @internal param array $args with param=>value, will be appended to the returned url
+	 string @internal param array $args with param=>value, will be appended to the returned url
 	 * @return string the url
 	 *
 	 * Returns a url to the given app and file.
@@ -273,6 +273,9 @@ 
 		return self::linkToRoute( 'core_ajax_preview', array('x' => 36, 'y' => 36, 'file' => $path ));
 	}
 
+	/**
+	 * @param string $path
+	 */
 	public static function publicPreviewIcon( $path, $token ) {
 		return self::linkToRoute( 'core_ajax_public_preview', array('x' => 36, 'y' => 36, 'file' => $path, 't' => $token));
 	}
@@ -341,7 +344,7 @@ 
 	/**
 	 * Make a computer file size
 	 * @param string $str file size in human readable format
-	 * @return int a file size in bytes
+	 * @return double a file size in bytes
 	 *
 	 * Makes 2kB to 2048.
 	 *
@@ -856,7 +859,7 @@ 
 	 *
 	 * @param string $path
 	 * @param \OCP\Files\FileInfo $rootInfo (optional)
-	 * @return array
+	 * @return string
 	 */
 	public static function getStorageInfo($path, $rootInfo = null) {
 		// return storage info without adding mount points
@@ -939,7 +942,7 @@ 
 
 	/**
 	 * Returns whether the config file is set manually to read-only
-	 * @return bool
+	 * @return string
 	 */
 	public static function isReadOnlyConfigEnabled() {
 		return \OC::$server->getConfig()->getSystemValue('config_is_read_only', false);

lib/private/image.php

Doc Comments +4 added lines, -3 removed lines

@@ -51,7 +51,7 @@ 
 	 * Constructor.
 	 * @param resource|string $imageRef The path to a local file, a base64 encoded string or a resource created by
 	 * an imagecreate* function.
-	 * @return \OC_Image False on error
+	 * @return false|null False on error
 	 */
 	public function __construct($imageRef = null) {
 		//OC_Log::write('core',__METHOD__.'(): start', OC_Log::DEBUG);
@@ -266,7 +266,7 @@ 
 	}
 
 	/**
-	* @return resource Returns the image resource in any.
+	* @return boolean Returns the image resource in any.
 	*/
 	public function resource() {
 		return $this->resource;
@@ -424,7 +424,7 @@ 
 	* Loads an image from an open file handle.
 	* It is the responsibility of the caller to position the pointer at the correct place and to close the handle again.
 	* @param resource $handle
-	* @return resource|false An image resource or false on error
+	* @return boolean|null An image resource or false on error
 	*/
 	public function loadFromFileHandle($handle) {
 		OC_Log::write('core', __METHOD__.'(): Trying', OC_Log::DEBUG);
@@ -944,6 +944,7 @@ 
 	 * @param string $fileName [optional] <p>The path to save the file to.</p>
 	 * @param int $bit [optional] <p>Bit depth, (default is 24).</p>
 	 * @param int $compression [optional]
+	 * @param boolean $im
 	 * @return bool <b>TRUE</b> on success or <b>FALSE</b> on failure.
 	 */
 	function imagebmp($im, $fileName='', $bit=24, $compression=0) {

lib/private/l10n.php

Doc Comments +2 added lines, -2 removed lines

@@ -495,7 +495,7 @@ 
 	/**
 	 * find the l10n directory
 	 * @param string $app App that needs to be translated
-	 * @return directory
+	 * @return string
 	 */
 	protected static function findI18nDir($app) {
 		// find the i18n dir
@@ -515,7 +515,7 @@ 
 	/**
 	 * find all available languages for an app
 	 * @param string $app App that needs to be translated
-	 * @return array an array of available languages
+	 * @return string[] an array of available languages
 	 */
 	public static function findAvailableLanguages($app=null) {
 		$available=array('en');//english is always available

lib/private/l10n/factory.php

Doc Comments -1 removed lines

@@ -21,7 +21,6 @@
 	/**
 	 * get an L10N instance
 	 * @param string $app
-	 * @param string|null $lang
 	 * @return \OC_L10N
 	 */
 	public function get($app) {

lib/private/migration/content.php

Doc Comments +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
 
 	/**
 	* sets up the
-	* @param ZipArchive $zip ZipArchive object
+	* @param boolean $zip ZipArchive object
 	* @param object $db a database object (required for exporttype user)
 	* @return bool|null
 	*/

lib/private/migration/provider.php

Doc Comments +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
 
 	/**
 	* returns the appid of the provider
-	* @return string
+	* @return boolean
 	*/
 	public function getID() {
 		return $this->id;

lib/private/preview.php

Doc Comments +4 added lines, -1 removed lines

@@ -75,7 +75,7 @@ 
 	 * @param int $maxY The maximum Y size of the thumbnail. It can be smaller depending on the shape of the image
 	 * @param bool $scalingUp Disable/Enable upscaling of previews
 	 * @throws \Exception
-	 * @return mixed (bool / string)
+	 * @return integer (bool / string)
 	 *                    false if thumbnail does not exist
 	 *                    path to thumbnail if thumbnail exists
 	 */
@@ -882,6 +882,9 @@ 
 	}
 
 
+	/**
+	 * @param integer $fileId
+	 */
 	private function getPreviewPath($fileId) {
 		return $this->getThumbnailsFolder() . '/' . $fileId . '/';
 	}