owncloud / core

tests/lib/files/objectstore/swift.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use OCP\IUser;
 use OCP\ILogger;
 use OCP\Files\Folder;
-
 use OC\Share20\Exception\ShareNotFound;
 
 /**

tests/lib/files/view.php

Doc Comments +11 added lines

@@ -338,6 +338,10 @@ 
 		$this->copyBetweenStorages($storage1, $storage2);
 	}
 
+	/**
+	 * @param \OC\Files\Storage\Storage $storage1
+	 * @param \OC\Files\Storage\Storage $storage2
+	 */
 	function copyBetweenStorages($storage1, $storage2) {
 		\OC\Files\Filesystem::mount($storage1, array(), '/');
 		\OC\Files\Filesystem::mount($storage2, array(), '/substorage');
@@ -384,6 +388,10 @@ 
 		$this->moveBetweenStorages($storage1, $storage2);
 	}
 
+	/**
+	 * @param \OC\Files\Storage\Storage $storage1
+	 * @param \OC\Files\Storage\Storage $storage2
+	 */
 	function moveBetweenStorages($storage1, $storage2) {
 		\OC\Files\Filesystem::mount($storage1, array(), '/');
 		\OC\Files\Filesystem::mount($storage2, array(), '/substorage');
@@ -944,6 +952,9 @@ 
 		$this->doTestCopyRenameFail('copy');
 	}
 
+	/**
+	 * @param string $operation
+	 */
 	private function doTestCopyRenameFail($operation) {
 		$storage1 = new Temporary(array());
 		/** @var \PHPUnit_Framework_MockObject_MockObject | \OC\Files\Storage\Temporary $storage2 */

tests/lib/helper.php

Doc Comments +1 added lines, -1 removed lines

@@ -505,7 +505,7 @@
 	 * Allows us to test private methods/properties
 	 *
 	 * @param $object
-	 * @param $methodName
+	 * @param string $methodName
 	 * @param array $parameters
 	 * @return mixed
 	 */

tests/lib/repair/repairlegacystorage.php

Doc Comments +2 added lines, -2 removed lines

@@ -86,8 +86,8 @@
 	/**
 	 * Returns the storage id based on the numeric id
 	 *
-	 * @param int $numericId numeric id of the storage
-	 * @return string storage id or null if not found
+	 * @param string $storageId
+	 * @return integer|null storage id or null if not found
 	 */
 	private function getStorageId($storageId) {
 		$numericId = \OC\Files\Cache\Storage::getNumericStorageId($storageId);

lib/private/util.php

Doc Comments +3 added lines, -3 removed lines

@@ -1183,7 +1183,7 @@ 
 	/**
 	 * Checks if a secure random number generator is available
 	 *
-	 * @return true
+	 * @return boolean
 	 * @deprecated Function will be removed in the future and does only return true.
 	 */
 	public static function secureRNGAvailable() {
@@ -1286,7 +1286,7 @@ 
 	 * Normalize a unicode string
 	 *
 	 * @param string $value a not normalized string
-	 * @return bool|string
+	 * @return string
 	 */
 	public static function normalizeUnicode($value) {
 		if(Normalizer::isNormalized($value)) {
@@ -1382,7 +1382,7 @@ 
 	/**
 	 * Check if PhpCharset config is UTF-8
 	 *
-	 * @return string
+	 * @return boolean
 	 */
 	public static function isPhpCharSetUtf8() {
 		return strtoupper(ini_get('default_charset')) === 'UTF-8';

tests/lib/connector/sabre/objecttree.php

Unused Use Statements -2 removed lines

@@ -10,8 +10,6 @@
 
 
 use OC\Files\FileInfo;
-use OC\Files\Storage\Temporary;
-use PHPUnit_Framework_TestCase;
 
 class TestDoubleFileView extends \OC\Files\View {