Completed
Pull Request — master (#24604)
by Roeland
32:31
created
apps/files_external/command/applicable.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -28,8 +28,6 @@
 block discarded – undo
28 28
 use OCP\IGroupManager;
29 29
 use OCP\IUserManager;
30 30
 use Symfony\Component\Console\Command\Command;
31
-use Symfony\Component\Console\Helper\Table;
32
-use Symfony\Component\Console\Helper\TableHelper;
33 31
 use Symfony\Component\Console\Input\InputArgument;
34 32
 use Symfony\Component\Console\Input\InputInterface;
35 33
 use Symfony\Component\Console\Input\InputOption;
Please login to merge, or discard this patch.
apps/files_external/command/backends.php 1 patch
Unused Use Statements   -6 removed lines patch added patch discarded remove patch
@@ -22,18 +22,12 @@
 block discarded – undo
22 22
 namespace OCA\Files_External\Command;
23 23
 
24 24
 use OC\Core\Command\Base;
25
-use OCA\Files_External\Lib\Auth\AuthMechanism;
26 25
 use OCA\Files_External\Lib\Backend\Backend;
27 26
 use OCA\Files_External\Lib\DefinitionParameter;
28 27
 use OCA\Files_External\Service\BackendService;
29 28
 use Symfony\Component\Console\Command\Command;
30
-use Symfony\Component\Console\Helper\Table;
31
-use Symfony\Component\Console\Helper\TableHelper;
32
-use Symfony\Component\Console\Input\ArrayInput;
33 29
 use Symfony\Component\Console\Input\InputArgument;
34 30
 use Symfony\Component\Console\Input\InputInterface;
35
-use Symfony\Component\Console\Input\InputOption;
36
-use Symfony\Component\Console\Input\Input;
37 31
 use Symfony\Component\Console\Output\OutputInterface;
38 32
 
39 33
 class Backends extends Base {
Please login to merge, or discard this patch.
apps/files_external/command/create.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -30,18 +30,14 @@
 block discarded – undo
30 30
 use OCA\Files_external\Lib\StorageConfig;
31 31
 use OCA\Files_External\Service\BackendService;
32 32
 use OCA\Files_external\Service\GlobalStoragesService;
33
-use OCA\Files_external\Service\ImportLegacyStoragesService;
34 33
 use OCA\Files_external\Service\UserStoragesService;
35 34
 use OCP\IUserManager;
36 35
 use OCP\IUserSession;
37 36
 use Symfony\Component\Console\Command\Command;
38
-use Symfony\Component\Console\Helper\Table;
39
-use Symfony\Component\Console\Helper\TableHelper;
40 37
 use Symfony\Component\Console\Input\ArrayInput;
41 38
 use Symfony\Component\Console\Input\InputArgument;
42 39
 use Symfony\Component\Console\Input\InputInterface;
43 40
 use Symfony\Component\Console\Input\InputOption;
44
-use Symfony\Component\Console\Input\Input;
45 41
 use Symfony\Component\Console\Output\OutputInterface;
46 42
 
47 43
 class Create extends Base {
Please login to merge, or discard this patch.
apps/files_external/command/verify.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -28,8 +28,6 @@
 block discarded – undo
28 28
 use OCP\IGroupManager;
29 29
 use OCP\IUserManager;
30 30
 use Symfony\Component\Console\Command\Command;
31
-use Symfony\Component\Console\Helper\Table;
32
-use Symfony\Component\Console\Helper\TableHelper;
33 31
 use Symfony\Component\Console\Input\InputArgument;
34 32
 use Symfony\Component\Console\Input\InputInterface;
35 33
 use Symfony\Component\Console\Input\InputOption;
Please login to merge, or discard this patch.
apps/files_sharing/lib/migration.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -128,7 +128,6 @@
 block discarded – undo
128 128
 	/**
129 129
 	 * Get $n re-shares from the database
130 130
 	 *
131
-	 * @param int $n The max number of shares to fetch
132 131
 	 * @return \Doctrine\DBAL\Driver\Statement
133 132
 	 */
134 133
 	private function getReShares() {
Please login to merge, or discard this patch.
apps/federation/lib/dbhandler.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -271,8 +271,8 @@
 block discarded – undo
271 271
 	}
272 272
 
273 273
 	/**
274
-	 * @param $username
275
-	 * @param $password
274
+	 * @param string $username
275
+	 * @param string $password
276 276
 	 * @return bool
277 277
 	 */
278 278
 	public function auth($username, $password) {
Please login to merge, or discard this patch.
apps/files_sharing/api/sharees.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -327,7 +327,7 @@
 block discarded – undo
327 327
 	 * split user and remote from federated cloud id
328 328
 	 *
329 329
 	 * @param string $address federated share address
330
-	 * @return array [user, remoteURL]
330
+	 * @return string[] [user, remoteURL]
331 331
 	 * @throws \Exception
332 332
 	 */
333 333
 	public function splitUserRemote($address) {
Please login to merge, or discard this patch.
lib/private/Server.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -856,7 +856,7 @@
 block discarded – undo
856 856
 	 * Get the certificate manager for the user
857 857
 	 *
858 858
 	 * @param string $userId (optional) if not specified the current loggedin user is used
859
-	 * @return \OCP\ICertificateManager | null if $uid is null and no user is logged in
859
+	 * @return null|CertificateManager | null if $uid is null and no user is logged in
860 860
 	 */
861 861
 	public function getCertificateManager($userId = null) {
862 862
 		if (is_null($userId)) {
Please login to merge, or discard this patch.
lib/private/Share20/Manager.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -25,7 +25,6 @@  discard block
 block discarded – undo
25 25
 use OCP\IUserManager;
26 26
 use OCP\Share\IManager;
27 27
 use OCP\Share\IProviderFactory;
28
-use OC\Share20\Exception\BackendError;
29 28
 use OCP\IConfig;
30 29
 use OCP\IL10N;
31 30
 use OCP\ILogger;
@@ -35,7 +34,6 @@  discard block
 block discarded – undo
35 34
 use OCP\IGroupManager;
36 35
 use OCP\Files\File;
37 36
 use OCP\Files\Folder;
38
-
39 37
 use OCP\Share\Exceptions\ShareNotFound;
40 38
 use OCP\Share\Exceptions\GenericShareException;
41 39
 
Please login to merge, or discard this patch.