owncloud / core

lib/private/Share/MailNotifications.php

Doc Comments +3 added lines, -3 removed lines

@@ -180,10 +180,10 @@
 	 * inform recipient about public link share
 	 *
 	 * @param string $recipient recipient email address
-	 * @param string $filename the shared file
-	 * @param string $link the public link
 	 * @param array $options allows ['cc'] and ['bcc'] recipients
-	 * @param int $expiration expiration date (timestamp)
+	 * @param string $subject
+	 * @param boolean|string $htmlBody
+	 * @param boolean|string $textBody
 	 * @return string[] $result of failed recipients
 	 */
 	public function sendLinkShareMailFromBody($recipient, $subject, $htmlBody, $textBody, $options = array()) {

apps/dav/lib/Upload/ChunkingPlugin.php

Doc Comments +2 added lines, -2 removed lines

@@ -45,7 +45,7 @@ 
 	/**
 	 * @param string $sourcePath source path
 	 * @param string $destination destination path
-	 * @return bool|void
+	 * @return null|false
 	 * @throws BadRequest
 	 * @throws \Sabre\DAV\Exception\NotFound
 	 */
@@ -69,7 +69,7 @@ 
 	 *
 	 * @param string $path source path
 	 * @param string $destination destination path
-	 * @return bool|void false to stop handling, void to skip this handler
+	 * @return null|false false to stop handling, void to skip this handler
 	 */
 	public function performMove($path, $destination) {
 		if (!$this->server->tree->nodeExists($destination)) {

apps/dav/lib/CalDAV/CalDavBackend.php

Doc Comments +7 added lines, -1 removed lines

@@ -270,6 +270,9 @@ 
 		return array_values($calendars);
 	}
 
+	/**
+	 * @param string $principalUri
+	 */
 	public function getUsersOwnCalendars($principalUri) {
 		$principalUri = $this->convertPrincipal($principalUri, true);
 		$fields = array_values($this->propertyMap);
@@ -1279,7 +1282,7 @@ 
 	 * @param string $principalUri
 	 * @param string $uri
 	 * @param array $properties
-	 * @return mixed
+	 * @return integer
 	 * @throws Forbidden
 	 */
 	function createSubscription($principalUri, $uri, array $properties) {
@@ -1685,6 +1688,9 @@ 
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
 	}
 
+	/**
+	 * @param boolean $toV2
+	 */
 	private function convertPrincipal($principalUri, $toV2 = null) {
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
 			list(, $name) = URLUtil::splitPath($principalUri);

lib/private/User/TokenAuthModule.php

Unused Use Statements -1 removed lines

@@ -30,7 +30,6 @@
 use OCP\Authentication\IAuthModule;
 use OCP\IRequest;
 use OCP\ISession;
-use OCP\IUser;
 use OCP\IUserManager;
 use OCP\Session\Exceptions\SessionNotAvailableException;
 

lib/private/Notification/Manager.php

Doc Comments +2 added lines

@@ -113,6 +113,8 @@
 	 * INTERNAL USE ONLY!! This method isn't part of the IManager interface
 	 * @internal This should only be used by the RegisterNotifierEventImpl (the real implementation).
 	 * Do NOT use this method outside as it might not work as expected.
+	 * @param string $id
+	 * @param string $name
 	 */
 	public function registerBuiltNotifier(INotifier $notifier, $id, $name) {
 		if (!isset($this->builtNotifiersHolder[$id]) && !isset($this->notifiersInfo[$id])) {

lib/private/AppFramework/Utility/ControllerMethodReflector.php

Doc Comments +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
 
 
 	/**
-	 * @param object|string $object an object or classname
+	 * @param \OCP\AppFramework\Controller $object an object or classname
 	 * @param string $method the method which we want to inspect
 	 * @throws \ReflectionException
 	 */

settings/Controller/CorsController.php

Doc Comments -1 removed lines

@@ -134,7 +134,6 @@
 	 * @NoAdminRequired
 	 * @NoSubadminRequired
 	 *
-	 * @param string $domain Domain to remove
 	 * @return RedirectResponse Redirection to the settings page.
 	 */
 	public function removeDomain($id) {

core/Middleware/TwoFactorMiddleware.php

Doc Comments +2 added lines, -2 removed lines

@@ -109,8 +109,8 @@
 	}
 
 	/**
-	 * @param $controller
-	 * @param $methodName
+	 * @param Controller $controller
+	 * @param string $methodName
 	 * @throws TwoFactorAuthRequiredException
 	 * @throws UserAlreadyLoggedInException
 	 */

apps/provisioning_api/lib/Users.php

Unused Use Statements -1 removed lines

@@ -32,7 +32,6 @@
 use OC\OCS\Result;
 use OC_Helper;
 use OCP\API;
-use OCP\Files\FileInfo;
 use OCP\Files\NotFoundException;
 use OCP\IGroup;
 use OCP\IGroupManager;