Completed
Pull Request — master (#20150)
by Pellaeon
09:06
created
apps/federation/lib/dbhandler.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -271,8 +271,8 @@
 block discarded – undo
271 271
 	}
272 272
 
273 273
 	/**
274
-	 * @param $username
275
-	 * @param $password
274
+	 * @param string $username
275
+	 * @param string $password
276 276
 	 * @return bool
277 277
 	 */
278 278
 	public function auth($username, $password) {
Please login to merge, or discard this patch.
apps/files_sharing/api/sharees.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -327,7 +327,7 @@
 block discarded – undo
327 327
 	 * split user and remote from federated cloud id
328 328
 	 *
329 329
 	 * @param string $address federated share address
330
-	 * @return array [user, remoteURL]
330
+	 * @return string[] [user, remoteURL]
331 331
 	 * @throws \Exception
332 332
 	 */
333 333
 	public function splitUserRemote($address) {
Please login to merge, or discard this patch.
lib/private/Server.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -856,7 +856,7 @@
 block discarded – undo
856 856
 	 * Get the certificate manager for the user
857 857
 	 *
858 858
 	 * @param string $userId (optional) if not specified the current loggedin user is used
859
-	 * @return \OCP\ICertificateManager | null if $uid is null and no user is logged in
859
+	 * @return null|CertificateManager | null if $uid is null and no user is logged in
860 860
 	 */
861 861
 	public function getCertificateManager($userId = null) {
862 862
 		if (is_null($userId)) {
Please login to merge, or discard this patch.
lib/private/Share20/Manager.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -25,7 +25,6 @@  discard block
 block discarded – undo
25 25
 use OCP\IUserManager;
26 26
 use OCP\Share\IManager;
27 27
 use OCP\Share\IProviderFactory;
28
-use OC\Share20\Exception\BackendError;
29 28
 use OCP\IConfig;
30 29
 use OCP\IL10N;
31 30
 use OCP\ILogger;
@@ -35,7 +34,6 @@  discard block
 block discarded – undo
35 34
 use OCP\IGroupManager;
36 35
 use OCP\Files\File;
37 36
 use OCP\Files\Folder;
38
-
39 37
 use OCP\Share\Exceptions\ShareNotFound;
40 38
 use OCP\Share\Exceptions\GenericShareException;
41 39
 
Please login to merge, or discard this patch.
core/Command/Security/ListCertificates.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,6 @@
 block discarded – undo
28 28
 use Symfony\Component\Console\Command\Command;
29 29
 use Symfony\Component\Console\Helper\Table;
30 30
 use Symfony\Component\Console\Input\InputInterface;
31
-use Symfony\Component\Console\Input\InputOption;
32 31
 use Symfony\Component\Console\Output\OutputInterface;
33 32
 
34 33
 class ListCertificates extends Base {
Please login to merge, or discard this patch.
core/Controller/LostController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -131,7 +131,7 @@
 block discarded – undo
131 131
 	}
132 132
 
133 133
 	/**
134
-	 * @param $message
134
+	 * @param string $message
135 135
 	 * @param array $additional
136 136
 	 * @return array
137 137
 	 */
Please login to merge, or discard this patch.
settings/Controller/AppSettingsController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@
 block discarded – undo
97 97
 	}
98 98
 
99 99
 	/**
100
-	 * @param string|int $category
100
+	 * @param string $category
101 101
 	 * @return int
102 102
 	 */
103 103
 	protected function getCategory($category) {
Please login to merge, or discard this patch.
settings/Controller/CertificateController.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 	 *
71 71
 	 * @NoAdminRequired
72 72
 	 * @NoSubadminRequired
73
-	 * @return array
73
+	 * @return DataResponse
74 74
 	 */
75 75
 	public function addPersonalRootCertificate() {
76 76
 		return $this->addCertificate($this->userCertificateManager);
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 	 * Add a new root certificate to a trust store
81 81
 	 *
82 82
 	 * @param ICertificateManager $certificateManager
83
-	 * @return array
83
+	 * @return DataResponse
84 84
 	 */
85 85
 	private function addCertificate(ICertificateManager $certificateManager) {
86 86
 		$headers = [];
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 	/**
159 159
 	 * Add a new personal root certificate to the system's trust store
160 160
 	 *
161
-	 * @return array
161
+	 * @return DataResponse
162 162
 	 */
163 163
 	public function addSystemRootCertificate() {
164 164
 		return $this->addCertificate($this->systemCertificateManager);
Please login to merge, or discard this patch.
settings/Controller/CheckSetupController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -268,7 +268,7 @@
 block discarded – undo
268 268
 
269 269
 	/**
270 270
 	 * @NoCSRFRequired
271
-	 * @return DataResponse
271
+	 * @return DataDisplayResponse
272 272
 	 */
273 273
 	public function getFailedIntegrityCheckFiles() {
274 274
 		$completeResults = $this->checker->getResults();
Please login to merge, or discard this patch.