Completed
Pull Request — master (#25351)
by Thomas
09:29
created
apps/files_sharing/lib/Helper.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -278,6 +278,7 @@
 block discarded – undo
278 278
 	 * get default share folder
279 279
 	 *
280 280
 	 * @param \OC\Files\View
281
+	 * @param View $view
281 282
 	 * @return string
282 283
 	 */
283 284
 	public static function getShareFolder($view = null) {
Please login to merge, or discard this patch.
lib/private/User/Session.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
 	 * @param IRequest $request
301 301
 	 * @throws LoginException
302 302
 	 * @throws PasswordLoginForbiddenException
303
-	 * @return boolean
303
+	 * @return boolean|null
304 304
 	 */
305 305
 	public function logClientIn($user, $password, IRequest $request) {
306 306
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -340,6 +340,9 @@  discard block
 block discarded – undo
340 340
 		return $this->config->getSystemValue('token_auth_enforced', false);
341 341
 	}
342 342
 
343
+	/**
344
+	 * @param string $username
345
+	 */
343 346
 	protected function isTwoFactorEnforced($username) {
344 347
 		Util::emitHook(
345 348
 			'\OCA\Files_Sharing\API\Server2Server',
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/CalDavBackend.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1066,7 +1066,7 @@  discard block
 block discarded – undo
1066 1066
 	 * @param string $principalUri
1067 1067
 	 * @param string $uri
1068 1068
 	 * @param array $properties
1069
-	 * @return mixed
1069
+	 * @return integer
1070 1070
 	 */
1071 1071
 	function createSubscription($principalUri, $uri, array $properties) {
1072 1072
 
@@ -1429,7 +1429,7 @@  discard block
 block discarded – undo
1429 1429
 	}
1430 1430
 
1431 1431
 	/**
1432
-	 * @param OCA\DAV\CalDAV\Calendar $sharable
1432
+	 * @param Calendar $sharable
1433 1433
 	 * @param bool $value
1434 1434
 	 * @return void
1435 1435
 	 */
@@ -1466,6 +1466,9 @@  discard block
 block discarded – undo
1466 1466
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
1467 1467
 	}
1468 1468
 
1469
+	/**
1470
+	 * @param boolean $toV2
1471
+	 */
1469 1472
 	private function convertPrincipal($principalUri, $toV2) {
1470 1473
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1471 1474
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
apps/files_external/lib/Command/Backends.php 1 patch
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -27,13 +27,8 @@
 block discarded – undo
27 27
 use OCA\Files_External\Lib\DefinitionParameter;
28 28
 use OCA\Files_External\Service\BackendService;
29 29
 use Symfony\Component\Console\Command\Command;
30
-use Symfony\Component\Console\Helper\Table;
31
-use Symfony\Component\Console\Helper\TableHelper;
32
-use Symfony\Component\Console\Input\ArrayInput;
33 30
 use Symfony\Component\Console\Input\InputArgument;
34 31
 use Symfony\Component\Console\Input\InputInterface;
35
-use Symfony\Component\Console\Input\InputOption;
36
-use Symfony\Component\Console\Input\Input;
37 32
 use Symfony\Component\Console\Output\OutputInterface;
38 33
 
39 34
 class Backends extends Base {
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/Sharing/SharingPlugin.php 2 patches
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,7 +19,6 @@  discard block
 block discarded – undo
19 19
     /**
20 20
      * Plugin constructor.
21 21
      *
22
-     * @param Auth     $authBackEnd
23 22
      * @param IRequest $request
24 23
      */
25 24
     public function __construct(IRequest $request)
@@ -86,7 +85,7 @@  discard block
 block discarded – undo
86 85
    * @param RequestInterface $request
87 86
    * @param ResponseInterface $response
88 87
    *
89
-   * @return null|bool
88
+   * @return null|false
90 89
    */
91 90
   public function httpPost(RequestInterface $request, ResponseInterface $response)
92 91
   {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace OCA\DAV\CalDAV\Sharing;
4 4
 
5
-use Sabre\DAV\PropFind;
6 5
 use OCP\IRequest;
7 6
 use Sabre\CalDAV\IShareableCalendar;
8 7
 use Sabre\DAV\Server;
Please login to merge, or discard this patch.