owncloud / core

lib/private/Security/CredentialsManager.php

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
  */
 
 use OC\Share\MailNotifications;
-use OCP\IConfig;
 use OCP\IL10N;
 use OCP\IUser;
 use OCP\Mail\IMailer;

lib/private/Session/CryptoSessionData.php

Doc Comments +1 added lines, -1 removed lines

@@ -153,7 +153,7 @@
 
 	/**
 	 * @param mixed $offset
-	 * @return mixed
+	 * @return string|null
 	 */
 	public function offsetGet($offset) {
 		return $this->get($offset);

apps/files_sharing/lib/sharedstorage.php

Doc Comments +1 added lines, -1 removed lines

@@ -279,7 +279,7 @@
 	/**
 	 * get share ID
 	 *
-	 * @return integer unique share ID
+	 * @return string unique share ID
 	 */
 	public function getShareId() {
 		return $this->newShare->getId();

lib/private/Comments/Manager.php

Doc Comments +1 added lines, -1 removed lines

@@ -202,7 +202,7 @@
 	/**
 	 * removes an entry from the comments run time cache
 	 *
-	 * @param mixed $id the comment's id
+	 * @param string $id the comment's id
 	 */
 	protected function uncache($id) {
 		$id = strval($id);

core/Controller/LoginController.php

Unused Use Statements -1 removed lines

@@ -37,7 +37,6 @@
 use OC\HTTPHelper;
 use OC_Util;
 use OCP\IConfig;
-use OC\Setup;
 use OCP\Util;
 
 class VersionCheck extends BasicEmitter {

lib/private/DB/Connection.php

Doc Comments +2 added lines, -2 removed lines

@@ -167,7 +167,7 @@ 
 	 * If an SQLLogger is configured, the execution is logged.
 	 *
 	 * @param string                                      $query  The SQL query to execute.
-	 * @param array                                       $params The parameters to bind to the query, if any.
+	 * @param string[]                                       $params The parameters to bind to the query, if any.
 	 * @param array                                       $types  The types the previous parameters are in.
 	 * @param \Doctrine\DBAL\Cache\QueryCacheProfile|null $qcp    The query cache profile, optional.
 	 *
@@ -212,7 +212,7 @@ 
 	 * columns or sequences.
 	 *
 	 * @param string $seqName Name of the sequence object from which the ID should be returned.
-	 * @return string A string representation of the last inserted ID.
+	 * @return integer A string representation of the last inserted ID.
 	 */
 	public function lastInsertId($seqName = null)
 	{

lib/private/DB/Migrator.php

Doc Comments +9 added lines, -1 removed lines

@@ -60,7 +60,7 @@ 
 	private $noEmit = false;
 
 	/**
-	 * @param \Doctrine\DBAL\Connection|Connection $connection
+	 * @param Connection $connection
 	 * @param ISecureRandom $random
 	 * @param IConfig $config
 	 * @param EventDispatcher $dispatcher
@@ -273,6 +273,10 @@ 
 		return '/^' . preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')) . '/';
 	}
 
+	/**
+	 * @param integer $step
+	 * @param integer $max
+	 */
 	protected function emit($sql, $step, $max) {
 		if ($this->noEmit) {
 			return;
@@ -283,6 +287,10 @@ 
 		$this->dispatcher->dispatch('\OC\DB\Migrator::executeSql', new GenericEvent($sql, [$step+1, $max]));
 	}
 
+	/**
+	 * @param integer $step
+	 * @param integer $max
+	 */
 	private function emitCheckStep($tableName, $step, $max) {
 		if(is_null($this->dispatcher)) {
 			return;

lib/private/DB/QueryBuilder/CompositeExpression.php

Doc Comments +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
 	/**
 	 * Adds an expression to composite expression.
 	 *
-	 * @param mixed $part
+	 * @param string $part
 	 *
 	 * @return \OCP\DB\QueryBuilder\ICompositeExpression
 	 */

lib/private/DB/QueryBuilder/QueryBuilder.php

Doc Comments +1 added lines, -1 removed lines

@@ -646,7 +646,7 @@
 	 *         ->where($or);
 	 * </code>
 	 *
-	 * @param mixed $predicates The restriction predicates.
+	 * @param CompositeExpression $predicates The restriction predicates.
 	 *
 	 * @return \OCP\DB\QueryBuilder\IQueryBuilder This QueryBuilder instance.
 	 */