owncloud / core

lib/private/Files/View.php

Doc Comments +4 added lines, -4 removed lines

@@ -197,7 +197,7 @@ 
 	 * and does not take the chroot into account )
 	 *
 	 * @param string $path
-	 * @return \OCP\Files\Mount\IMountPoint
+	 * @return Mount\MountPoint|null
 	 */
 	public function getMount($path) {
 		return Filesystem::getMountManager()->find($this->getAbsolutePath($path));
@@ -960,7 +960,7 @@ 
 
 	/**
 	 * @param string $path
-	 * @return bool|string
+	 * @return string|false
 	 * @throws \OCP\Files\InvalidPathException
 	 */
 	public function toTmpFile($path) {
@@ -1075,7 +1075,7 @@ 
 	 * @param string $path
 	 * @param array $hooks (optional)
 	 * @param mixed $extraParam (optional)
-	 * @return mixed
+	 * @return string
 	 * @throws \Exception
 	 *
 	 * This method takes requests for basic filesystem functions (e.g. reading & writing
@@ -2083,7 +2083,7 @@ 
 
 	/**
 	 * @param string $filename
-	 * @return array
+	 * @return string[]
 	 * @throws \OC\User\NoUserException
 	 * @throws NotFoundException
 	 */

core/Controller/TokenController.php

Doc Comments +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
 	/**
 	 * @param string $appName
 	 * @param IRequest $request
-	 * @param Manager $userManager
+	 * @param UserManager $userManager
 	 * @param DefaultTokenProvider $tokenProvider
 	 * @param ISecureRandom $secureRandom
 	 */

apps/files_external/lib/Lib/Storage/Google.php

Doc Comments +1 added lines, -1 removed lines

@@ -213,7 +213,7 @@
 	 *
 	 * @param \Google_Service_Drive_DriveFile
 	 *
-	 * @return true if the file is a Google Doc file, false otherwise
+	 * @return boolean if the file is a Google Doc file, false otherwise
 	 */
 	private function isGoogleDocFile($file) {
 		return $this->getGoogleDocExtension($file->getMimeType()) !== '';

lib/private/Repair/RemoveOldShares.php

Doc Comments -1 removed lines

@@ -20,7 +20,6 @@
 	/**
 	 * RemoveOldCalendarShares constructor.
 	 *
-	 * @param IDBConnection $db
 	 */
 	public function __construct(IDBConnection $connection) {
 		$this->connection = $connection;

apps/files_sharing/lib/Helper.php

Doc Comments +1 added lines

@@ -278,6 +278,7 @@
 	 * get default share folder
 	 *
 	 * @param \OC\Files\View
+	 * @param View $view
 	 * @return string
 	 */
 	public static function getShareFolder($view = null) {

lib/private/User/Session.php

Doc Comments +4 added lines, -1 removed lines

@@ -300,7 +300,7 @@ 
 	 * @param IRequest $request
 	 * @throws LoginException
 	 * @throws PasswordLoginForbiddenException
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	public function logClientIn($user, $password, IRequest $request) {
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -340,6 +340,9 @@ 
 		return $this->config->getSystemValue('token_auth_enforced', false);
 	}
 
+	/**
+	 * @param string $username
+	 */
 	protected function isTwoFactorEnforced($username) {
 		Util::emitHook(
 			'\OCA\Files_Sharing\API\Server2Server',

apps/files_external/lib/Lib/Backend/SMB.php

Doc Comments +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
 	}
 
 	/**
-	 * @param StorageConfig $storage
+	 * @param IStorageConfig $storage
 	 * @param IUser $user
 	 */
 	public function manipulateStorageConfig(IStorageConfig &$storage, IUser $user = null) {

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use OCP\Files\External\Backend\Backend;
 use OCP\Files\External\IStorageConfig;
 use OCA\Files_External\Lib\LegacyDependencyCheckPolyfill;
-
 use OCP\IUser;
 
 class SMB extends Backend {

apps/dav/lib/DAV/PublicAuth.php

Doc Comments -1 removed lines

@@ -30,7 +30,6 @@
 	private $publicURLs;
 
 	/**
-	 * @param string[] $publicURLs
 	 */
 	public function __construct() {
 		$this->publicURLs = [

apps/files_external/lib/Lib/Backend/AmazonS3.php

Unused Use Statements -2 removed lines

@@ -22,11 +22,9 @@
 namespace OCA\Files_External\Lib\Backend;
 
 use OCP\IL10N;
-use OCP\Files\External\Auth\AuthMechanism;
 use OCP\Files\External\Backend\Backend;
 use OCP\Files\External\DefinitionParameter;
 use OCA\Files_External\Lib\LegacyDependencyCheckPolyfill;
-
 use OCA\Files_External\Lib\Auth\AmazonS3\AccessKey;
 
 class AmazonS3 extends Backend {