Completed
Pull Request — master (#27671)
by Juan Pablo
29:49
created
apps/dav/lib/CalDAV/Publishing/Xml/Publisher.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
  */
21 21
 namespace OCA\DAV\CalDAV\Publishing\Xml;
22 22
 
23
-use OCA\DAV\CalDAV\Publishing\PublishPlugin as Plugin;
24 23
 use Sabre\Xml\Writer;
25 24
 use Sabre\Xml\XmlSerializable;
26 25
 
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/File.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -236,6 +236,9 @@  discard block
 block discarded – undo
236 236
 		return '"' . $this->info->getEtag() . '"';
237 237
 	}
238 238
 
239
+	/**
240
+	 * @param string $path
241
+	 */
239 242
 	private function getPartFileBasePath($path) {
240 243
 		$partFileInStorage = \OC::$server->getConfig()->getSystemValue('part_file_in_storage', true);
241 244
 		if ($partFileInStorage) {
@@ -598,7 +601,7 @@  discard block
 block discarded – undo
598 601
 	/**
599 602
 	 * Set $algo to get a specific checksum, leave null to get all checksums
600 603
 	 * (space seperated)
601
-	 * @param null $algo
604
+	 * @param string $algo
602 605
 	 * @return string
603 606
 	 */
604 607
 	public function getChecksum($algo = null) {
Please login to merge, or discard this patch.
apps/dav/appinfo/Migrations/Version20170202213905.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 
29 29
 	/**
30 30
 	 * @param IDBConnection $connection
31
-	 * @return array
31
+	 * @return string[]
32 32
 	 */
33 33
 	public function sql(IDBConnection $connection) {
34 34
 		$qb = $connection->getQueryBuilder();
Please login to merge, or discard this patch.
lib/private/Files/Storage/Home.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@
 block discarded – undo
99 99
 	 * get the owner of a path
100 100
 	 *
101 101
 	 * @param string $path The path to get the owner
102
-	 * @return string uid or false
102
+	 * @return integer uid or false
103 103
 	 */
104 104
 	public function getOwner($path) {
105 105
 		return $this->user->getUID();
Please login to merge, or discard this patch.
lib/private/User/User.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 	 *
72 72
 	 * @param Account $account
73 73
 	 * @param AccountMapper $mapper
74
-	 * @param null $emitter
74
+	 * @param Manager $emitter
75 75
 	 * @param IConfig|null $config
76 76
 	 * @param null $urlGenerator
77 77
 	 * @param EventDispatcher|null $eventDispatcher
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 	/**
97 97
 	 * get the user id
98 98
 	 *
99
-	 * @return string
99
+	 * @return integer
100 100
 	 */
101 101
 	public function getUID() {
102 102
 		return $this->account->getUserId();
@@ -413,6 +413,10 @@  discard block
 block discarded – undo
413 413
 		return $url;
414 414
 	}
415 415
 
416
+	/**
417
+	 * @param string $feature
418
+	 * @param string $value
419
+	 */
416 420
 	public function triggerChange($feature, $value = null) {
417 421
 		if ($this->emitter) {
418 422
 			$this->emitter->emit('\OC\User', 'changeUser', [$this, $feature, $value]);
Please login to merge, or discard this patch.
lib/public/AppFramework/Db/Mapper.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -308,6 +308,7 @@
 block discarded – undo
308 308
 	 * @param array $params the parameters of the sql query
309 309
 	 * @param int $limit the maximum number of rows
310 310
 	 * @param int $offset from which row we want to start
311
+	 * @param string $msg
311 312
 	 * @return string formatted error message string
312 313
 	 * @since 9.1.0
313 314
 	 */
Please login to merge, or discard this patch.
lib/base.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -329,7 +329,7 @@
 block discarded – undo
329 329
 	/**
330 330
 	 * Checks if the version requires an update and shows
331 331
 	 * @param bool $showTemplate Whether an update screen should get shown
332
-	 * @return bool
332
+	 * @return null|boolean
333 333
 	 */
334 334
 	public static function checkUpgrade($showTemplate = true) {
335 335
 		if (\OCP\Util::needUpgrade()) {
Please login to merge, or discard this patch.
lib/private/User/Account.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 
25 25
 
26 26
 use OCP\AppFramework\Db\Entity;
27
-use OCP\AppFramework\QueryException;
28 27
 use OCP\UserInterface;
29 28
 
30 29
 /**
Please login to merge, or discard this patch.
core/Migrations/Version20170221114437.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -1,11 +1,9 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace OC\Migrations;
3 3
 
4
-use OC\User\Account;
5 4
 use OC\User\AccountMapper;
6 5
 use OC\User\Database;
7 6
 use OC\User\SyncService;
8
-use OCP\IConfig;
9 7
 use OCP\Migration\ISimpleMigration;
10 8
 use OCP\Migration\IOutput;
11 9
 
Please login to merge, or discard this patch.