owncloud / core

apps/dav/lib/Connector/Sabre/TagList.php

Doc Comments +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
 	 * the next element.
 	 *
 	 * @param Reader $reader
-	 * @return mixed
+	 * @return null|TagList
 	 */
 	static function xmlDeserialize(Reader $reader) {
 		$tags = [];

apps/dav/lib/CardDAV/AddressBookImpl.php

Doc Comments +3 added lines, -3 removed lines

@@ -51,7 +51,7 @@ 
 	 * @param AddressBook $addressBook
 	 * @param array $addressBookInfo
 	 * @param CardDavBackend $backend
-	 * @param IUrlGenerator $urlGenerator
+	 * @param IURLGenerator $urlGenerator
 	 */
 	public function __construct(
 			AddressBook $addressBook,
@@ -134,7 +134,7 @@ 
 	}
 
 	/**
-	 * @return mixed
+	 * @return integer
 	 * @since 5.0.0
 	 */
 	public function getPermissions() {
@@ -172,7 +172,7 @@ 
 	 * read vCard data into a vCard object
 	 *
 	 * @param string $cardData
-	 * @return VCard
+	 * @return \Sabre\VObject\Parser\Sabre\VObject\Document|null
 	 */
 	protected function readCard($cardData) {
 		return  Reader::read($cardData);

apps/federation/lib/Controller/OCSAuthAPIController.php

Doc Comments +4 added lines

@@ -164,6 +164,10 @@
 			'data' => ['sharedSecret' => $sharedSecret]];
 	}
 
+	/**
+	 * @param string $url
+	 * @param string $token
+	 */
 	protected function isValidToken($url, $token) {
 		$storedToken = $this->dbHandler->getToken($url);
 		return hash_equals($storedToken, $token);

lib/private/AvatarManager.php

Doc Comments +3 added lines

@@ -99,6 +99,9 @@
 		}
 	}
 
+	/**
+	 * @param string $userId
+	 */
 	private function buildAvatarPath($userId) {
 		$avatar = substr_replace(substr_replace(md5($userId), '/', 4, 0), '/', 2, 0);
 		return explode('/', $avatar);

apps/dav/lib/CardDAV/ImageExportPlugin.php

Doc Comments +3 added lines

@@ -136,6 +136,9 @@
 		return false;
 	}
 
+	/**
+	 * @param string $cardData
+	 */
 	private function readCard($cardData) {
 		return Reader::read($cardData);
 	}

apps/dav/lib/Files/Xml/FilterRequest.php

Doc Comments +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
 	 * the next element.
 	 *
 	 * @param Reader $reader
-	 * @return mixed
+	 * @return FilterRequest
 	 */
 	static function xmlDeserialize(Reader $reader) {
 		$elems = (array)$reader->parseInnerTree([

lib/private/L10N/Factory.php

Doc Comments +5 added lines

@@ -278,6 +278,11 @@
 	 */
 	// FIXME This method is only public, until \OCP\IL10N does not need it anymore,
 	// FIXME This is also the reason, why it is not in the public interface
+
+	/**
+	 * @param string $app
+	 * @param string $lang
+	 */
 	public function getL10nFilesForApp($app, $lang) {
 		$languageFiles = [];
 

apps/updatenotification/lib/Notification/BackgroundJob.php

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 
 
 use OC\BackgroundJob\TimedJob;
-use OC\Installer;
 use OC\Updater\VersionCheck;
 use OCP\App\IAppManager;
 use OCP\Http\Client\IClientService;

apps/files_sharing/lib/SharedMount.php

Doc Comments +2 added lines, -2 removed lines

@@ -110,7 +110,7 @@ 
 	 *
 	 * @param string $newPath
 	 * @param \OCP\Share\IShare $share
-	 * @return bool
+	 * @return boolean|null
 	 */
 	private function updateFileTarget($newPath, &$share) {
 		$share->setTarget($newPath);
@@ -126,7 +126,7 @@ 
 	 * @param string $path
 	 * @param View $view
 	 * @param SharedMount[] $mountpoints
-	 * @return mixed
+	 * @return string
 	 */
 	private function generateUniqueTarget($path, $view, array $mountpoints) {
 		$pathinfo = pathinfo($path);