owncloud / core

lib/private/DB/Connection.php

Doc Comments +1 added lines, -1 removed lines

@@ -173,7 +173,7 @@
 	 * If an SQLLogger is configured, the execution is logged.
 	 *
 	 * @param string                                      $query  The SQL query to execute.
-	 * @param array                                       $params The parameters to bind to the query, if any.
+	 * @param string[]                                       $params The parameters to bind to the query, if any.
 	 * @param array                                       $types  The types the previous parameters are in.
 	 * @param \Doctrine\DBAL\Cache\QueryCacheProfile|null $qcp    The query cache profile, optional.
 	 *

Unused Use Statements -2 removed lines

@@ -33,14 +33,12 @@
 use Doctrine\DBAL\Configuration;
 use Doctrine\DBAL\Cache\QueryCacheProfile;
 use Doctrine\Common\EventManager;
-use Doctrine\DBAL\Exception\ConstraintViolationException;
 use Doctrine\DBAL\Platforms\MySqlPlatform;
 use Doctrine\DBAL\Schema\Schema;
 use OC\DB\QueryBuilder\QueryBuilder;
 use OCP\DB\QueryBuilder\IQueryBuilder;
 use OCP\IDBConnection;
 use OCP\PreConditionNotMetException;
-use OCP\Util;
 
 class Connection extends \Doctrine\DBAL\Connection implements IDBConnection {
 	/**

lib/private/legacy/db/statementwrapper.php

Doc Comments +1 added lines

@@ -44,6 +44,7 @@
 
 	/**
 	 * @param boolean $isManipulation
+	 * @param Doctrine\DBAL\Driver\Statement $statement
 	 */
 	public function __construct($statement, $isManipulation) {
 		$this->statement = $statement;

lib/private/Mail/Message.php

Doc Comments +2 added lines, -2 removed lines

@@ -109,7 +109,7 @@ 
 	/**
 	 * Returns the Reply-To address of this message
 	 *
-	 * @return array
+	 * @return string
 	 */
 	public function getReplyTo() {
 		return $this->swiftMessage->getReplyTo();
@@ -162,7 +162,7 @@ 
 	/**
 	 * Set the BCC recipients of this message.
 	 *
-	 * @param array $recipients Example: array('recipient@domain.org', 'other@domain.org' => 'A name')
+	 * @param string[] $recipients Example: array('recipient@domain.org', 'other@domain.org' => 'A name')
 	 * @return $this
 	 */
 	public function setBcc(array $recipients) {

apps/federatedfilesharing/lib/RequestHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -566,7 +566,7 @@
 	/**
 	 * update permissions in database
 	 *
-	 * @param IShare $share
+	 * @param Share\IShare $share
 	 * @param int $permissions
 	 */
 	protected function updatePermissionsInDatabase(IShare $share, $permissions) {

lib/private/legacy/db.php

Doc Comments -1 removed lines

@@ -150,7 +150,6 @@
 	/**
 	 * saves database schema to xml file
 	 * @param string $file name of file
-	 * @param int $mode
 	 * @return bool
 	 *
 	 * TODO: write more documentation

lib/private/Files/Config/LazyStorageMountInfo.php

Unused Use Statements -3 removed lines

@@ -21,10 +21,7 @@
 
 namespace OC\Files\Config;
 
-use OC\Files\Filesystem;
-use OCP\Files\Config\ICachedMountInfo;
 use OCP\Files\Mount\IMountPoint;
-use OCP\Files\Node;
 use OCP\IUser;
 
 class LazyStorageMountInfo extends CachedMountInfo {

lib/private/App/CodeChecker/NodeVisitor.php

Doc Comments +15 added lines

@@ -241,6 +241,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $name
+	 */
 	private function checkBlackList($name, $errorCode, Node $node) {
 		$lowerName = strtolower($name);
 
@@ -254,6 +257,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $constantName
+	 */
 	private function checkBlackListConstant($class, $constantName, Node $node) {
 		$name = $class . '::' . $constantName;
 		$lowerName = strtolower($name);
@@ -268,6 +274,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $class
+	 */
 	private function checkBlackListFunction($class, $functionName, Node $node) {
 		$name = $class . '::' . $functionName;
 		$lowerName = strtolower($name);
@@ -282,6 +291,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $class
+	 */
 	private function checkBlackListMethod($class, $functionName, Node $node) {
 		$name = $class . '::' . $functionName;
 		$lowerName = strtolower($name);
@@ -296,6 +308,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $name
+	 */
 	private function buildReason($name, $errorCode) {
 		if (isset($this->errorMessages[$errorCode])) {
 			$desc = $this->list->getDescription($errorCode, $name);

apps/files_external/lib/Lib/Storage/SMB.php

Doc Comments +7 added lines, -1 removed lines

@@ -260,6 +260,9 @@ 
 		return $this->leave(__FUNCTION__, $result);
 	}
 
+	/**
+	 * @param string $path
+	 */
 	private function removeFromCache($path) {
 		$path = trim($path, '/');
 		// TODO The CappedCache does not really clear by prefix. It just clears all.
@@ -632,7 +635,7 @@ 
 	 * if wnd.logging.enable is set to true in the config will log a leave line
 	 * with the given function, the return value or the exception
 	 *
-	 * @param $function
+	 * @param string $function
 	 * @param mixed $result an exception will be logged and then returned
 	 * @return mixed
 	 */
@@ -659,6 +662,9 @@ 
 		return $result;
 	}
 
+	/**
+	 * @param string $function
+	 */
 	private function swallow($function, \Exception $exception) {
 		if (\OC::$server->getConfig()->getSystemValue('wnd.logging.enable', false) === true) {
 			Util::writeLog('wnd', "$function swallowing ".get_class($exception)

core/Controller/OccController.php

Doc Comments +2 added lines, -2 removed lines

@@ -131,8 +131,8 @@
 
 	/**
 	 * Check if command is allowed and has a valid security token
-	 * @param $command
-	 * @param $token
+	 * @param string $command
+	 * @param string $token
 	 */
 	protected function validateRequest($command, $token){
 		$allowedHosts = ['::1', '127.0.0.1', 'localhost'];