owncloud / core

lib/private/User/Session.php

Doc Comments +4 added lines, -1 removed lines

@@ -300,7 +300,7 @@ 
 	 * @param IRequest $request
 	 * @throws LoginException
 	 * @throws PasswordLoginForbiddenException
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	public function logClientIn($user, $password, IRequest $request) {
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -340,6 +340,9 @@ 
 		return $this->config->getSystemValue('token_auth_enforced', false);
 	}
 
+	/**
+	 * @param string $username
+	 */
 	protected function isTwoFactorEnforced($username) {
 		Util::emitHook(
 			'\OCA\Files_Sharing\API\Server2Server',

apps/files_external/lib/Lib/Backend/SMB.php

Doc Comments +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
 	}
 
 	/**
-	 * @param StorageConfig $storage
+	 * @param IStorageConfig $storage
 	 * @param IUser $user
 	 */
 	public function manipulateStorageConfig(IStorageConfig &$storage, IUser $user = null) {

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use OCP\Files\External\Backend\Backend;
 use OCP\Files\External\IStorageConfig;
 use OCA\Files_External\Lib\LegacyDependencyCheckPolyfill;
-
 use OCP\IUser;
 
 class SMB extends Backend {

apps/dav/lib/DAV/PublicAuth.php

Doc Comments -1 removed lines

@@ -30,7 +30,6 @@
 	private $publicURLs;
 
 	/**
-	 * @param string[] $publicURLs
 	 */
 	public function __construct() {
 		$this->publicURLs = [

apps/files_external/lib/Lib/Backend/AmazonS3.php

Unused Use Statements -2 removed lines

@@ -22,11 +22,9 @@
 namespace OCA\Files_External\Lib\Backend;
 
 use OCP\IL10N;
-use OCP\Files\External\Auth\AuthMechanism;
 use OCP\Files\External\Backend\Backend;
 use OCP\Files\External\DefinitionParameter;
 use OCA\Files_External\Lib\LegacyDependencyCheckPolyfill;
-
 use OCA\Files_External\Lib\Auth\AmazonS3\AccessKey;
 
 class AmazonS3 extends Backend {

lib/private/Repair/RepairUnmergedShares.php

Doc Comments +1 added lines, -1 removed lines

@@ -207,7 +207,7 @@
 	 * @param array $groupSharesById
 	 * @param array $subShares
 	 *
-	 * @return true if the share is valid, false if it needs repair
+	 * @return boolean if the share is valid, false if it needs repair
 	 */
 	private function isThisShareValid($groupSharesById, $subShares) {
 		$foundTargets = [];

apps/dav/lib/Connector/Sabre/QuotaPlugin.php

Doc Comments +3 added lines

@@ -111,6 +111,9 @@
 		return true;
 	}
 
+	/**
+	 * @param string[] $info
+	 */
 	public function getFileChunking($info) {
 		// FIXME: need a factory for better mocking support
 		return new \OC_FileChunking($info);

apps/dav/lib/SystemTag/SystemTagsObjectMappingCollection.php

Doc Comments +1 added lines, -1 removed lines

@@ -191,7 +191,7 @@
 	 *
 	 * @param ISystemTag $tag
 	 *
-	 * @return SystemTagNode
+	 * @return SystemTagMappingNode
 	 */
 	private function makeNode(ISystemTag $tag) {
 		return new SystemTagMappingNode(

Unused Use Statements -1 removed lines

@@ -26,7 +26,6 @@
 use Sabre\DAV\Exception\BadRequest;
 use Sabre\DAV\Exception\PreconditionFailed;
 use Sabre\DAV\ICollection;
-
 use OCP\SystemTag\ISystemTagManager;
 use OCP\SystemTag\ISystemTagObjectMapper;
 use OCP\SystemTag\ISystemTag;

lib/private/App/CodeChecker/CodeChecker.php

Unused Use Statements -2 removed lines

@@ -25,8 +25,6 @@
 
 use OC\Hooks\BasicEmitter;
 use PhpParser\Lexer;
-use PhpParser\Node;
-use PhpParser\Node\Name;
 use PhpParser\NodeTraverser;
 use PhpParser\Parser;
 use RecursiveCallbackFilterIterator;

lib/private/Console/TimestampFormatter.php

Doc Comments +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
 	 * Checks if output formatter has style with specified name.
 	 *
 	 * @param string $name
-	 * @return bool
+	 * @return boolean|null
 	 */
 	public function hasStyle($name) {
 		$this->formatter->hasStyle($name);