Completed
Pull Request — master (#28256)
by Philipp
11:54
created
lib/private/legacy/api.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -329,7 +329,7 @@
 block discarded – undo
329 329
 
330 330
 	/**
331 331
 	 * http basic auth
332
-	 * @return string|false (username, or false on failure)
332
+	 * @return string (username, or false on failure)
333 333
 	 */
334 334
 	private static function loginUser() {
335 335
 		if(self::$isLoggedIn === true) {
Please login to merge, or discard this patch.
lib/private/legacy/eventsource.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
 	 * send a message to the client
89 89
 	 *
90 90
 	 * @param string $type
91
-	 * @param mixed $data
91
+	 * @param string $data
92 92
 	 *
93 93
 	 * @throws \BadMethodCallException
94 94
 	 * if only one parameter is given, a typeless message will be send with that parameter as data
Please login to merge, or discard this patch.
lib/private/Installer.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -476,7 +476,7 @@
 block discarded – undo
476 476
 
477 477
 	/**
478 478
 	 * Removes an app
479
-	 * @param string $name name of the application to remove
479
+	 * @param string $appId
480 480
 	 * @return boolean
481 481
 	 *
482 482
 	 *
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -38,9 +38,6 @@
 block discarded – undo
38 38
 
39 39
 namespace OC;
40 40
 
41
-use OC\App\CodeChecker\CodeChecker;
42
-use OC\App\CodeChecker\EmptyCheck;
43
-use OC\App\CodeChecker\PrivateCheck;
44 41
 use OC_App;
45 42
 use OC_DB;
46 43
 use OC_Helper;
Please login to merge, or discard this patch.
apps/updatenotification/lib/Notification/Notifier.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -103,6 +103,9 @@
 block discarded – undo
103 103
 		return \OC_App::getAppVersions();
104 104
 	}
105 105
 
106
+	/**
107
+	 * @param string $appId
108
+	 */
106 109
 	protected function getAppInfo($appId) {
107 110
 		return \OC_App::getAppInfo($appId);
108 111
 	}
Please login to merge, or discard this patch.
lib/public/App/ManagerEvent.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 	 * DispatcherEvent constructor.
47 47
 	 *
48 48
 	 * @param string $event
49
-	 * @param $appID
49
+	 * @param string $appID
50 50
 	 * @param \OCP\IGroup[] $groups
51 51
 	 * @since 9.0.0
52 52
 	 */
Please login to merge, or discard this patch.
apps/federation/lib/DbHandler.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -271,8 +271,8 @@
 block discarded – undo
271 271
 	}
272 272
 
273 273
 	/**
274
-	 * @param $username
275
-	 * @param $password
274
+	 * @param string $username
275
+	 * @param string $password
276 276
 	 * @return bool
277 277
 	 */
278 278
 	public function auth($username, $password) {
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/SyncService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -227,7 +227,7 @@
 block discarded – undo
227 227
 	}
228 228
 
229 229
 	/**
230
-	 * @return array|null
230
+	 * @return string
231 231
 	 */
232 232
 	public function getLocalSystemAddressBook() {
233 233
 		if (is_null($this->localSystemAddressBook)) {
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/ChecksumList.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,6 @@
 block discarded – undo
21 21
 namespace OCA\DAV\Connector\Sabre;
22 22
 
23 23
 use Sabre\Xml\XmlSerializable;
24
-use Sabre\Xml\Element;
25 24
 use Sabre\Xml\Writer;
26 25
 
27 26
 /**
Please login to merge, or discard this patch.
apps/dav/lib/DAV/SystemPrincipalBackend.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@
 block discarded – undo
136 136
 	 * Returns the list of members for a group-principal
137 137
 	 *
138 138
 	 * @param string $principal
139
-	 * @return array
139
+	 * @return string[]
140 140
 	 */
141 141
 	function getGroupMemberSet($principal) {
142 142
 		// TODO: for now the group principal has only one member, the user itself
Please login to merge, or discard this patch.