Completed
Pull Request — master (#28256)
by Philipp
11:54
created
lib/private/L10N/L10N.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -176,7 +176,7 @@
 block discarded – undo
176 176
 	 * Returns an associative array with all translations
177 177
 	 *
178 178
 	 * Called by \OC_L10N_String
179
-	 * @return array
179
+	 * @return string[]
180 180
 	 */
181 181
 	public function getTranslations() {
182 182
 		return $this->translations;
Please login to merge, or discard this patch.
lib/private/legacy/helper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -554,7 +554,7 @@
 block discarded – undo
554 554
 	 *
555 555
 	 * @param string $path
556 556
 	 * @param \OCP\Files\FileInfo $rootInfo (optional)
557
-	 * @return array
557
+	 * @return string
558 558
 	 * @throws \OCP\Files\NotFoundException
559 559
 	 */
560 560
 	public static function getStorageInfo($path, $rootInfo = null) {
Please login to merge, or discard this patch.
lib/private/legacy/template/functions.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
  * make preview_icon available as a simple function
183 183
  * Returns the path to the preview of the image.
184 184
  * @param string $path path of file
185
- * @return link to the preview
185
+ * @return string to the preview
186 186
  */
187 187
 function preview_icon( $path ) {
188 188
 	return \OC::$server->getURLGenerator()->linkToRoute('core_ajax_preview', ['x' => 32, 'y' => 32, 'file' => $path]);
@@ -190,6 +190,7 @@  discard block
 block discarded – undo
190 190
 
191 191
 /**
192 192
  * @param string $path
193
+ * @param string $token
193 194
  */
194 195
 function publicPreview_icon ( $path, $token ) {
195 196
 	return \OC::$server->getURLGenerator()->linkToRoute('core_ajax_public_preview', ['x' => 32, 'y' => 32, 'file' => $path, 't' => $token]);
Please login to merge, or discard this patch.
lib/private/Memcache/APC.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
 	 * Set a value in the cache if it's not already stored
65 65
 	 *
66 66
 	 * @param string $key
67
-	 * @param mixed $value
67
+	 * @param integer $value
68 68
 	 * @param int $ttl Time To Live in seconds. Defaults to 60*60*24
69 69
 	 * @return bool
70 70
 	 */
Please login to merge, or discard this patch.
lib/private/Memcache/APCu.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
 	 * Set a value in the cache if it's not already stored
65 65
 	 *
66 66
 	 * @param string $key
67
-	 * @param mixed $value
67
+	 * @param integer $value
68 68
 	 * @param int $ttl Time To Live in seconds. Defaults to 60*60*24
69 69
 	 * @return bool
70 70
 	 */
Please login to merge, or discard this patch.
lib/private/Memcache/ArrayCache.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
 	 * Set a value in the cache if it's not already stored
65 65
 	 *
66 66
 	 * @param string $key
67
-	 * @param mixed $value
67
+	 * @param integer $value
68 68
 	 * @param int $ttl Time To Live in seconds. Defaults to 60*60*24
69 69
 	 * @return bool
70 70
 	 */
Please login to merge, or discard this patch.
lib/private/Memcache/Memcached.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@
 block discarded – undo
158 158
 	 * Set a value in the cache if it's not already stored
159 159
 	 *
160 160
 	 * @param string $key
161
-	 * @param mixed $value
161
+	 * @param integer $value
162 162
 	 * @param int $ttl Time To Live in seconds. Defaults to 60*60*24
163 163
 	 * @return bool
164 164
 	 * @throws \Exception
Please login to merge, or discard this patch.
lib/private/Security/CredentialsManager.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 use OCP\Security\ICrypto;
25 25
 use OCP\IDBConnection;
26 26
 use OCP\Security\ICredentialsManager;
27
-use OCP\IConfig;
28 27
 
29 28
 /**
30 29
  * Store and retrieve credentials for external services
Please login to merge, or discard this patch.
lib/private/Server.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1166,7 +1166,7 @@
 block discarded – undo
1166 1166
 	 * Get the certificate manager for the user
1167 1167
 	 *
1168 1168
 	 * @param string $userId (optional) if not specified the current loggedin user is used, use null to get the system certificate manager
1169
-	 * @return \OCP\ICertificateManager | null if $uid is null and no user is logged in
1169
+	 * @return null|CertificateManager | null if $uid is null and no user is logged in
1170 1170
 	 */
1171 1171
 	public function getCertificateManager($userId = '') {
1172 1172
 		if ($userId === '') {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -46,8 +46,6 @@
 block discarded – undo
46 46
 use OC\AppFramework\Utility\TimeFactory;
47 47
 use OC\Command\AsyncBus;
48 48
 use OC\Diagnostics\EventLogger;
49
-use OC\Diagnostics\NullEventLogger;
50
-use OC\Diagnostics\NullQueryLogger;
51 49
 use OC\Diagnostics\QueryLogger;
52 50
 use OC\Files\Config\UserMountCache;
53 51
 use OC\Files\Config\UserMountCacheListener;
Please login to merge, or discard this patch.