Completed
Pull Request — master (#28256)
by Philipp
11:54
created
core/Application.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,6 @@
 block discarded – undo
33 33
 use OC\Core\Controller\CloudController;
34 34
 use OC\Core\Controller\LoginController;
35 35
 use OC\Core\Controller\LostController;
36
-use OC\Core\Controller\OccController;
37 36
 use OC\Core\Controller\TokenController;
38 37
 use OC\Core\Controller\TwoFactorChallengeController;
39 38
 use OC\Core\Controller\UserController;
Please login to merge, or discard this patch.
core/Middleware/TwoFactorMiddleware.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -101,6 +101,10 @@
 block discarded – undo
101 101
 		// TODO: dont check/enforce 2FA if a auth token is used
102 102
 	}
103 103
 
104
+	/**
105
+	 * @param Controller $controller
106
+	 * @param string $methodName
107
+	 */
104 108
 	private function checkTwoFactor($controller, $methodName) {
105 109
 		// If two-factor auth is in progress disallow access to any controllers
106 110
 		// defined within "LoginController".
Please login to merge, or discard this patch.
lib/private/Files/Cache/Cache.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -402,6 +402,9 @@
 block discarded – undo
402 402
 		}
403 403
 	}
404 404
 
405
+	/**
406
+	 * @param string $path
407
+	 */
405 408
 	private function getParentPath($path) {
406 409
 		$parent = dirname($path);
407 410
 		if ($parent === '.') {
Please login to merge, or discard this patch.
lib/private/Files/Cache/Wrapper/CacheJail.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 
74 74
 	/**
75 75
 	 * @param array $entry
76
-	 * @return array
76
+	 * @return string
77 77
 	 */
78 78
 	protected function formatCacheEntry($entry) {
79 79
 		if (isset($entry['path'])) {
@@ -192,6 +192,9 @@  discard block
 block discarded – undo
192 192
 		return $this->cache->getStatus($this->getSourcePath($file));
193 193
 	}
194 194
 
195
+	/**
196
+	 * @param \OCP\Files\Cache\ICacheEntry[] $results
197
+	 */
195 198
 	private function formatSearchResults($results) {
196 199
 		$results = array_filter($results, [$this, 'filterCacheEntry']);
197 200
 		$results = array_values($results);
Please login to merge, or discard this patch.
lib/private/Files/External/Service/StoragesService.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,6 @@
 block discarded – undo
29 29
 
30 30
 use OC\Files\Filesystem;
31 31
 use OC\Files\External\StorageConfig;
32
-
33 32
 use OCP\Files\External\IStorageConfig;
34 33
 use OCP\Files\External\Backend\Backend;
35 34
 use OCP\Files\External\Auth\AuthMechanism;
Please login to merge, or discard this patch.
lib/private/Files/External/StoragesBackendService.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,6 @@
 block discarded – undo
23 23
 namespace OC\Files\External;
24 24
 
25 25
 use OCP\IConfig;
26
-
27 26
 use OCP\Files\External\Backend\Backend;
28 27
 use OCP\Files\External\Auth\AuthMechanism;
29 28
 use OCP\Files\External\Config\IBackendProvider;
Please login to merge, or discard this patch.
lib/private/Files/ObjectStore/ObjectStoreStorage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -155,6 +155,9 @@
 block discarded – undo
155 155
 		return true;
156 156
 	}
157 157
 
158
+	/**
159
+	 * @param string $path
160
+	 */
158 161
 	private function rmObjects($path) {
159 162
 		$children = $this->getCache()->getFolderContents($path);
160 163
 		foreach ($children as $child) {
Please login to merge, or discard this patch.
lib/private/Files/Storage/Flysystem.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -54,6 +54,9 @@
 block discarded – undo
54 54
 		$this->flysystem->addPlugin(new GetWithMetadata());
55 55
 	}
56 56
 
57
+	/**
58
+	 * @param string $path
59
+	 */
57 60
 	protected function buildPath($path) {
58 61
 		$fullPath = \OC\Files\Filesystem::normalizePath($this->root . '/' . $path);
59 62
 		return ltrim($fullPath, '/');
Please login to merge, or discard this patch.
lib/private/Files/Type/Loader.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,6 @@
 block discarded – undo
23 23
 
24 24
 use OCP\Files\IMimeTypeLoader;
25 25
 use OCP\IDBConnection;
26
-
27 26
 use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
28 27
 
29 28
 /**
Please login to merge, or discard this patch.