owncloud / core

apps/files_encryption/tests/keymanager.php

Doc Comments -1 removed lines

@@ -382,7 +382,6 @@
 	/**
 	 * @param \OC\Files\View $view relative to data/
 	 * @param string $path
-	 * @param string $basePath
 	 */
 	public static function testKeySetPreperation($view, $path) {
 		self::keySetPreparation($view, $path);

apps/files_encryption/tests/migration.php

Doc Comments +15 added lines

@@ -118,6 +118,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $uid
+	 */
 	protected function createDummyShareKeys($uid) {
 		$this->view->mkdir($uid . '/files_encryption/share-keys/folder1/folder2/folder3');
 		$this->view->mkdir($uid . '/files_encryption/share-keys/folder2/');
@@ -141,6 +144,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $uid
+	 */
 	protected function createDummyFileKeys($uid) {
 		$this->view->mkdir($uid . '/files_encryption/keyfiles/folder1/folder2/folder3');
 		$this->view->mkdir($uid . '/files_encryption/keyfiles/folder2/');
@@ -150,6 +156,9 @@ 
 		$this->view->file_put_contents($uid . '/files_encryption/keyfiles/folder2/file.2.1.key'  , 'data');
 	}
 
+	/**
+	 * @param string $uid
+	 */
 	protected function createDummyFilesInTrash($uid) {
 		$this->view->mkdir($uid . '/files_trashbin/share-keys');
 		$this->view->mkdir($uid . '/files_trashbin/share-keys/folder1.d7437648723');
@@ -219,6 +228,9 @@ 
 
 	}
 
+	/**
+	 * @param string $uid
+	 */
 	protected function verifyFilesInTrash($uid) {
 		// share keys
 		$this->view->file_exists($uid . '/files_trashbin/keys/file1.d5457864/' . self::TEST_ENCRYPTION_MIGRATION_USER1 . '.shareKey.d5457864' , 'data');
@@ -231,6 +243,9 @@ 
 		$this->view->file_exists($uid . '/files_trashbin/keyfiles/folder1.d7437648723/file2/fileKey' , 'data');
 	}
 
+	/**
+	 * @param string $uid
+	 */
 	protected function verifyNewKeyPath($uid) {
 		// private key
 		if ($uid !== '') {

apps/files_encryption/tests/util.php

Doc Comments +7 added lines

@@ -567,6 +567,9 @@ 
 
 	}
 
+	/**
+	 * @param string $extension
+	 */
 	function getBackupPath($extension) {
 		$encPath = '/' . self::TEST_ENCRYPTION_UTIL_USER1 . '/files_encryption';
 		$encFolderContent = $this->view->getDirectoryContent($encPath);
@@ -662,6 +665,10 @@ 
  * dummy class extends  \OCA\Files_Encryption\Util to access protected methods for testing
  */
 class DummyUtilClass extends \OCA\Files_Encryption\Util {
+
+	/**
+	 * @param string $uid
+	 */
 	public function testIsMountPointApplicableToUser($mount, $uid) {
 		return $this->isMountPointApplicableToUser($mount, $uid);
 	}

apps/files_sharing/lib/external/storage.php

Doc Comments +3 added lines

@@ -90,6 +90,9 @@
 		return $this->token;
 	}
 
+	/**
+	 * @return resource
+	 */
 	public function getPassword() {
 		return $this->password;
 	}

Unused Use Statements -1 removed lines

@@ -30,7 +30,6 @@
 namespace OCA\Files_Sharing\Controllers;
 
 use OC;
-use OC\Files\Filesystem;
 use OC_Files;
 use OC_Util;
 use OCP;

apps/files_sharing/lib/helper.php

Doc Comments +3 added lines

@@ -138,6 +138,9 @@
 		return true;
 	}
 
+	/**
+	 * @param string $target
+	 */
 	public static function getSharesFromItem($target) {
 		$result = array();
 		$owner = \OC\Files\Filesystem::getOwner($target);

apps/files_sharing/tests/controller/sharecontroller.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use OCA\Files_Sharing\Application;
 use OCP\AppFramework\Http\NotFoundResponse;
 use OCP\AppFramework\IAppContainer;
-use OCP\Files;
 use OCP\AppFramework\Http\RedirectResponse;
 use OCP\AppFramework\Http\TemplateResponse;
 use OCP\Security\ISecureRandom;

apps/files_trashbin/lib/trashbin.php

Doc Comments +11 added lines, -8 removed lines

@@ -39,6 +39,9 @@ 
 	 */
 	private static $scannedVersions = false;
 
+	/**
+	 * @param string $filename
+	 */
 	public static function getUidAndFilename($filename) {
 		$uid = \OC\Files\Filesystem::getOwner($filename);
 		\OC\Files\Filesystem::initMountPoints($uid);
@@ -399,7 +402,7 @@ 
 	 * @param string $uniqueFilename new file name to restore the file without overwriting existing files
 	 * @param string $location location if file
 	 * @param int $timestamp deletion time
-	 * @return bool
+	 * @return false|null
 	 */
 	private static function restoreVersions(\OC\Files\View $view, $file, $filename, $uniqueFilename, $location, $timestamp) {
 
@@ -453,7 +456,7 @@ 
 	 * @param string $uniqueFilename new file name to restore the file without overwriting existing files
 	 * @param string $location location of file
 	 * @param int $timestamp deletion time
-	 * @return bool
+	 * @return false|null
 	 */
 	private static function restoreEncryptionKeys(\OC\Files\View $view, $file, $filename, $uniqueFilename, $location, $timestamp) {
 
@@ -550,9 +553,9 @@ 
 
 	/**
 	 * @param \OC\Files\View $view
-	 * @param $file
-	 * @param $filename
-	 * @param $timestamp
+	 * @param string $file
+	 * @param string $filename
+	 * @param integer|null $timestamp
 	 * @return int
 	 */
 	private static function deleteVersions(\OC\Files\View $view, $file, $filename, $timestamp) {
@@ -579,9 +582,9 @@ 
 
 	/**
 	 * @param \OC\Files\View $view
-	 * @param $file
-	 * @param $filename
-	 * @param $timestamp
+	 * @param string $file
+	 * @param string $filename
+	 * @param integer|null $timestamp
 	 * @return int
 	 */
 	private static function deleteEncryptionKeys(\OC\Files\View $view, $file, $filename, $timestamp) {

apps/files_trashbin/tests/storage.php

Unused Use Statements -2 removed lines

@@ -8,9 +8,7 @@
 
 namespace OCA\Files_trashbin\Tests\Storage;
 
-use OC\Files\Storage\Home;
 use OC\Files\Storage\Temporary;
-use OC\Files\Mount\MountPoint;
 use OC\Files\Filesystem;
 
 class Storage extends \Test\TestCase {

apps/files_versions/lib/storage.php

Doc Comments +1 added lines

@@ -531,6 +531,7 @@
 
 	/**
 	 * Erase a file's versions which exceed the set quota
+	 * @param integer $versionsSize
 	 */
 	private static function expire($filename, $versionsSize = null, $offset = 0) {
 		$config = \OC::$server->getConfig();