Completed
Pull Request — master (#24495)
by Blizzz
08:56
created
apps/federation/lib/dbhandler.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -271,8 +271,8 @@
 block discarded – undo
271 271
 	}
272 272
 
273 273
 	/**
274
-	 * @param $username
275
-	 * @param $password
274
+	 * @param string $username
275
+	 * @param string $password
276 276
 	 * @return bool
277 277
 	 */
278 278
 	public function auth($username, $password) {
Please login to merge, or discard this patch.
apps/files_sharing/api/sharees.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -327,7 +327,7 @@
 block discarded – undo
327 327
 	 * split user and remote from federated cloud id
328 328
 	 *
329 329
 	 * @param string $address federated share address
330
-	 * @return array [user, remoteURL]
330
+	 * @return string[] [user, remoteURL]
331 331
 	 * @throws \Exception
332 332
 	 */
333 333
 	public function splitUserRemote($address) {
Please login to merge, or discard this patch.
lib/private/template/functions.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
  * make preview_icon available as a simple function
184 184
  * Returns the path to the preview of the image.
185 185
  * @param string $path path of file
186
- * @return link to the preview
186
+ * @return string to the preview
187 187
  *
188 188
  * For further information have a look at OC_Helper::previewIcon
189 189
  */
@@ -193,6 +193,7 @@  discard block
 block discarded – undo
193 193
 
194 194
 /**
195 195
  * @param string $path
196
+ * @param string $token
196 197
  */
197 198
 function publicPreview_icon ( $path, $token ) {
198 199
 	return OC_Helper::publicPreviewIcon( $path, $token );
Please login to merge, or discard this patch.
lib/public/files.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,6 +45,7 @@  discard block
 block discarded – undo
45 45
 class Files {
46 46
 	/**
47 47
 	 * Recusive deletion of folders
48
+	 * @param string $dir
48 49
 	 * @return bool
49 50
 	 * @since 5.0.0
50 51
 	 */
@@ -66,7 +67,7 @@  discard block
 block discarded – undo
66 67
 	/**
67 68
 	 * Search for files by mimetype
68 69
 	 * @param string $mimetype
69
-	 * @return array
70
+	 * @return \OC\Files\FileInfo[]
70 71
 	 * @since 6.0.0
71 72
 	 */
72 73
 	static public function searchByMime( $mimetype ) {
Please login to merge, or discard this patch.
apps/dav/lib/dav/sharing/plugin.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,6 @@
 block discarded – undo
25 25
 use OCA\DAV\Connector\Sabre\Auth;
26 26
 use OCA\DAV\DAV\Sharing\Xml\Invite;
27 27
 use OCP\IRequest;
28
-use Sabre\DAV\Exception\BadRequest;
29 28
 use Sabre\DAV\Exception\NotFound;
30 29
 use Sabre\DAV\INode;
31 30
 use Sabre\DAV\PropFind;
Please login to merge, or discard this patch.
apps/dav/command/createaddressbook.php 1 patch
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -22,11 +22,6 @@
 block discarded – undo
22 22
 namespace OCA\DAV\Command;
23 23
 
24 24
 use OCA\DAV\CardDAV\CardDavBackend;
25
-use OCA\DAV\Connector\Sabre\Principal;
26
-use OCP\IConfig;
27
-use OCP\IDBConnection;
28
-use OCP\IGroupManager;
29
-use OCP\ILogger;
30 25
 use OCP\IUserManager;
31 26
 use Symfony\Component\Console\Command\Command;
32 27
 use Symfony\Component\Console\Input\InputArgument;
Please login to merge, or discard this patch.
apps/dav/command/syncsystemaddressbook.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -21,10 +21,8 @@
 block discarded – undo
21 21
 namespace OCA\DAV\Command;
22 22
 
23 23
 use OCA\DAV\CardDAV\SyncService;
24
-use OCP\IUserManager;
25 24
 use Symfony\Component\Console\Command\Command;
26 25
 use Symfony\Component\Console\Helper\ProgressBar;
27
-use Symfony\Component\Console\Input\InputArgument;
28 26
 use Symfony\Component\Console\Input\InputInterface;
29 27
 use Symfony\Component\Console\Output\OutputInterface;
30 28
 
Please login to merge, or discard this patch.
apps/dav/lib/connector/legacydavacl.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -59,6 +59,9 @@
 block discarded – undo
59 59
 		);
60 60
 	}
61 61
 
62
+	/**
63
+	 * @param boolean $toV2
64
+	 */
62 65
 	private function convertPrincipal($principal, $toV2) {
63 66
 		list(, $name) = URLUtil::splitPath($principal);
64 67
 		if ($toV2) {
Please login to merge, or discard this patch.
apps/dav/lib/connector/sabre/file.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@
 block discarded – undo
144 144
 		return true;
145 145
 	}
146 146
 
147
+	/**
148
+	 * @param string $path
149
+	 */
147 150
 	public function url_stat($path) {
148 151
 		if (isset(self::$data[$path])) {
149 152
 			$size = strlen(self::$data[$path]);
Please login to merge, or discard this patch.