Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
27 | class Config { |
||
28 | |||
29 | /** @var IConfig */ |
||
30 | private $config; |
||
31 | |||
32 | /** @var IRequest */ |
||
33 | private $request; |
||
34 | |||
35 | /** |
||
36 | * @param IConfig $config |
||
37 | * @param IRequest $request |
||
38 | */ |
||
39 | public function __construct(IConfig $config, IRequest $request) { |
||
43 | |||
44 | /** |
||
45 | * @param array $parameters |
||
46 | * @return \OC_OCS_Result |
||
47 | */ |
||
48 | public function setAppValue($parameters) { |
||
57 | |||
58 | /** |
||
59 | * @param array $parameters |
||
60 | * @return \OC_OCS_Result |
||
61 | */ |
||
62 | public function deleteAppValue($parameters) { |
||
70 | |||
71 | /** |
||
72 | * @return \OC_OCS_Result |
||
73 | */ |
||
74 | View Code Duplication | public function setAppValues() { |
|
90 | |||
91 | /** |
||
92 | * @return \OC_OCS_Result |
||
93 | */ |
||
94 | View Code Duplication | public function deleteAppValues() { |
|
110 | } |
||
111 |