Completed
Pull Request — master (#25351)
by Thomas
28:57
created
apps/files_trashbin/lib/Storage.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -777,7 +777,7 @@
 block discarded – undo
777 777
 	/**
778 778
 	 * check if path points to a files version
779 779
 	 *
780
-	 * @param $path
780
+	 * @param string $path
781 781
 	 * @return bool
782 782
 	 */
783 783
 	protected function isVersion($path) {
Please login to merge, or discard this patch.
apps/files_trashbin/lib/Trashbin.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -655,7 +655,7 @@  discard block
 block discarded – undo
655 655
 	 * if the size limit for the trash bin is reached, we delete the oldest
656 656
 	 * files in the trash bin until we meet the limit again
657 657
 	 *
658
-	 * @param array $files
658
+	 * @param \OCP\Files\FileInfo[] $files
659 659
 	 * @param string $user
660 660
 	 * @param int $availableSpace available disc space
661 661
 	 * @return int size of deleted files
@@ -683,7 +683,7 @@  discard block
 block discarded – undo
683 683
 	/**
684 684
 	 * delete files older then max storage time
685 685
 	 *
686
-	 * @param array $files list of files sorted by mtime
686
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
687 687
 	 * @param string $user
688 688
 	 * @return integer[] size of deleted files and number of deleted files
689 689
 	 */
Please login to merge, or discard this patch.
apps/files/lib/Service/TagService.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 
25 25
 namespace OCA\Files\Service;
26 26
 
27
-use OC\Files\FileInfo;
28 27
 use OCP\Files\Node;
29 28
 
30 29
 /**
Please login to merge, or discard this patch.
core/Middleware/TwoFactorMiddleware.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -79,6 +79,10 @@
 block discarded – undo
79 79
 		// TODO: throw exceptions if necessary
80 80
 	}
81 81
 
82
+	/**
83
+	 * @param Controller $controller
84
+	 * @param string $methodName
85
+	 */
82 86
 	private function checkTwoFactor($controller, $methodName) {
83 87
 		// If two-factor auth is in progress disallow access to any controllers
84 88
 		// defined within "LoginController".
Please login to merge, or discard this patch.
lib/private/legacy/template/functions.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
  * make preview_icon available as a simple function
184 184
  * Returns the path to the preview of the image.
185 185
  * @param string $path path of file
186
- * @return link to the preview
186
+ * @return string to the preview
187 187
  *
188 188
  * For further information have a look at OC_Helper::previewIcon
189 189
  */
@@ -193,6 +193,7 @@  discard block
 block discarded – undo
193 193
 
194 194
 /**
195 195
  * @param string $path
196
+ * @param string $token
196 197
  */
197 198
 function publicPreview_icon ( $path, $token ) {
198 199
 	return OC_Helper::publicPreviewIcon( $path, $token );
Please login to merge, or discard this patch.
lib/private/Template/Base.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@
 block discarded – undo
96 96
 	/**
97 97
 	 * Appends a variable
98 98
 	 * @param string $key key
99
-	 * @param mixed $value value
99
+	 * @param string $value value
100 100
 	 * @return boolean|null
101 101
 	 *
102 102
 	 * This function assigns a variable in an array context. If the key already
Please login to merge, or discard this patch.
apps/user_ldap/lib/Command/SetConfig.php 1 patch
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -73,8 +73,6 @@
 block discarded – undo
73 73
 	/**
74 74
 	 * save the configuration value as provided
75 75
 	 * @param string $configID
76
-	 * @param string $configKey
77
-	 * @param string $configValue
78 76
 	 */
79 77
 	protected function setValue($configID, $key, $value) {
80 78
 		$configHolder = new Configuration($configID);
Please login to merge, or discard this patch.
apps/user_ldap/lib/Jobs/UpdateGroups.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
 	}
69 69
 
70 70
 	/**
71
-	 * @return int
71
+	 * @return string
72 72
 	 */
73 73
 	static private function getRefreshInterval() {
74 74
 		//defaults to every hour
Please login to merge, or discard this patch.
apps/files_external/lib/Command/Config.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -26,11 +26,8 @@
 block discarded – undo
26 26
 use OCA\Files_external\NotFoundException;
27 27
 use OCA\Files_external\Service\GlobalStoragesService;
28 28
 use Symfony\Component\Console\Command\Command;
29
-use Symfony\Component\Console\Helper\Table;
30
-use Symfony\Component\Console\Helper\TableHelper;
31 29
 use Symfony\Component\Console\Input\InputArgument;
32 30
 use Symfony\Component\Console\Input\InputInterface;
33
-use Symfony\Component\Console\Input\InputOption;
34 31
 use Symfony\Component\Console\Output\OutputInterface;
35 32
 
36 33
 class Config extends Base {
Please login to merge, or discard this patch.