Completed
Pull Request — master (#25351)
by Thomas
28:57
created
apps/dav/lib/Connector/Sabre/ShareTypeList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@
 block discarded – undo
60 60
 	 * The deserialize method is called during xml parsing.
61 61
 	 *
62 62
 	 * @param Reader $reader
63
-	 * @return mixed
63
+	 * @return ShareTypeList
64 64
 	 */
65 65
 	static function xmlDeserialize(Reader $reader) {
66 66
 		$shareTypes = [];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/TagList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@
 block discarded – undo
78 78
 	 * the next element.
79 79
 	 *
80 80
 	 * @param Reader $reader
81
-	 * @return mixed
81
+	 * @return TagList
82 82
 	 */
83 83
 	static function xmlDeserialize(Reader $reader) {
84 84
 		$tags = [];
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/TagsPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 	private $tree;
47 47
 
48 48
 	/**
49
-	 * @param \Sabre\DAV\Tree $tree tree
49
+	 * @param ObjectTree $tree tree
50 50
 	 */
51 51
 	public function __construct(Tree $tree) {
52 52
 		$this->tree = $tree;
Please login to merge, or discard this patch.
apps/dav/lib/DAV/SystemPrincipalBackend.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@
 block discarded – undo
136 136
 	 * Returns the list of members for a group-principal
137 137
 	 *
138 138
 	 * @param string $principal
139
-	 * @return array
139
+	 * @return string[]
140 140
 	 */
141 141
 	function getGroupMemberSet($principal) {
142 142
 		// TODO: for now the group principal has only one member, the user itself
Please login to merge, or discard this patch.
apps/dav/lib/Files/BrowserErrorPagePlugin.php 1 patch
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -86,8 +86,6 @@
 block discarded – undo
86 86
 
87 87
 	/**
88 88
 	 * @codeCoverageIgnore
89
-	 * @param \Exception $ex
90
-	 * @param int $httpCode
91 89
 	 * @return bool|string
92 90
 	 */
93 91
 	public function generateBody(\Exception $exception) {
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagsByIdCollection.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCP\IUser;
28 28
 use OCP\ILogger;
29 29
 use OCP\Files\Folder;
30
-
31 30
 use OC\Share20\Exception\ShareNotFound;
32 31
 
33 32
 /**
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagsObjectMappingCollection.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCP\IUser;
28 28
 use OCP\ILogger;
29 29
 use OCP\Files\Folder;
30
-
31 30
 use OC\Share20\Exception\ShareNotFound;
32 31
 
33 32
 /**
Please login to merge, or discard this patch.
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -89,6 +89,9 @@
 block discarded – undo
89 89
 		$this->user = $user;
90 90
 	}
91 91
 
92
+	/**
93
+	 * @param string $tagId
94
+	 */
92 95
 	function createFile($tagId, $data = null) {
93 96
 		try {
94 97
 			$tags = $this->tagManager->getTagsByIds([$tagId]);
Please login to merge, or discard this patch.
apps/dav/lib/SystemTag/SystemTagsObjectTypeCollection.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCP\IUser;
28 28
 use OCP\ILogger;
29 29
 use OCP\Files\Folder;
30
-
31 30
 use OC\Share20\Exception\ShareNotFound;
32 31
 
33 32
 /**
Please login to merge, or discard this patch.
apps/dav/lib/Upload/AssemblyStream.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 
101 101
 	/**
102 102
 	 * @param string $data
103
-	 * @return int
103
+	 * @return boolean
104 104
 	 */
105 105
 	public function stream_write($data) {
106 106
 		return false;
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 	}
207 207
 
208 208
 	/**
209
-	 * @param $pos
209
+	 * @param integer $pos
210 210
 	 * @return IFile | null
211 211
 	 */
212 212
 	private function getNodeForPosition($pos) {
Please login to merge, or discard this patch.