owncloud / core

apps/files/lib/Command/VerifyChecksums.php

Doc Comments +2 added lines, -2 removed lines

@@ -173,7 +173,7 @@ 
 
 	/**
 	 * @param Node $node
-	 * @param $correctChecksum
+	 * @param string $correctChecksum
 	 * @throws NotFoundException
 	 * @throws \OCP\Files\InvalidPathException
 	 * @throws \OCP\Files\StorageNotAvailableException
@@ -188,7 +188,7 @@ 
 	}
 
 	/**
-	 * @param $path
+	 * @param string $path
 	 * @param IStorage $storage
 	 * @return string
 	 * @throws \OCP\Files\StorageNotAvailableException

apps/federation/lib/Controller/OCSAuthAPIController.php

Doc Comments +4 added lines

@@ -172,6 +172,10 @@
 			'data' => ['sharedSecret' => $sharedSecret]];
 	}
 
+	/**
+	 * @param string $url
+	 * @param string $token
+	 */
 	protected function isValidToken($url, $token) {
 		$storedToken = $this->dbHandler->getToken($url);
 		return \hash_equals($storedToken, $token);

apps/files_external/lib/Lib/Storage/SMB.php

Doc Comments +7 added lines, -1 removed lines

@@ -284,6 +284,9 @@ 
 		return $this->leave(__FUNCTION__, $result);
 	}
 
+	/**
+	 * @param string $path
+	 */
 	private function removeFromCache($path) {
 		$path = \trim($path, '/');
 		// TODO The CappedCache does not really clear by prefix. It just clears all.
@@ -673,7 +676,7 @@ 
 	 * if smb.logging.enable is set to true in the config will log a leave line
 	 * with the given function, the return value or the exception
 	 *
-	 * @param $function
+	 * @param string $function
 	 * @param mixed $result an exception will be logged and then returned
 	 * @return mixed
 	 */
@@ -700,6 +703,9 @@ 
 		return $result;
 	}
 
+	/**
+	 * @param string $function
+	 */
 	private function swallow($function, \Exception $exception) {
 		if (\OC::$server->getConfig()->getSystemValue('smb.logging.enable', false) === true) {
 			Util::writeLog('smb', "$function swallowing ".\get_class($exception)

apps/files_sharing/lib/Controller/ShareesController.php

Doc Comments +2 added lines, -2 removed lines

@@ -443,7 +443,7 @@ 
 	 * split user and remote from federated cloud id
 	 *
 	 * @param string $address federated share address
-	 * @return array [user, remoteURL]
+	 * @return string[] [user, remoteURL]
 	 * @throws \Exception
 	 */
 	public function splitUserRemote($address) {
@@ -658,7 +658,7 @@ 
 	 * trusted domain entries
 	 *
 	 * @param string $target target
-	 * @return true if one match was found, false otherwise
+	 * @return boolean if one match was found, false otherwise
 	 */
 	protected function isInstanceDomain($target) {
 		if (\strpos($target, '/') !== false) {

apps/files_sharing/lib/SharedMount.php

Doc Comments +2 added lines, -2 removed lines

@@ -109,7 +109,7 @@ 
 	 *
 	 * @param string $newPath
 	 * @param \OCP\Share\IShare $share
-	 * @return bool
+	 * @return boolean|null
 	 */
 	private function updateFileTarget($newPath, &$share) {
 		$share->setTarget($newPath);
@@ -125,7 +125,7 @@ 
 	 * @param string $path
 	 * @param View $view
 	 * @param SharedMount[] $mountpoints
-	 * @return mixed
+	 * @return string
 	 */
 	private function generateUniqueTarget($path, $view, array $mountpoints) {
 		$pathinfo = \pathinfo($path);

core/Command/Security/ListRoutes.php

Doc Comments +3 added lines

@@ -121,6 +121,9 @@
 		}
 	}
 
+	/**
+	 * @param integer $name
+	 */
 	private function buildController($name) {
 		$parts = \explode('.', $name);
 		if (\count($parts) === 4 && $parts[0] === 'ocs') {

lib/private/App/AppManager.php

Doc Comments +7 added lines, -4 removed lines

@@ -132,7 +132,7 @@ 
 	/**
 	 * List all installed apps
 	 *
-	 * @return string[]
+	 * @return integer[]
 	 */
 	public function getInstalledApps() {
 		return \array_keys($this->getInstalledAppsValues());
@@ -241,7 +241,7 @@ 
 	/**
 	 * Do not allow more than one active app-theme
 	 *
-	 * @param $appId
+	 * @param string $appId
 	 * @throws AppManagerException
 	 */
 	protected function canEnableTheme($appId) {
@@ -400,6 +400,9 @@ 
 		return \in_array($appId, $this->shippedApps);
 	}
 
+	/**
+	 * @param string $appId
+	 */
 	private function isAlwaysEnabled($appId) {
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
 		return \in_array($appId, $alwaysEnabled);
@@ -428,7 +431,7 @@ 
 	/**
 	 * @param string $package package path
 	 * @param bool $skipMigrations whether to skip migrations, which would only install the code
-	 * @return string|false app id or false in case of error
+	 * @return integer app id or false in case of error
 	 * @since 10.0
 	 */
 	public function installApp($package, $skipMigrations = false) {
@@ -441,7 +444,7 @@ 
 
 	/**
 	 * @param string $package
-	 * @return mixed
+	 * @return boolean
 	 * @since 10.0
 	 */
 	public function updateApp($package) {

lib/private/App/CodeChecker/NodeVisitor.php

Doc Comments +15 added lines

@@ -241,6 +241,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $name
+	 */
 	private function checkBlackList($name, $errorCode, Node $node) {
 		$lowerName = \strtolower($name);
 
@@ -254,6 +257,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $constantName
+	 */
 	private function checkBlackListConstant($class, $constantName, Node $node) {
 		$name = $class . '::' . $constantName;
 		$lowerName = \strtolower($name);
@@ -268,6 +274,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $class
+	 */
 	private function checkBlackListFunction($class, $functionName, Node $node) {
 		$name = $class . '::' . $functionName;
 		$lowerName = \strtolower($name);
@@ -282,6 +291,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $class
+	 */
 	private function checkBlackListMethod($class, $functionName, Node $node) {
 		$name = $class . '::' . $functionName;
 		$lowerName = \strtolower($name);
@@ -296,6 +308,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $name
+	 */
 	private function buildReason($name, $errorCode) {
 		if (isset($this->errorMessages[$errorCode])) {
 			$desc = $this->list->getDescription($errorCode, $name);

lib/private/AvatarManager.php

Doc Comments +3 added lines

@@ -98,6 +98,9 @@
 		}
 	}
 
+	/**
+	 * @param string $userId
+	 */
 	private function buildAvatarPath($userId) {
 		$avatar = \substr_replace(\substr_replace(\md5($userId), '/', 4, 0), '/', 2, 0);
 		return \explode('/', $avatar);