Completed
Pull Request — master (#23919)
by Roeland
09:13
created
apps/dav/lib/caldav/caldavbackend.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1036,7 +1036,7 @@  discard block
 block discarded – undo
1036 1036
 	 * @param string $principalUri
1037 1037
 	 * @param string $uri
1038 1038
 	 * @param array $properties
1039
-	 * @return mixed
1039
+	 * @return integer
1040 1040
 	 */
1041 1041
 	function createSubscription($principalUri, $uri, array $properties) {
1042 1042
 
@@ -1377,6 +1377,9 @@  discard block
 block discarded – undo
1377 1377
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
1378 1378
 	}
1379 1379
 
1380
+	/**
1381
+	 * @param boolean $toV2
1382
+	 */
1380 1383
 	private function convertPrincipal($principalUri, $toV2) {
1381 1384
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1382 1385
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
apps/dav/lib/carddav/carddavbackend.php 1 patch
Doc Comments   +7 added lines, -2 removed lines patch added patch discarded remove patch
@@ -187,7 +187,8 @@  discard block
 block discarded – undo
187 187
 	}
188 188
 
189 189
 	/**
190
-	 * @param $addressBookUri
190
+	 * @param string $addressBookUri
191
+	 * @param string $principal
191 192
 	 * @return array|null
192 193
 	 */
193 194
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -867,6 +868,7 @@  discard block
 block discarded – undo
867 868
 	 *   * readOnly - boolean
868 869
 	 *   * summary - Optional, a description for the share
869 870
 	 *
871
+	 * @param integer $addressBookId
870 872
 	 * @return array
871 873
 	 */
872 874
 	public function getShares($addressBookId) {
@@ -966,7 +968,7 @@  discard block
 block discarded – undo
966 968
 
967 969
 	/**
968 970
 	 * For shared address books the sharee is set in the ACL of the address book
969
-	 * @param $addressBookId
971
+	 * @param integer $addressBookId
970 972
 	 * @param $acl
971 973
 	 * @return array
972 974
 	 */
@@ -974,6 +976,9 @@  discard block
 block discarded – undo
974 976
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
975 977
 	}
976 978
 
979
+	/**
980
+	 * @param boolean $toV2
981
+	 */
977 982
 	private function convertPrincipal($principalUri, $toV2) {
978 983
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
979 984
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.