Completed
Pull Request — master (#23919)
by Roeland
09:13
created
apps/dav/lib/upload/assemblystream.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 
101 101
 	/**
102 102
 	 * @param string $data
103
-	 * @return int
103
+	 * @return boolean
104 104
 	 */
105 105
 	public function stream_write($data) {
106 106
 		return false;
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 	}
207 207
 
208 208
 	/**
209
-	 * @param $pos
209
+	 * @param integer $pos
210 210
 	 * @return IFile | null
211 211
 	 */
212 212
 	private function getNodeForPosition($pos) {
Please login to merge, or discard this patch.
apps/dav/lib/connector/sabre/sharetypelist.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@
 block discarded – undo
60 60
 	 * The deserialize method is called during xml parsing.
61 61
 	 *
62 62
 	 * @param Reader $reader
63
-	 * @return mixed
63
+	 * @return ShareTypeList
64 64
 	 */
65 65
 	static function xmlDeserialize(Reader $reader) {
66 66
 		$shareTypes = [];
Please login to merge, or discard this patch.
apps/files/controller/apicontroller.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,6 @@
 block discarded – undo
35 35
 use OCA\Files\Service\TagService;
36 36
 use OCP\IPreview;
37 37
 use OCP\Share\IManager;
38
-use OCP\Files\FileInfo;
39 38
 use OCP\Files\Node;
40 39
 use OCP\IUserSession;
41 40
 
Please login to merge, or discard this patch.
apps/files/service/tagservice.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 
25 25
 namespace OCA\Files\Service;
26 26
 
27
-use OC\Files\FileInfo;
28 27
 use OCP\Files\Node;
29 28
 
30 29
 /**
Please login to merge, or discard this patch.
lib/private/Share20/Manager.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -25,7 +25,6 @@  discard block
 block discarded – undo
25 25
 use OCP\IUserManager;
26 26
 use OCP\Share\IManager;
27 27
 use OCP\Share\IProviderFactory;
28
-use OC\Share20\Exception\BackendError;
29 28
 use OCP\IConfig;
30 29
 use OCP\IL10N;
31 30
 use OCP\ILogger;
@@ -35,7 +34,6 @@  discard block
 block discarded – undo
35 34
 use OCP\IGroupManager;
36 35
 use OCP\Files\File;
37 36
 use OCP\Files\Folder;
38
-
39 37
 use OCP\Share\Exceptions\ShareNotFound;
40 38
 use OCP\Share\Exceptions\GenericShareException;
41 39
 
Please login to merge, or discard this patch.
apps/dav/lib/files/browsererrorpageplugin.php 1 patch
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -86,8 +86,6 @@
 block discarded – undo
86 86
 
87 87
 	/**
88 88
 	 * @codeCoverageIgnore
89
-	 * @param \Exception $ex
90
-	 * @param int $httpCode
91 89
 	 * @return bool|string
92 90
 	 */
93 91
 	public function generateBody(\Exception $exception) {
Please login to merge, or discard this patch.
lib/private/encryption/util.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 use OC\Files\Filesystem;
31 31
 use OC\Files\View;
32 32
 use OCP\Encryption\IEncryptionModule;
33
-use OCP\Files\Storage;
34 33
 use OCP\IConfig;
35 34
 
36 35
 class Util {
Please login to merge, or discard this patch.
lib/public/appframework/db/mapper.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -308,6 +308,7 @@  discard block
 block discarded – undo
308 308
 	 * @param array $params the parameters of the sql query
309 309
 	 * @param int $limit the maximum number of rows
310 310
 	 * @param int $offset from which row we want to start
311
+	 * @param string $msg
311 312
 	 * @return string formatted error message string
312 313
 	 * @since 9.1.0
313 314
 	 */
@@ -360,7 +361,7 @@  discard block
 block discarded – undo
360 361
 	 * Returns an db result and throws exceptions when there are more or less
361 362
 	 * results
362 363
 	 * @param string $sql the sql query
363
-	 * @param array $params the parameters of the sql query
364
+	 * @param string[] $params the parameters of the sql query
364 365
 	 * @param int $limit the maximum number of rows
365 366
 	 * @param int $offset from which row we want to start
366 367
 	 * @throws DoesNotExistException if the item does not exist
Please login to merge, or discard this patch.
lib/private/db/migrator.php 1 patch
Doc Comments   +9 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 	private $noEmit = false;
61 61
 
62 62
 	/**
63
-	 * @param \Doctrine\DBAL\Connection|Connection $connection
63
+	 * @param Connection $connection
64 64
 	 * @param ISecureRandom $random
65 65
 	 * @param IConfig $config
66 66
 	 * @param EventDispatcher $dispatcher
@@ -273,6 +273,10 @@  discard block
 block discarded – undo
273 273
 		return '/^' . preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')) . '/';
274 274
 	}
275 275
 
276
+	/**
277
+	 * @param integer $step
278
+	 * @param integer $max
279
+	 */
276 280
 	protected function emit($sql, $step, $max) {
277 281
 		if ($this->noEmit) {
278 282
 			return;
@@ -283,6 +287,10 @@  discard block
 block discarded – undo
283 287
 		$this->dispatcher->dispatch('\OC\DB\Migrator::executeSql', new GenericEvent($sql, [$step+1, $max]));
284 288
 	}
285 289
 
290
+	/**
291
+	 * @param integer $step
292
+	 * @param integer $max
293
+	 */
286 294
 	private function emitCheckStep($tableName, $step, $max) {
287 295
 		if(is_null($this->dispatcher)) {
288 296
 			return;
Please login to merge, or discard this patch.