Completed
Pull Request — master (#31547)
by Jörn Friedrich
21:53 queued 05:12
created
apps/dav/lib/Connector/Sabre/TagList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@
 block discarded – undo
77 77
 	 * the next element.
78 78
 	 *
79 79
 	 * @param Reader $reader
80
-	 * @return mixed
80
+	 * @return null|TagList
81 81
 	 */
82 82
 	public static function xmlDeserialize(Reader $reader) {
83 83
 		$tags = [];
Please login to merge, or discard this patch.
apps/dav/lib/DAV/FileCustomPropertiesBackend.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -223,7 +223,7 @@
 block discarded – undo
223 223
 
224 224
 	/**
225 225
 	 * @param string $path
226
-	 * @return INode|null
226
+	 * @return null|Node
227 227
 	 */
228 228
 	protected function getNodeForPath($path) {
229 229
 		$node = parent::getNodeForPath($path);
Please login to merge, or discard this patch.
apps/dav/lib/DAV/SystemPrincipalBackend.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
 	 * Returns the list of members for a group-principal
144 144
 	 *
145 145
 	 * @param string $principal
146
-	 * @return array
146
+	 * @return string[]
147 147
 	 */
148 148
 	public function getGroupMemberSet($principal) {
149 149
 		// TODO: for now the group principal has only one member, the user itself
Please login to merge, or discard this patch.
apps/dav/lib/Upload/AssemblyStreamZsync.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
 	/**
184 184
 	 * @param IFile[] $nodes
185 185
 	 * @param IFile $backingFile
186
-	 * @param $fileLength
186
+	 * @param string $fileLength
187 187
 	 * @return resource
188 188
 	 *
189 189
 	 * @throws \BadMethodCallException
@@ -207,6 +207,9 @@  discard block
 block discarded – undo
207 207
 		return $wrapped;
208 208
 	}
209 209
 
210
+	/**
211
+	 * @param integer $current
212
+	 */
210 213
 	protected function getNextNodeStart($current) {
211 214
 		foreach ($this->sortedNodes as $node) {
212 215
 			if ($current >= $node['start'] && $current < $node['end']) {
@@ -220,7 +223,7 @@  discard block
 block discarded – undo
220 223
 	}
221 224
 
222 225
 	/**
223
-	 * @param $pos
226
+	 * @param integer $pos
224 227
 	 */
225 228
 	protected function getNodeForPosition($pos) {
226 229
 		foreach ($this->sortedNodes as $node) {
Please login to merge, or discard this patch.
apps/dav/lib/Upload/ChunkingPluginZsync.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -107,6 +107,7 @@
 block discarded – undo
107 107
 	 *
108 108
 	 * @param string &$zsyncMetadata actual metadata
109 109
 	 * @param string $destination destination path
110
+	 * @param string|null $zsyncMetadata
110 111
 	 */
111 112
 	private function postMoveZsync(&$zsyncMetadata, $destination) {
112 113
 		if (!$zsyncMetadata) {
Please login to merge, or discard this patch.
apps/files_sharing/lib/External/Manager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -308,6 +308,9 @@
 block discarded – undo
308 308
 		return $result;
309 309
 	}
310 310
 
311
+	/**
312
+	 * @param string $mountPoint
313
+	 */
311 314
 	public function removeShare($mountPoint) {
312 315
 		$mountPointObj = $this->mountManager->find($mountPoint);
313 316
 		$id = $mountPointObj->getStorage()->getCache()->getId('');
Please login to merge, or discard this patch.
apps/files_trashbin/lib/Storage.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@
 block discarded – undo
134 134
 	 * check if it is a file located in data/user/files only files in the
135 135
 	 * 'files' directory should be moved to the trash
136 136
 	 *
137
-	 * @param $path
137
+	 * @param string $path
138 138
 	 * @return bool
139 139
 	 */
140 140
 	protected function shouldMoveToTrash($path) {
Please login to merge, or discard this patch.
apps/files_versions/lib/Storage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -315,6 +315,9 @@
 block discarded – undo
315 315
 		}
316 316
 	}
317 317
 
318
+	/**
319
+	 * @param string $revision
320
+	 */
318 321
 	public static function restoreVersion($uid, $filename, $fileToRestore, $revision) {
319 322
 		if (\OCP\Config::getSystemValue('files_versions', Storage::DEFAULTENABLED) !== true) {
320 323
 			return false;
Please login to merge, or discard this patch.
core/Command/User/SyncBackend.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
 	 * @param SyncService $syncService
170 170
 	 * @param UserInterface $backend
171 171
 	 * @param string $missingAccountsAction
172
-	 * @param array $validActions
172
+	 * @param string[] $validActions
173 173
 	 */
174 174
 	private function syncMultipleUsers(
175 175
 		InputInterface $input,
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
 	 * @param UserInterface $backend
218 218
 	 * @param string $uid
219 219
 	 * @param string $missingAccountsAction
220
-	 * @param array $validActions
220
+	 * @param string[] $validActions
221 221
 	 */
222 222
 	private function syncSingleUser(
223 223
 		InputInterface $input,
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
 	}
259 259
 
260 260
 	/**
261
-	 * @param array $uids a list of uids to the the action
261
+	 * @param string[] $uids a list of uids to the the action
262 262
 	 * @param callable $callbackExists the callback used if the account for the uid exists. The
263 263
 	 * uid and the specific account will be passed as parameter to the callback in that order
264 264
 	 * @param callable $callbackMissing the callback used if the account doesn't exists. The uid (not
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
 	 * @param string[] $unknownUsers
280 280
 	 * @param InputInterface $input
281 281
 	 * @param OutputInterface $output
282
-	 * @param $missingAccountsAction
282
+	 * @param string $missingAccountsAction
283 283
 	 * @param $validActions
284 284
 	 */
285 285
 	private function handleUnknownUsers(array $unknownUsers, InputInterface $input, OutputInterface $output, $missingAccountsAction, $validActions) {
Please login to merge, or discard this patch.