owncloud / core

lib/private/AvatarManager.php

Doc Comments +3 added lines

@@ -99,6 +99,9 @@
 		}
 	}
 
+	/**
+	 * @param string $userId
+	 */
 	private function buildAvatarPath($userId) {
 		$avatar = substr_replace(substr_replace(md5($userId), '/', 4, 0), '/', 2, 0);
 		return explode('/', $avatar);

lib/private/legacy/app.php

Doc Comments +3 added lines, -3 removed lines

@@ -164,7 +164,7 @@ 
 
 	/**
 	 * Enables the app as a theme if it has the type "theme"
-	 * @param $app
+	 * @param string $app
 	 */
 	private static function enableTheme($app) {
 		if (self::isType($app, 'theme')) {
@@ -1365,8 +1365,8 @@ 
 	}
 
 	/**
-	 * @param $config
-	 * @param $l
+	 * @param OCP\IConfig $config
+	 * @param OCP\IL10N $l
 	 * @param $info
 	 * @throws Exception
 	 */

apps/dav/lib/CardDAV/ImageExportPlugin.php

Doc Comments +3 added lines

@@ -136,6 +136,9 @@
 		return false;
 	}
 
+	/**
+	 * @param string $cardData
+	 */
 	private function readCard($cardData) {
 		return Reader::read($cardData);
 	}

lib/private/L10N/Factory.php

Doc Comments +5 added lines

@@ -278,6 +278,11 @@
 	 */
 	// FIXME This method is only public, until \OCP\IL10N does not need it anymore,
 	// FIXME This is also the reason, why it is not in the public interface
+
+	/**
+	 * @param string $app
+	 * @param string $lang
+	 */
 	public function getL10nFilesForApp($app, $lang) {
 		$languageFiles = [];
 

lib/private/Settings/SettingsManager.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use OCP\IUser;
 use OCP\ILogger;
 use OCP\Files\Folder;
-
 use OC\Share20\Exception\ShareNotFound;
 
 /**

apps/dav/lib/Connector/Sabre/FilesReportPlugin.php

Doc Comments +3 added lines, -2 removed lines

@@ -148,7 +148,7 @@ 
 	 * This will be used in the {DAV:}supported-report-set property.
 	 *
 	 * @param string $uri
-	 * @return array
+	 * @return string[]
 	 */
 	public function getSupportedReportSet($uri) {
 		return [self::REPORT_NAME];
@@ -160,7 +160,7 @@ 
 	 * @param string $reportName
 	 * @param $report
 	 * @param string $uri
-	 * @return bool
+	 * @return null|false
 	 * @throws BadRequest
 	 * @throws PreconditionFailed
 	 * @internal param $ [] $report
@@ -333,6 +333,7 @@ 
 	 * with a leading slash but no trailing slash
 	 * @param string[] $requestedProps requested properties
 	 * @param Node[] nodes nodes for which to fetch and prepare responses
+	 * @param Node[] $nodes
 	 * @return Response[]
 	 */
 	public function prepareResponses($filesUri, $requestedProps, $nodes) {

apps/files_external/lib/Lib/Backend/Google.php

Unused Use Statements -1 removed lines

@@ -22,7 +22,6 @@
 namespace OCA\Files_External\Lib\Backend;
 
 use OCP\IL10N;
-use OCP\Files\External\DefinitionParameter;
 use OCP\Files\External\Auth\AuthMechanism;
 use OCP\Files\External\Backend\Backend;
 use OCA\Files_External\Lib\LegacyDependencyCheckPolyfill;

apps/files_external/lib/Lib/Backend/Dropbox.php

Unused Use Statements -1 removed lines

@@ -22,7 +22,6 @@
 namespace OCA\Files_External\Lib\Backend;
 
 use OCP\IL10N;
-use OCP\Files\External\DefinitionParameter;
 use OCP\Files\External\Auth\AuthMechanism;
 use OCP\Files\External\Backend\Backend;
 use OCA\Files_External\Lib\LegacyDependencyCheckPolyfill;

apps/files_sharing/lib/SharedMount.php

Doc Comments +2 added lines, -2 removed lines

@@ -110,7 +110,7 @@ 
 	 *
 	 * @param string $newPath
 	 * @param \OCP\Share\IShare $share
-	 * @return bool
+	 * @return boolean|null
 	 */
 	private function updateFileTarget($newPath, &$share) {
 		$share->setTarget($newPath);
@@ -126,7 +126,7 @@ 
 	 * @param string $path
 	 * @param View $view
 	 * @param SharedMount[] $mountpoints
-	 * @return mixed
+	 * @return string
 	 */
 	private function generateUniqueTarget($path, $view, array $mountpoints) {
 		$pathinfo = pathinfo($path);