Completed
Pull Request — master (#30188)
by Jörn Friedrich
20:20 queued 09:40
created
lib/private/AvatarManager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -98,6 +98,9 @@
 block discarded – undo
98 98
 		}
99 99
 	}
100 100
 
101
+	/**
102
+	 * @param string $userId
103
+	 */
101 104
 	private function buildAvatarPath($userId) {
102 105
 		$avatar = \substr_replace(\substr_replace(\md5($userId), '/', 4, 0), '/', 2, 0);
103 106
 		return \explode('/', $avatar);
Please login to merge, or discard this patch.
lib/private/Comments/Manager.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -206,7 +206,7 @@
 block discarded – undo
206 206
 	/**
207 207
 	 * removes an entry from the comments run time cache
208 208
 	 *
209
-	 * @param mixed $id the comment's id
209
+	 * @param string $id the comment's id
210 210
 	 */
211 211
 	protected function uncache($id) {
212 212
 		$id = \strval($id);
Please login to merge, or discard this patch.
lib/private/DB/Migrator.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -234,6 +234,10 @@
 block discarded – undo
234 234
 		return '/^' . \preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')) . '/';
235 235
 	}
236 236
 
237
+	/**
238
+	 * @param integer $step
239
+	 * @param integer $max
240
+	 */
237 241
 	protected function emit($sql, $step, $max) {
238 242
 		if ($this->noEmit) {
239 243
 			return;
Please login to merge, or discard this patch.
lib/private/Files/Cache/Cache.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -409,6 +409,9 @@
 block discarded – undo
409 409
 		}
410 410
 	}
411 411
 
412
+	/**
413
+	 * @param string $path
414
+	 */
412 415
 	private function getParentPath($path) {
413 416
 		$parent = \dirname($path);
414 417
 		if ($parent === '.') {
Please login to merge, or discard this patch.
lib/private/Files/Cache/Wrapper/CacheJail.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 
75 75
 	/**
76 76
 	 * @param array $entry
77
-	 * @return array
77
+	 * @return string
78 78
 	 */
79 79
 	protected function formatCacheEntry($entry) {
80 80
 		if (isset($entry['path'])) {
@@ -193,6 +193,9 @@  discard block
 block discarded – undo
193 193
 		return $this->cache->getStatus($this->getSourcePath($file));
194 194
 	}
195 195
 
196
+	/**
197
+	 * @param \OCP\Files\Cache\ICacheEntry[] $results
198
+	 */
196 199
 	private function formatSearchResults($results) {
197 200
 		$results = \array_filter($results, [$this, 'filterCacheEntry']);
198 201
 		$results = \array_values($results);
Please login to merge, or discard this patch.
lib/private/Files/Node/Root.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 	 * @param string $path
176 176
 	 * @throws \OCP\Files\NotFoundException
177 177
 	 * @throws \OCP\Files\NotPermittedException
178
-	 * @return File|Folder
178
+	 * @return string
179 179
 	 */
180 180
 	public function get($path) {
181 181
 		$path = $this->normalizePath($path);
@@ -374,6 +374,9 @@  discard block
 block discarded – undo
374 374
 
375 375
 	}
376 376
 
377
+	/**
378
+	 * @param string $fullPath
379
+	 */
377 380
 	private function resolveVirtualNode($fullPath) {
378 381
 		$pieces = \explode('/', $fullPath);
379 382
 		if ($pieces[1] !== 'meta') {
Please login to merge, or discard this patch.
lib/private/Files/Stream/Checksum.php 1 patch
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -64,8 +64,8 @@  discard block
 block discarded – undo
64 64
 
65 65
 
66 66
 	/**
67
-	 * @param $source
68
-	 * @param $path
67
+	 * @param resource $source
68
+	 * @param string $path
69 69
 	 * @return resource
70 70
 	 */
71 71
 	public static function wrap($source, $path) {
@@ -126,6 +126,9 @@  discard block
 block discarded – undo
126 126
 		return parent::stream_write($data);
127 127
 	}
128 128
 
129
+	/**
130
+	 * @param string $data
131
+	 */
129 132
 	private function updateHashingContexts($data) {
130 133
 		foreach ($this->hashingContexts as $ctx) {
131 134
 			\hash_update($ctx, $data);
@@ -199,7 +202,7 @@  discard block
 block discarded – undo
199 202
 	}
200 203
 
201 204
 	/**
202
-	 * @return mixed
205
+	 * @return string
203 206
 	 * @return string
204 207
 	 */
205 208
 	private function getPathFromStreamContext() {
Please login to merge, or discard this patch.
lib/private/Files/Stream/StaticStream.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -145,6 +145,9 @@
 block discarded – undo
145 145
 		return true;
146 146
 	}
147 147
 
148
+	/**
149
+	 * @param string $path
150
+	 */
148 151
 	public function url_stat($path) {
149 152
 		if (isset(self::$data[$path])) {
150 153
 			$size = \strlen(self::$data[$path]);
Please login to merge, or discard this patch.
lib/private/Tags.php 1 patch
Doc Comments   +10 added lines, -2 removed lines patch added patch discarded remove patch
@@ -742,11 +742,19 @@  discard block
 block discarded – undo
742 742
 	}
743 743
 
744 744
 	// case-insensitive array_search
745
+
746
+	/**
747
+	 * @param string $needle
748
+	 */
745 749
 	protected function array_searchi($needle, $haystack, $mem='getName') {
746 750
 		if(!\is_array($haystack)) {
747 751
 			return false;
748 752
 		}
749 753
 		return \array_search(\strtolower($needle), \array_map(
754
+
755
+			/**
756
+			 * @param string $tag
757
+			 */
750 758
 			function($tag) use($mem) {
751 759
 				return \strtolower(\call_user_func([$tag, $mem]));
752 760
 			}, $haystack)
@@ -771,7 +779,7 @@  discard block
 block discarded – undo
771 779
 	* Get a tag by its name.
772 780
 	*
773 781
 	* @param string $name The tag name.
774
-	* @return integer|bool The tag object's offset within the $this->tags
782
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
775 783
 	*                      array or false if it doesn't exist.
776 784
 	*/
777 785
 	private function getTagByName($name) {
@@ -782,7 +790,7 @@  discard block
 block discarded – undo
782 790
 	* Get a tag by its ID.
783 791
 	*
784 792
 	* @param string $id The tag ID to look for.
785
-	* @return integer|bool The tag object's offset within the $this->tags
793
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
786 794
 	*                      array or false if it doesn't exist.
787 795
 	*/
788 796
 	private function getTagById($id) {
Please login to merge, or discard this patch.