Completed
Pull Request — master (#32767)
by Sujith
17:56 queued 07:59
created
lib/private/Files/Cache/Wrapper/CacheJail.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 
75 75
 	/**
76 76
 	 * @param array $entry
77
-	 * @return array
77
+	 * @return string
78 78
 	 */
79 79
 	protected function formatCacheEntry($entry) {
80 80
 		if (isset($entry['path'])) {
@@ -193,6 +193,9 @@  discard block
 block discarded – undo
193 193
 		return $this->cache->getStatus($this->getSourcePath($file));
194 194
 	}
195 195
 
196
+	/**
197
+	 * @param \OCP\Files\Cache\ICacheEntry[] $results
198
+	 */
196 199
 	private function formatSearchResults($results) {
197 200
 		$results = \array_filter($results, [$this, 'filterCacheEntry']);
198 201
 		$results = \array_values($results);
Please login to merge, or discard this patch.
lib/private/Files/Stream/StaticStream.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -145,6 +145,9 @@
 block discarded – undo
145 145
 		return true;
146 146
 	}
147 147
 
148
+	/**
149
+	 * @param string $path
150
+	 */
148 151
 	public function url_stat($path) {
149 152
 		if (isset(self::$data[$path])) {
150 153
 			$size = \strlen(self::$data[$path]);
Please login to merge, or discard this patch.
lib/private/User/User.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 	 *
83 83
 	 * @param Account $account
84 84
 	 * @param AccountMapper $mapper
85
-	 * @param null $emitter
85
+	 * @param Manager $emitter
86 86
 	 * @param IConfig|null $config
87 87
 	 * @param null $urlGenerator
88 88
 	 * @param EventDispatcher|null $eventDispatcher
@@ -473,6 +473,10 @@  discard block
 block discarded – undo
473 473
 		return $url;
474 474
 	}
475 475
 
476
+	/**
477
+	 * @param string $feature
478
+	 * @param string $value
479
+	 */
476 480
 	public function triggerChange($feature, $value = null) {
477 481
 		if ($this->emitter && \in_array($feature, $this->account->getUpdatedFields())) {
478 482
 			$this->emitter->emit('\OC\User', 'changeUser', [$this, $feature, $value]);
Please login to merge, or discard this patch.
lib/private/Files/Utils/Scanner.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -170,7 +170,7 @@
 block discarded – undo
170 170
 	/**
171 171
 	 * Returns whether the given mount point should be scanned
172 172
 	 *
173
-	 * @param $mount mount point
173
+	 * @param \OC\Files\Mount\MountPoint|null $mount mount point
174 174
 	 * @return bool true to scan, false to skip
175 175
 	 */
176 176
 	private function shouldScan($mount) {
Please login to merge, or discard this patch.
lib/public/Share/IShareProvider.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,6 +63,7 @@  discard block
 block discarded – undo
63 63
 	 *
64 64
 	 * @param \OCP\Share\IShare $share
65 65
 	 * @since 9.0.0
66
+	 * @return void
66 67
 	 */
67 68
 	public function delete(\OCP\Share\IShare $share);
68 69
 
@@ -74,6 +75,7 @@  discard block
 block discarded – undo
74 75
 	 * @param \OCP\Share\IShare $share
75 76
 	 * @param string $recipient UserId of the recipient
76 77
 	 * @since 9.0.0
78
+	 * @return void
77 79
 	 */
78 80
 	public function deleteFromSelf(\OCP\Share\IShare $share, $recipient);
79 81
 
@@ -181,6 +183,7 @@  discard block
 block discarded – undo
181 183
 	 * @param string $uid
182 184
 	 * @param int $shareType
183 185
 	 * @since 9.1.0
186
+	 * @return void
184 187
 	 */
185 188
 	public function userDeleted($uid, $shareType);
186 189
 
@@ -191,6 +194,7 @@  discard block
 block discarded – undo
191 194
 	 *
192 195
 	 * @param string $gid
193 196
 	 * @since 9.1.0
197
+	 * @return void
194 198
 	 */
195 199
 	public function groupDeleted($gid);
196 200
 
@@ -202,6 +206,7 @@  discard block
 block discarded – undo
202 206
 	 * @param string $uid
203 207
 	 * @param string $gid
204 208
 	 * @since 9.1.0
209
+	 * @return void
205 210
 	 */
206 211
 	public function userDeletedFromGroup($uid, $gid);
207 212
 
@@ -213,7 +218,6 @@  discard block
 block discarded – undo
213 218
 	 *
214 219
 	 * @param \OCP\Share\IShare $share
215 220
 	 * @param string $recipient userId of recipient
216
-	 * @param int $state state to set
217 221
 	 * @return \OCP\Share\IShare
218 222
 	 * @since 10.0.9
219 223
 	 */
Please login to merge, or discard this patch.
lib/private/legacy/template.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -322,6 +322,7 @@
 block discarded – undo
322 322
 		* @param string $error_msg The error message to show
323 323
 		* @param string $hint An optional hint message - needs to be properly escaped
324 324
 		* @param int HTTP Status Code
325
+		* @param integer $httpStatusCode
325 326
 		*/
326 327
 	public static function printErrorPage($error_msg, $hint = '', $httpStatusCode = null) {
327 328
 		if ($error_msg === $hint) {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,6 @@
 block discarded – undo
37 37
  */
38 38
 
39 39
 use OC\TemplateLayout;
40
-use OCP\IL10N;
41 40
 use OCP\Theme\ITheme;
42 41
 
43 42
 require_once __DIR__.'/template/functions.php';
Please login to merge, or discard this patch.
lib/private/AppFramework/Utility/ControllerMethodReflector.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
 	}
44 44
 
45 45
 	/**
46
-	 * @param object|string $object an object or classname
46
+	 * @param \OCP\AppFramework\Controller $object an object or classname
47 47
 	 * @param string $method the method which we want to inspect
48 48
 	 * @throws \ReflectionException
49 49
 	 */
Please login to merge, or discard this patch.
lib/private/Files/Stream/Checksum.php 1 patch
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -61,8 +61,8 @@  discard block
 block discarded – undo
61 61
 	}
62 62
 
63 63
 	/**
64
-	 * @param $source
65
-	 * @param $path
64
+	 * @param resource $source
65
+	 * @param string $path
66 66
 	 * @return resource
67 67
 	 */
68 68
 	public static function wrap($source, $path) {
@@ -122,6 +122,9 @@  discard block
 block discarded – undo
122 122
 		return parent::stream_write($data);
123 123
 	}
124 124
 
125
+	/**
126
+	 * @param string $data
127
+	 */
125 128
 	private function updateHashingContexts($data) {
126 129
 		foreach ($this->hashingContexts as $ctx) {
127 130
 			\hash_update($ctx, $data);
@@ -195,7 +198,7 @@  discard block
 block discarded – undo
195 198
 	}
196 199
 
197 200
 	/**
198
-	 * @return mixed
201
+	 * @return string
199 202
 	 * @return string
200 203
 	 */
201 204
 	private function getPathFromStreamContext() {
Please login to merge, or discard this patch.
core/Command/User/ListUsers.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -77,6 +77,8 @@
 block discarded – undo
77 77
 
78 78
 	/**
79 79
 	 * If only a single attribute should be listed omit the key to make it fit in one row
80
+	 * @param string $key
81
+	 * @param boolean $useKey
80 82
 	 */
81 83
 	private function add(&$row, $key, $val, $useKey) {
82 84
 		if ($useKey) {
Please login to merge, or discard this patch.