owncloud / core

lib/private/User/TokenAuthModule.php

Unused Use Statements -1 removed lines

@@ -30,7 +30,6 @@
 use OCP\Authentication\IAuthModule;
 use OCP\IRequest;
 use OCP\ISession;
-use OCP\IUser;
 use OCP\IUserManager;
 use OCP\Session\Exceptions\SessionNotAvailableException;
 

lib/private/Notification/Manager.php

Doc Comments +2 added lines

@@ -113,6 +113,8 @@
 	 * INTERNAL USE ONLY!! This method isn't part of the IManager interface
 	 * @internal This should only be used by the RegisterNotifierEventImpl (the real implementation).
 	 * Do NOT use this method outside as it might not work as expected.
+	 * @param string $id
+	 * @param string $name
 	 */
 	public function registerBuiltNotifier(INotifier $notifier, $id, $name) {
 		if (!isset($this->builtNotifiersHolder[$id]) && !isset($this->notifiersInfo[$id])) {

settings/Controller/CorsController.php

Doc Comments -1 removed lines

@@ -134,7 +134,6 @@
 	 * @NoAdminRequired
 	 * @NoSubadminRequired
 	 *
-	 * @param string $domain Domain to remove
 	 * @return RedirectResponse Redirection to the settings page.
 	 */
 	public function removeDomain($id) {

core/Command/Db/ConvertType.php

Doc Comments +2 added lines, -2 removed lines

@@ -280,7 +280,7 @@ 
 	/**
 	 * @param Connection $fromDB
 	 * @param Connection $toDB
-	 * @param $app
+	 * @param string $app
 	 * @throws \Exception
 	 * @throws \OC\NeedsUpdateException
 	 */
@@ -410,7 +410,7 @@ 
 
 	/**
 	 * @param Table $table
-	 * @return mixed
+	 * @return string[]
 	 */
 	protected function getColumnTypes(Table $table) {
 		$tableName = $table->getName();

core/Middleware/TwoFactorMiddleware.php

Doc Comments +2 added lines, -2 removed lines

@@ -109,8 +109,8 @@
 	}
 
 	/**
-	 * @param $controller
-	 * @param $methodName
+	 * @param Controller $controller
+	 * @param string $methodName
 	 * @throws TwoFactorAuthRequiredException
 	 * @throws UserAlreadyLoggedInException
 	 */

lib/private/legacy/response.php

Doc Comments +2 added lines, -2 removed lines

@@ -274,7 +274,7 @@ 
 	 * @param string $userId
 	 * @param string $domain
 	 * @param \OCP\IConfig $config
-	 * @param array $headers
+	 * @param string[] $headers
 	 *
 	 * Format of $headers:
 	 * Array [
@@ -318,7 +318,7 @@ 
 	 * This function adds the CORS headers for all domains
 	 *
 	 * @param Sabre\HTTP\ResponseInterface $response
-	 * @param Array $headers
+	 * @param string[] $headers
 	 *
 	 * Format of $headers:
 	 * Array [

settings/Application.php

Unused Use Statements -3 removed lines

@@ -39,11 +39,8 @@
 use OC\Settings\Controller\AuthSettingsController;
 use OC\Settings\Controller\CertificateController;
 use OC\Settings\Controller\CheckSetupController;
-use OC\Settings\Controller\GroupsController;
 use OC\Settings\Controller\LogSettingsController;
 use OC\Settings\Controller\MailSettingsController;
-use OC\Settings\Controller\UsersController;
-use OC\Settings\Middleware\SubadminMiddleware;
 use OCP\AppFramework\App;
 use OCP\IContainer;
 use OCP\Util;

apps/files/lib/Command/VerifyChecksums.php

Doc Comments +2 added lines, -2 removed lines

@@ -173,7 +173,7 @@ 
 
 	/**
 	 * @param Node $node
-	 * @param $correctChecksum
+	 * @param string $correctChecksum
 	 * @throws NotFoundException
 	 * @throws \OCP\Files\InvalidPathException
 	 * @throws \OCP\Files\StorageNotAvailableException
@@ -188,7 +188,7 @@ 
 	}
 
 	/**
-	 * @param $path
+	 * @param string $path
 	 * @param IStorage $storage
 	 * @return string
 	 * @throws \OCP\Files\StorageNotAvailableException

apps/federation/lib/Controller/OCSAuthAPIController.php

Doc Comments +4 added lines

@@ -172,6 +172,10 @@
 			'data' => ['sharedSecret' => $sharedSecret]];
 	}
 
+	/**
+	 * @param string $url
+	 * @param string $token
+	 */
 	protected function isValidToken($url, $token) {
 		$storedToken = $this->dbHandler->getToken($url);
 		return \hash_equals($storedToken, $token);