AddressHandler::splitUserRemote() - Code Metrics - Inspection of "Federated sharing new spec" - owncloud/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#32303)

by Victor

created 2018-10-11 18:01 UTC

AddressHandler::splitUserRemote() B

↳ Parent: AddressHandler

Complexity

Conditions	11
Paths	25

Size

Total Lines

Duplication

Lines	21
Ratio	52.5 %

Importance

Changes

Metric	Value
cc	11
nc	25
nop	1
dl	21
loc	40
rs	7.3166
c	0
b	0
f	0

How to fix Complexity

<?php
/**
 * @author Björn Schießle <[email protected]>
 * @author Thomas Müller <[email protected]>
 *
 * @copyright Copyright (c) 2018, ownCloud GmbH
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

namespace OCA\FederatedFileSharing;
use OC\HintException;
use OCP\IL10N;
use OCP\IURLGenerator;

/**
 * Class AddressHandler - parse, modify and construct federated sharing addresses
 *
 * @package OCA\FederatedFileSharing
 */
class AddressHandler {

	/** @var IL10N */
	private $l;

	/** @var IURLGenerator */
	private $urlGenerator;

	/**
	 * AddressHandler constructor.
	 *
	 * @param IURLGenerator $urlGenerator
	 * @param IL10N $il10n
	 */
	public function __construct(
		IURLGenerator $urlGenerator,
		IL10N $il10n
	) {
		$this->l = $il10n;
		$this->urlGenerator = $urlGenerator;
	}

	/**
	 * split user and remote from federated cloud id
	 *
	 * @param string $address federated share address
	 * @return array [user, remoteURL]
	 * @throws HintException
	 */
	public function splitUserRemote($address) {
		if (\strpos($address, '@') === false) {
			$hint = $this->l->t('Invalid Federated Cloud ID');
			throw new HintException('Invalid Federated Cloud ID', $hint);
		}

		// Find the first character that is not allowed in user names
		$id = \str_replace('\\', '/', $address);
		$posSlash = \strpos($id, '/');
		$posColon = \strpos($id, ':');

		if ($posSlash === false && $posColon === false) {

			$invalidPos = \strlen($id);
		} elseif ($posSlash === false) {
			$invalidPos = $posColon;
		} elseif ($posColon === false) {
			$invalidPos = $posSlash;
		} else {
			$invalidPos = \min($posSlash, $posColon);
		}

		// Find the last @ before $invalidPos
		$pos = $lastAtPos = 0;
		while ($lastAtPos !== false && $lastAtPos <= $invalidPos) {

			$pos = $lastAtPos;
			$lastAtPos = \strpos($id, '@', $pos + 1);
		}

		if ($pos !== false) {

			$user = \substr($id, 0, $pos);
			$remote = \substr($id, $pos + 1);
			$remote = $this->fixRemoteURL($remote);
			if (!empty($user) && !empty($remote)) {
				return [$user, $remote];
			}
		}

		$hint = $this->l->t('Invalid Federated Cloud ID');
		throw new HintException('Invalid Federated Cloud ID', $hint);
	}

	/**
	 * @param string $uid
	 *
	 * @return Address
	 */
	public function getLocalUserFederatedAddress($uid) {
		$host = $this->generateRemoteURL();
		return new Address("{$uid}@{$host}");
	}

	/**
	 * generate remote URL part of federated ID
	 *
	 * @return string url of the current server
	 */
	public function generateRemoteURL() {
		$url = $this->urlGenerator->getAbsoluteURL('/');
		return $url;
	}

	/**
	 * remove protocol from URL
	 *
	 * @param string $url
	 * @return string
	 */
	public function removeProtocolFromUrl($url) {
		// replace all characters before :// and :// itself
		return \preg_replace('|^(.*?://)|', '', $url);
	}

	/**
	 * Strips away a potential file names and trailing slashes:
	 * - http://localhost
	 * - http://localhost/
	 * - http://localhost/index.php
	 * - http://localhost/index.php/s/{shareToken}
	 *
	 * all return: http://localhost
	 *
	 * @param string $remote
	 * @return string
	 */
	protected function fixRemoteURL($remote) {
		$remote = \str_replace('\\', '/', $remote);
		if ($fileNamePosition = \strpos($remote, '/index.php')) {
			$remote = \substr($remote, 0, $fileNamePosition);
		}
		$remote = \rtrim($remote, '/');

		return $remote;
	}
}


1			<?php
2			/**
3			* @author Björn Schießle <[email protected]>
4			* @author Thomas Müller <[email protected]>
5			*
6			* @copyright Copyright (c) 2018, ownCloud GmbH
7			* @license AGPL-3.0
8			*
9			* This code is free software: you can redistribute it and/or modify
10			* it under the terms of the GNU Affero General Public License, version 3,
11			* as published by the Free Software Foundation.
12			*
13			* This program is distributed in the hope that it will be useful,
14			* but WITHOUT ANY WARRANTY; without even the implied warranty of
15			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16			* GNU Affero General Public License for more details.
17			*
18			* You should have received a copy of the GNU Affero General Public License, version 3,
19			* along with this program. If not, see <http://www.gnu.org/licenses/>
20			*
21			*/
22
23			namespace OCA\FederatedFileSharing;
24			use OC\HintException;
25			use OCP\IL10N;
26			use OCP\IURLGenerator;
27
28			/**
29			* Class AddressHandler - parse, modify and construct federated sharing addresses
30			*
31			* @package OCA\FederatedFileSharing
32			*/
33			class AddressHandler {
34
35			/** @var IL10N */
36			private $l;
37
38			/** @var IURLGenerator */
39			private $urlGenerator;
40
41			/**
42			* AddressHandler constructor.
43			*
44			* @param IURLGenerator $urlGenerator
45			* @param IL10N $il10n
46	256		*/
47			public function __construct(
48			IURLGenerator $urlGenerator,
49			IL10N $il10n
50	256		) {
51	256		$this->l = $il10n;
52	256		$this->urlGenerator = $urlGenerator;
53			}
54
55			/**
56			* split user and remote from federated cloud id
57			*
58			* @param string $address federated share address
59			* @return array [user, remoteURL]
60			* @throws HintException
61	233		*/
62	233		public function splitUserRemote($address) {
63	4		if (\strpos($address, '@') === false) {
64	4		$hint = $this->l->t('Invalid Federated Cloud ID');
65			throw new HintException('Invalid Federated Cloud ID', $hint);
66			}
67
68	229		// Find the first character that is not allowed in user names
69	229		$id = \str_replace('\\', '/', $address);
70	229		$posSlash = \strpos($id, '/');
71			$posColon = \strpos($id, ':');
72	229
73	18	View Code Duplication	if ($posSlash === false && $posColon === false) {
			0 ignored issues – show Duplication introduced 2016-02-09 08:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
74	229		$invalidPos = \strlen($id);
75	5		} elseif ($posSlash === false) {
76	211		$invalidPos = $posColon;
77	41		} elseif ($posColon === false) {
78	41		$invalidPos = $posSlash;
79	165		} else {
80			$invalidPos = \min($posSlash, $posColon);
81			}
82
83	229		// Find the last @ before $invalidPos
84	229		$pos = $lastAtPos = 0;
85	229	View Code Duplication	while ($lastAtPos !== false && $lastAtPos <= $invalidPos) {
			0 ignored issues – show Duplication introduced 2016-09-21 14:38 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
86	229		$pos = $lastAtPos;
87	229		$lastAtPos = \strpos($id, '@', $pos + 1);
88			}
89	229
90	229	View Code Duplication	if ($pos !== false) {
			0 ignored issues – show Duplication introduced 2016-02-09 08:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
91	229		$user = \substr($id, 0, $pos);
92	229		$remote = \substr($id, $pos + 1);
93	229		$remote = $this->fixRemoteURL($remote);
94	225		if (!empty($user) && !empty($remote)) {
95			return [$user, $remote];
96	4		}
97			}
98	4
99	4		$hint = $this->l->t('Invalid Federated Cloud ID');
100			throw new HintException('Invalid Federated Cloud ID', $hint);
101			}
102
103			/**
104			* @param string $uid
105			*
106			* @return Address
107	9		*/
108	9		public function getLocalUserFederatedAddress($uid) {
109	9		$host = $this->generateRemoteURL();
110			return new Address("{$uid}@{$host}");
111			}
112
113			/**
114			* generate remote URL part of federated ID
115			*
116			* @return string url of the current server
117			*/
118			public function generateRemoteURL() {
119			$url = $this->urlGenerator->getAbsoluteURL('/');
120			return $url;
121	24		}
122	24
123	24		/**
124			* remove protocol from URL
125	24		*
126			* @param string $url
127	11		* @return string
128	11		*/
129	11		public function removeProtocolFromUrl($url) {
130	11		// replace all characters before :// and :// itself
131	11		return \preg_replace('\|^(.*?://)\|', '', $url);
132	11		}
133	11
134	11		/**
135	11		* Strips away a potential file names and trailing slashes:
136	11		* - http://localhost
137			* - http://localhost/
138	11		* - http://localhost/index.php
139	6		* - http://localhost/index.php/s/{shareToken}
140			*
141	5		* all return: http://localhost
142			*
143	18		* @param string $remote
144			* @return string
145			*/
146		View Code Duplication	protected function fixRemoteURL($remote) {
147			$remote = \str_replace('\\', '/', $remote);
148			if ($fileNamePosition = \strpos($remote, '/index.php')) {
149			$remote = \substr($remote, 0, $fileNamePosition);
150			}
151			$remote = \rtrim($remote, '/');
152	27
153	27		return $remote;
154	4		}
155			}
156

owncloud / core

Pull Request — master (#32303)

AddressHandler::splitUserRemote() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like