Completed
Pull Request — master (#31407)
by Jörn Friedrich
12:04
created
lib/public/Migration/IOutput.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,18 +32,21 @@  discard block
 block discarded – undo
32 32
 	/**
33 33
 	 * @param string $message
34 34
 	 * @since 9.1.0
35
+	 * @return void
35 36
 	 */
36 37
 	public function info($message);
37 38
 
38 39
 	/**
39 40
 	 * @param string $message
40 41
 	 * @since 9.1.0
42
+	 * @return void
41 43
 	 */
42 44
 	public function warning($message);
43 45
 
44 46
 	/**
45 47
 	 * @param int $max
46 48
 	 * @since 9.1.0
49
+	 * @return void
47 50
 	 */
48 51
 	public function startProgress($max = 0);
49 52
 
@@ -51,12 +54,13 @@  discard block
 block discarded – undo
51 54
 	 * @param int $step
52 55
 	 * @param string $description
53 56
 	 * @since 9.1.0
57
+	 * @return void
54 58
 	 */
55 59
 	public function advance($step = 1, $description = '');
56 60
 
57 61
 	/**
58
-	 * @param int $max
59 62
 	 * @since 9.1.0
63
+	 * @return void
60 64
 	 */
61 65
 	public function finishProgress();
62 66
 }
Please login to merge, or discard this patch.
settings/ChangePassword/Controller.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -67,6 +67,9 @@
 block discarded – undo
67 67
 		}
68 68
 	}
69 69
 
70
+	/**
71
+	 * @param string|boolean $username
72
+	 */
70 73
 	private static function sendNotificationMail($username) {
71 74
 		$userObject = \OC::$server->getUserManager()->get($username);
72 75
 		$email = $userObject->getEMailAddress();
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/SyncService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -245,7 +245,7 @@
 block discarded – undo
245 245
 	}
246 246
 
247 247
 	/**
248
-	 * @return array|null
248
+	 * @return string
249 249
 	 */
250 250
 	public function getLocalSystemAddressBook() {
251 251
 		if ($this->localSystemAddressBook === null) {
Please login to merge, or discard this patch.
apps/files_sharing/lib/Hooks.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,6 @@
 block discarded – undo
33 33
 use OCP\Share\IShare;
34 34
 use Symfony\Component\EventDispatcher\GenericEvent;
35 35
 use OCA\Files_Sharing\Service\NotificationPublisher;
36
-use OCP\Share\Exceptions\ShareNotFound;
37 36
 
38 37
 class Hooks {
39 38
 	/**
Please login to merge, or discard this patch.
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -138,6 +138,10 @@
 block discarded – undo
138 138
 		);
139 139
 	}
140 140
 
141
+	/**
142
+	 * @param IShare[] $shares
143
+	 * @param string $fileId
144
+	 */
141 145
 	private function filterSharesByFileId($shares, $fileId) {
142 146
 		return \array_filter($shares, function (IShare $share) use ($fileId) {
143 147
 			return \strval($share->getNodeId()) === \strval($fileId);
Please login to merge, or discard this patch.