owncloud / core

apps/dav/lib/SystemTag/SystemTagPlugin.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use OCP\IUser;
 use OCP\ILogger;
 use OCP\Files\Folder;
-
 use OC\Share20\Exception\ShareNotFound;
 
 /**

lib/private/Files/Config/LazyStorageMountInfo.php

Unused Use Statements -3 removed lines

@@ -21,10 +21,7 @@
 
 namespace OC\Files\Config;
 
-use OC\Files\Filesystem;
-use OCP\Files\Config\ICachedMountInfo;
 use OCP\Files\Mount\IMountPoint;
-use OCP\Files\Node;
 use OCP\IUser;
 
 class LazyStorageMountInfo extends CachedMountInfo {

apps/dav/lib/CardDAV/ImageExportPlugin.php

Doc Comments +4 added lines, -1 removed lines

@@ -130,13 +130,16 @@
 		return false;
 	}
 
+	/**
+	 * @param string $cardData
+	 */
 	private function readCard($cardData) {
 		return Reader::read($cardData);
 	}
 
 	/**
 	 * @param Binary $photo
-	 * @return Parameter
+	 * @return string|null
 	 */
 	private function getType($photo) {
 		$params = $photo->parameters();

lib/private/App/CodeChecker/NodeVisitor.php

Doc Comments +15 added lines

@@ -241,6 +241,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $name
+	 */
 	private function checkBlackList($name, $errorCode, Node $node) {
 		$lowerName = strtolower($name);
 
@@ -254,6 +257,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $constantName
+	 */
 	private function checkBlackListConstant($class, $constantName, Node $node) {
 		$name = $class . '::' . $constantName;
 		$lowerName = strtolower($name);
@@ -268,6 +274,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $class
+	 */
 	private function checkBlackListFunction($class, $functionName, Node $node) {
 		$name = $class . '::' . $functionName;
 		$lowerName = strtolower($name);
@@ -282,6 +291,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $class
+	 */
 	private function checkBlackListMethod($class, $functionName, Node $node) {
 		$name = $class . '::' . $functionName;
 		$lowerName = strtolower($name);
@@ -296,6 +308,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $name
+	 */
 	private function buildReason($name, $errorCode) {
 		if (isset($this->errorMessages[$errorCode])) {
 			$desc = $this->list->getDescription($errorCode, $name);

lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php

Doc Comments +1 added lines, -1 removed lines

@@ -360,7 +360,7 @@
 	 *
 	 * @param string $column
 	 * @param mixed $type One of IQueryBuilder::PARAM_*
-	 * @return string
+	 * @return QueryFunction
 	 */
 	public function castColumn($column, $type) {
 		return new QueryFunction(

apps/files_external/lib/Lib/Storage/SMB.php

Doc Comments +7 added lines, -1 removed lines

@@ -260,6 +260,9 @@ 
 		return $this->leave(__FUNCTION__, $result);
 	}
 
+	/**
+	 * @param string $path
+	 */
 	private function removeFromCache($path) {
 		$path = trim($path, '/');
 		// TODO The CappedCache does not really clear by prefix. It just clears all.
@@ -632,7 +635,7 @@ 
 	 * if wnd.logging.enable is set to true in the config will log a leave line
 	 * with the given function, the return value or the exception
 	 *
-	 * @param $function
+	 * @param string $function
 	 * @param mixed $result an exception will be logged and then returned
 	 * @return mixed
 	 */
@@ -659,6 +662,9 @@ 
 		return $result;
 	}
 
+	/**
+	 * @param string $function
+	 */
 	private function swallow($function, \Exception $exception) {
 		if (\OC::$server->getConfig()->getSystemValue('wnd.logging.enable', false) === true) {
 			Util::writeLog('wnd', "$function swallowing ".get_class($exception)

lib/private/AppFramework/Http/Request.php

Doc Comments +1 added lines, -1 removed lines

@@ -448,7 +448,7 @@
 
 	/**
 	 * Checks if the CSRF check was correct
-	 * @return bool true if CSRF check passed
+	 * @return null|boolean true if CSRF check passed
 	 */
 	public function passesCSRFCheck() {
 		if($this->csrfTokenManager === null) {

core/Controller/OccController.php

Doc Comments +2 added lines, -2 removed lines

@@ -131,8 +131,8 @@
 
 	/**
 	 * Check if command is allowed and has a valid security token
-	 * @param $command
-	 * @param $token
+	 * @param string $command
+	 * @param string $token
 	 */
 	protected function validateRequest($command, $token){
 		$allowedHosts = ['::1', '127.0.0.1', 'localhost'];